Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 23 Mar 2023 17:13:33 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 8/9] net: dsa: update TX path comments to not
 mention skb_mac_header()
Message-ID: <ZBx6rVPJwMWzIZ+M@corigine.com>
References: <20230322233823.1806736-1-vladimir.oltean@nxp.com>
 <20230322233823.1806736-9-vladimir.oltean@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230322233823.1806736-9-vladimir.oltean@nxp.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?w3f45VmxJDQktgPHkTBjbRW5Jf83TJd+dOyM8eJTz1IfgV90KUxnhWmw97eZ?=
 =?us-ascii?Q?ReM/QEmUJzFoBxzA9+VNizBLh5I3aw5YadVK8eFWhZSUMxUq1oVQE52250aR?=
 =?us-ascii?Q?p6KLwqP6U7xcBvYXLAvk3gmlbWOlTC0AqqWkSJzLo4F0tXI4uFKcsIRWAOeD?=
 =?us-ascii?Q?ubEB6cOdDqqxqH3/CZwmtEOrtPej2Hh5mf4FoetL+436PtFGuOpGarZldYfL?=
 =?us-ascii?Q?OiVNDgzSNge0fw2d/dGyKKb60Qr89A7o+yzQ3iekrL9QePRdtTOhyO2HL9Xj?=
 =?us-ascii?Q?xWP4o0FI/s+npHJLMh5MTrYx50KccV/sghAIgcH/mf5vrfTcOiZZsmMLvFdM?=
 =?us-ascii?Q?6whR5AB4er29KvR3xrOq5igzJ88FnAa9iUbm15oZzdYv8TyoZUkopEjYaaIu?=
 =?us-ascii?Q?o4d6jGfNFwtQGBZ402n2jWEjdABtULkpRbOkjeRo/L17fAW359GP5vdjmvxi?=
 =?us-ascii?Q?kzp9qHrU3ugwUm9gCbWbkjY54xcycBv0RlVHAzBLjVPOM2q/ZVKviRCYv+TF?=
 =?us-ascii?Q?4jPB1zNnCTHTk8IQL54p11p2x7rSu2ZlSnUz3bCRE6bojubqHNWdSsgjDeu1?=
 =?us-ascii?Q?dNDv9oXmtqk8foAQOEGFLmyZvl6juXIoFy+czy+WoodPgd2WwNigDU5ePGa7?=
 =?us-ascii?Q?RI2RAQ7hqtgKHm8OhclWe4WOUf/xa8dZliv9Jp/13iSjx55q20KL1HJaxl+q?=
 =?us-ascii?Q?7ssZ8CF4apa7feX5ctHkgN9wxrRlgXu9R/JdmHeAK4sRo7LqsCnL1qdrJCue?=
 =?us-ascii?Q?+kYgLEyKS6rC9deM6lwxLbLoV96LkkkFXJH9kIYjFNv2vA5rMTSfxNU9e1Nf?=
 =?us-ascii?Q?SMb8+VS4JTddLgLYEmQfxvbXbJkcKnWORzn8Elh/hI+Ss0h+IySGkL2HoB7B?=
 =?us-ascii?Q?OppkvPV1nl9afKpusLv9t0Bqwn6kXHhogrCMG2v5yf8MCq+1yozym66DzqaE?=
 =?us-ascii?Q?fut9Zgmu8LaUJqWmiAC2hzOZrlaG/l6PfDLcQUbpoY9ysYs5p93Cvpbv7Ca3?=
 =?us-ascii?Q?dv1F+Qr0jLtbP2GiPw/H6pY99xv+n96BqnARAJdjamOa8oU/UXJSSiM1HJV3?=
 =?us-ascii?Q?/SfXc5ubGGTGFTr/zXjYjFGOpD2eqOrr5907qfKbkboiJ8m8jcqC9zq0cV8J?=
 =?us-ascii?Q?koGTF8VfVWw9PxxsQQwBpNvvHuiDbfDr3f4Owik/aqT3k8vKszNLLbD9Nd1V?=
 =?us-ascii?Q?XWFe7T+EthJSoX0TYlqC5so9WtEA3J+WdhCmuIwgorblXFBEgJkUzJ48xjp7?=
 =?us-ascii?Q?vD2mLdS3dUFC8qFzMQMGsOUEdCav4jbVN9+BZzwtRF9w7HhUzCvds2kp9Ynd?=
 =?us-ascii?Q?wrY1KNkKvsUB5a3fh2PbiQ/ZpZeEFwVkwLz7820iyvsrrhs9WeCIuAzSSQYK?=
 =?us-ascii?Q?qsNw6xmsHonoV5fGaVOaa1n3QWZCivCUl3G45NQkrgHsUUAqO64+C26JMSn0?=
 =?us-ascii?Q?1XaBsihIAANeGvG2g5JYQPBy+Y39R+R6u+eOxZj1QEBJ82cOloCoH4aevqnA?=
 =?us-ascii?Q?gySu7G1LFHr6N1T/L82qGXGUAXIeqPcDahIYcCO7mu+ZTINW6R+rI11AGkKz?=
 =?us-ascii?Q?UNT7Q0WNAFOxvwdqefBm4quB10hayQjDycpeu8jtfEbfyGb7PGne0Hy9kVFn?=
 =?us-ascii?Q?9/m5XBZBSEdAeO6KWliTCghVmdMqs8FTlKN/ArEgGsamQ/xMGG6QazJElsAo?=
 =?us-ascii?Q?091kGQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 226f54da-043d-4e0b-af4c-08db2bb99014
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2023 16:13:39.1306
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8cgHuCoDuIe/6YdIJNvEI7yq7Y8UX1ubKZgMbbUTeADuCbBpScZRYRwsR7FuXcfVP27wLM38hj4mJdBRRTgYrhbRVYvIrrgFgcNd22s2xoU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR13MB3627
X-Spam-Status: No, score=-0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 23, 2023 at 01:38:22AM +0200, Vladimir Oltean wrote:
> Once commit 6d1ccff62780 ("net: reset mac header in dev_start_xmit()")
> will be reverted, it will no longer be true that skb->data points at
> skb_mac_header(skb) - since the skb->mac_header will not be set - so
> stop saying that, and just say that it points to the MAC header.
> 
> I've reviewed vlan_insert_tag() and it does not *actually* depend on
> skb_mac_header(), so reword that to avoid the confusion.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>