Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8ff68064-3ec6-4aa2-2389-3568483a1bd4@suse.cz>
Date:   Thu, 23 Mar 2023 17:19:15 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH V5 1/2] mm: compaction: move compaction sysctl to its own
 file
Content-Language: en-US
To:     Christoph Hellwig <hch@infradead.org>, ye.xingchen@zte.com.cn
Cc:     mcgrof@kernel.org, keescook@chromium.org, yzaikin@google.com,
        akpm@linux-foundation.org, linmiaohe@huawei.com,
        chi.minghao@zte.com.cn, linux-kernel@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
References: <202303221046286197958@zte.com.cn>
 <ZBq9uO6wLI1fX1x/@infradead.org>
From:   Vlastimil Babka <vbabka@suse.cz>
In-Reply-To: <ZBq9uO6wLI1fX1x/@infradead.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/22/23 09:35, Christoph Hellwig wrote:
> On Wed, Mar 22, 2023 at 10:46:28AM +0800, ye.xingchen@zte.com.cn wrote:
>> From: Minghao Chi <chi.minghao@zte.com.cn>
>> 
>> This moves all compaction sysctls to its own file.
> 
> So there's a whole lot of these 'move sysctrls to their own file'
> patches, but no actual explanation of why that is desirable.  Please

I think Luis started this initiative, maybe he can provide the canonical
reasoning :)

> explain why we'd want to split code that is closely related, and now
> requires marking symbols non-static just to create a new tiny source
> file.

Hmm? I can see the opposite, at least in the compaction patch here. Related
code and variables are moved closer together, made static, declarations
removed from headers. It looks like an improvement to me.