Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp7870931rwl; Thu, 23 Mar 2023 09:36:25 -0700 (PDT) X-Google-Smtp-Source: AK7set+YCpLOFCjfkMUSp2gqfREGi5sqwcOARgKrsPVk4H7TfeoM+QGACOZ540JH//NrqZk3Xg+4 X-Received: by 2002:a17:906:1392:b0:932:a056:e77f with SMTP id f18-20020a170906139200b00932a056e77fmr9649683ejc.60.1679589385543; Thu, 23 Mar 2023 09:36:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679589385; cv=none; d=google.com; s=arc-20160816; b=S92+lcDMFdxO40QuX9pj4xr8r7eJW/SAcbU7oyrQvLElQVVtkuyPz3uBE2Bi0SxPUb x9t+Q6DIsULu8E0JJ53wDQFtf5ypk0WmZWcgYNermkCO3oG8Cj1ZSVnyoH5+KAghi9Tk mBBNnGIC8rdzc9LQGp8cOBAgPcgNBikvPWQiO8K7igRjd++hlMfSst/YI5WxCkmWEQv7 A/fAOrQMg4bgJwG/uyFsca2JK8Bc0W18ob+LrYYiQD0JFBDxea1G1Mpyu1IpYPuMjAJl fyMi/7OO4XTkxas9PQ6/ZbBA1Jv7M5Wa5X4Pu2qcxHtd1eG53/SWhPnew7eXLOEC2ay+ uoVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=mmWlakBuRch62FKY5/YGyx7MYU96fIWp2R/iA9zOpxQ=; b=Nz2Py9ReqtNzGn9Y+bYomhHaiFVVjRRnIIYKTPWMz97smPYzPf0Z8zXFpnxHdobI2F i9mP6VAVxRiGYqvSUKVvhLB/QlC8iXzpSZM/hRX0zj5RlsB8yZz1ql3xuI3a40otpa26 e9OKd1FQRukXiYYge/6W4sBQwLIBHzf0/6KeAfnQ8QcJ1rmkUhhv5UpYz8i3pMptl3AN sLQvZ+0KPjOTZn0yxyEP1FSlApWHD0Xk/daiahABn95pSVO4hGDCwQdh6yMT+MIs42e6 pdC860z9wUvVf8VgXyTca5TWBfkiBzoY1BmdvM2eT6TXrjMa2iCIrwZanc5IXrXm/ewD j0zQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=OR+D0j7z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qk12-20020a1709077f8c00b0093d1c1c1c8fsi1700990ejc.718.2023.03.23.09.35.59; Thu, 23 Mar 2023 09:36:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=OR+D0j7z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231527AbjCWQaX (ORCPT + 99 others); Thu, 23 Mar 2023 12:30:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232314AbjCWQ3x (ORCPT ); Thu, 23 Mar 2023 12:29:53 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DCD2E244B4; Thu, 23 Mar 2023 09:29:48 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6BB3A627EB; Thu, 23 Mar 2023 16:29:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 45880C433D2; Thu, 23 Mar 2023 16:29:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1679588987; bh=Kj1HPQiCSg2GmK1tupptqZKZGWrQm1+Tfd/vO4/pd0Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OR+D0j7zZ5M2RtTuJk7gL3llbchJRxXzdvt3iNVnZFjUTTgoYHLmOcL8rJz18cBmq NWc/0wAITRvHysWZ0puJgGREE0ObHdDm5BpDHiIeR11XsJJwodkzey0feFearKW2gv 7WPsZHx79uPWHaZ9xzLbEumrtCQGbjpviTHfYgak= Date: Thu, 23 Mar 2023 17:29:44 +0100 From: Greg KH To: Szymon Heidrich Cc: woojung.huh@microchip.com, UNGLinuxDriver@microchip.com, kuba@kernel.org, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel test robot Subject: Re: [PATCH v2] net: usb: lan78xx: Limit packet length to skb->len Message-ID: References: <202303180031.EsiDo4qY-lkp@intel.com> <20230317173606.91426-1-szymon.heidrich@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230317173606.91426-1-szymon.heidrich@gmail.com> X-Spam-Status: No, score=-5.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 17, 2023 at 06:36:06PM +0100, Szymon Heidrich wrote: > Packet length retrieved from descriptor may be larger than > the actual socket buffer length. In such case the cloned > skb passed up the network stack will leak kernel memory contents. > > Additionally prevent integer underflow when size is less than > ETH_FCS_LEN. > > Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver") > Signed-off-by: Szymon Heidrich > Reported-by: kernel test robot the test robot did not report the fact that the packet length needed to be limited :(