Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp7882337rwl;
        Thu, 23 Mar 2023 09:45:37 -0700 (PDT)
X-Google-Smtp-Source: AK7set9LLtw1dyIituyMJ/OXqE4ZiLu9R6s3vNK2W5cdM+QiFNzRuxSJMmDAdgucGuV+RR4YFjXQ
X-Received: by 2002:a17:906:15d0:b0:92e:3b80:9841 with SMTP id l16-20020a17090615d000b0092e3b809841mr10942496ejd.42.1679589936891;
        Thu, 23 Mar 2023 09:45:36 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1679589936; cv=none;
        d=google.com; s=arc-20160816;
        b=KM4byc0gFBfkZ+uSprjsNSZVyedIhj9ICjFeUu/G+4Akzv2PXBlkY+FMX/53zIv8mc
         byH0sic+iBlr0D/hRz8dPyYTtj3KBaWGF4lGJ1tgJZXCH6o3PN0mQkvmEfuYJ+gv/QoC
         jf/405Pi7JwOgQUIqj6eWNw8ySVaHwTMu3z7ehJPrMGpsYUjwDNhd6YsDLL1v+KYkFcQ
         mf7AXBVgPTEvjx2uzi0tdCJsu7Ar/o5fBLk/lcMKV1bmSCqK5zQ5NxHPa3qV4DT4i6T2
         L/SoJE2SKKeldxmXXRXJde9/Wd/NZmRY9U5axyijnbVvuzfWSuPzPzcKUxH7yEFKBpes
         JIcw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=C6zbcam0xUhqGIfoAQN43u6ixgPQPCK5MXt51f5tQ+g=;
        b=mUEhrVgKSe14KysrJfKpOpj2GMKPGZ4BKdPJgnp+1+7ohE/AP1SAGdxUxetmJ70Xug
         nrnn0k2K0FK4wVF/Ul5uMFzwEadhTx5otkhDXA8ncdsBDxWHyc4+dgh7BDgShImiRKzE
         qPN+tPCS5LTldDSUw7WLiU3MZhBZFBpGpTf70lpeRaeIGT7NAxEfVWToQ4EgZSTCCj3s
         w6DEme4N/q3HxgbLPsufzKy+A9YZXt9eleifTc3nTwLyVycJqx8sXlZxCFBmkJ5XYnwR
         TvnQ5sQLYv4tc+uGbssWGxoPx0h7xU96kmnfZnu4N7BitvzE7/h2UXkzivAQBn2+zuwl
         Epqw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pRfB86Hv;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
        by mx.google.com with ESMTP id e12-20020a170906504c00b008c35e1f30fcsi18259881ejk.404.2023.03.23.09.44.40;
        Thu, 23 Mar 2023 09:45:36 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pRfB86Hv;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S232027AbjCWQn0 (ORCPT <rfc822;andreas.noever@gmail.com>
        + 99 others); Thu, 23 Mar 2023 12:43:26 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39540 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S231636AbjCWQnC (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 23 Mar 2023 12:43:02 -0400
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF3977EE1;
        Thu, 23 Mar 2023 09:40:40 -0700 (PDT)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by ams.source.kernel.org (Postfix) with ESMTPS id E4580B821C8;
        Thu, 23 Mar 2023 16:40:36 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2A4FFC433EF;
        Thu, 23 Mar 2023 16:40:35 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1679589635;
        bh=C6zbcam0xUhqGIfoAQN43u6ixgPQPCK5MXt51f5tQ+g=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=pRfB86HvPG+N1+COI+X5YsHdDxWA2NjhUDXInRcRJDCMba2LlCyhLjVaF0jVk/zkD
         yjbWGIIxAM/Lv1tdKJFynZe8SHo5Q4x9uaQPvgAoSaag4h+CDmOmlf2cs9NYIovc9v
         j+12A01A1Aeg/bIx2UfQF7K6Rygyl2FVqWaI/xLnut4vsO1ZPEi6940r0Ndb9H1Ulp
         g0uHfKKw06LEgY66EB3oERVvEPjRKk6MVV7XWPTOvJoEpePJfzAHOOvMPC/dkpSuln
         6D7vLgrquuoqrbwMBXzD7KO+hMl2XTRJILL1DimurM04P+5LWyzTO5NYHoz/S278hs
         AMUzVxrBl6lsg==
Date:   Thu, 23 Mar 2023 09:40:34 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     Sergey Shtylyov <s.shtylyov@omp.ru>,
        Wolfram Sang <wsa+renesas@sang-engineering.com>,
        netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] sh_eth: remove open coded netif_running()
Message-ID: <20230323094034.5b021c65@kernel.org>
In-Reply-To: <CAMuHMdUt_kTH3tnrdF=oKBLyjrstei8PLsyr+dFXVoPEyxTLAA@mail.gmail.com>
References: <20230321065826.2044-1-wsa+renesas@sang-engineering.com>
        <79d945a4-e105-4bc4-3e73-64971731660e@omp.ru>
        <CAMuHMdUt_kTH3tnrdF=oKBLyjrstei8PLsyr+dFXVoPEyxTLAA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-5.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,
        SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 23 Mar 2023 09:32:27 +0100 Geert Uytterhoeven wrote:
> Is there some protection against parallel execution of ndo_open()
> and get_stats()?

Nope - one is under rtnl_lock, the other under just RCU, IIRC.
So this patch just makes the race worse, but it was already
racy before.