Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 23 Mar 2023 09:57:36 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Min Li <lnimi@hotmail.com>
Cc:     richardcochran@gmail.com, lee@kernel.org,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        Min Li <min.li.xe@renesas.com>
Subject: Re: [PATCH mfd-n 2/2] mfd: rsmu: support 32-bit address space
Message-ID: <20230323095736.38ea1ca8@kernel.org>
In-Reply-To: <MW5PR03MB69320CC31AB6206419DFF2C9A0879@MW5PR03MB6932.namprd03.prod.outlook.com>
References: <20230323161518.14907-1-lnimi@hotmail.com>
        <MW5PR03MB69320CC31AB6206419DFF2C9A0879@MW5PR03MB6932.namprd03.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 23 Mar 2023 12:15:18 -0400 Min Li wrote:
> -	u8 cmd[256] = {0};
> -	u8 rsp[256] = {0};
> +	u8 cmd[RSMU_MAX_READ_COUNT + 1] = {0};
> +	u8 rsp[RSMU_MAX_READ_COUNT + 1] = {0};
>  	int ret;
>  
> +	if (bytes > RSMU_MAX_READ_COUNT)
> +		return -EINVAL;

Why is defining the constant to MAX_READ and checking the requested
size part of this patch, the commit message only talks about addresses
operation size is not mentioned in any way...