Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Veerasenareddy Burru <vburru@marvell.com>
To:     Leon Romanovsky <leon@kernel.org>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Abhijit Ayarekar <aayarekar@marvell.com>,
        Sathesh B Edara <sedara@marvell.com>,
        Satananda Burla <sburla@marvell.com>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>
Subject: RE: [EXT] Re: [PATCH net-next v4 6/8] octeon_ep: support asynchronous
 notifications
Thread-Topic: [EXT] Re: [PATCH net-next v4 6/8] octeon_ep: support
 asynchronous notifications
Thread-Index: AQHZXJ+MKKx7Fkul+EmXkxNMFkCqc68ILhwAgABwmhA=
Date:   Thu, 23 Mar 2023 17:24:55 +0000
Message-ID: <MN2PR18MB2430BA163B1FC69EEB39EE75CC879@MN2PR18MB2430.namprd18.prod.outlook.com>
References: <20230322091958.13103-1-vburru@marvell.com>
 <20230322091958.13103-7-vburru@marvell.com> <20230323103900.GC36557@unreal>
In-Reply-To: <20230323103900.GC36557@unreal>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/P4h0kpgzEiOH67D1Wzr72OY7otxC4wncSHbTLbMn9jOVWTmsa0f2A2euuKC?=
 =?us-ascii?Q?9w1+j9ujXmKkZhr/Ng15bvPtlpToU6gMLzBcuCbbUWsD9a3pE+SGlj/duSzY?=
 =?us-ascii?Q?hDTj0lU5HFtX6SgopfQ9VE3nah+RejUOt1L5C76kar7uk0IG8p8QjV971TJV?=
 =?us-ascii?Q?glWSPwXyfy+X/M32ak9r6gEEd+t86jD1uuepzYBVBDHTb8oxNyYQJydKd2ns?=
 =?us-ascii?Q?ZQgnkcmA//YNHlTJgzzF4GcDjunGBm8PgqSLMzLeE+G1MZgoCyCWuIYW07D8?=
 =?us-ascii?Q?8ypl+9zQF/kcgnxENWxCISd+t92YPCMuNi6vXoHkIUqbZSETSPKAoKmpcCV1?=
 =?us-ascii?Q?ic3sTzskirZOhDA7cdzhWivvxmFDbBnujsvHuFjUZUWFd0AfFrh/otptHhu8?=
 =?us-ascii?Q?B+Xid2wagMDJ6835e6e1vEPfAc8pnChADsjvqoBN1S6nrGQczDWZfoxxn7M8?=
 =?us-ascii?Q?S0Cf74gi8dAzTteEF+6jhIKphBQBNJxHTcErlZsOKlRrKisVa4Fk4ZL3k0bq?=
 =?us-ascii?Q?yKOw7qlkYwfaF7L8SXktDYH6h69cFI31dp8p6bCPL3R1PpW4ley6tQojVrEs?=
 =?us-ascii?Q?01C7Nug9PrYqkw0GmDdZOzOUo3P5QME3Jo7Ubu8S+qAojTM4ix1Hb70U+8sg?=
 =?us-ascii?Q?kmXgsPHkCZOrdkJudGxbj9aJRQfVI50dkGUQRZx4qqmT68a1aN+vo5dnl28q?=
 =?us-ascii?Q?ACT6DqnOBbJlQlYT4lw0g/GTF20qb/2VR5SVLhXEnEtMPSt8HlxFB/f6rcQO?=
 =?us-ascii?Q?sqUpwuxyGHubBCggMQlFsY6y9J9W3Wwu9G0DHX16baSEfSMLo9nSgB3HII0D?=
 =?us-ascii?Q?Ixs6WeBBa/cpgFDubPOQhk+hLWxYybCvoC0YuvSDA7I9sTFLXadNqNSic/Uj?=
 =?us-ascii?Q?BgCY7Vhyd6mxAU8SdbuNJ4AIaKfSlmQkDtxrnvJzSdCpN1T8r5wFoWqtlrPH?=
 =?us-ascii?Q?8Wr7A78fptaEj0NilhU9WwoIxHoH2B5M/d75u/14vMGRCgxHUSdNmXhkI2KM?=
 =?us-ascii?Q?AMe0HmUKMddx6M1SQvOl3JrFP8dG8UyjHrlu7wAupuardto/ixAc1qt5jypu?=
 =?us-ascii?Q?h1kUvnvLQ6qs5bkIy/Tn2eHsP7HOjSF1r5LJaxs4srfgkjdwsdbENNSk+ml6?=
 =?us-ascii?Q?NGSP7oz/ot3H7nzJepu9zJNW2Eur0D4bq4uNUZfaGWNL+lveiUHvWliBGZvY?=
 =?us-ascii?Q?hkBI3uKOwJlpJHtHbiY8yuVkTbOyNbuVgyR2MJzUNUCfgnzqAGyibw2vBrZ0?=
 =?us-ascii?Q?CWutleB0YSOVEB/QUJOIoFtl3K58PqpKQB5uaKNDX3KY6eXbiTsso122UTDF?=
 =?us-ascii?Q?hy+fpagURRztSVsaHKLlJ/SMNQ8sGpK78+kb2HKt26UMZKq3PHxKnCq+bqGS?=
 =?us-ascii?Q?TR6TtccJ1zT8sM59U04dH5qwO4VVe5Jmnoyo4/tHBzhBhzWFuUJM87xwkrN9?=
 =?us-ascii?Q?pAxNTiuTj2gt20VlWwLrTUJA+5l+YWeAjN6fvpL077hX/y7v5nrLfDSRwKAb?=
 =?us-ascii?Q?KJkUgJ2TwpZw6smddC36pwfOxc+3Vo2aGWyFuMd4N4dD223JtWAY8kXOf++w?=
 =?us-ascii?Q?mMg0e3mujbzn2UDtf5innG9YJfnHx5MUtcsdRppl?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN2PR18MB2430.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 23b4b455-acc1-4296-6f44-08db2bc38579
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Mar 2023 17:24:56.0689
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /B8S0yfkqtLVX3RfBsc3ORS2Msj7vox4xc/HevAY/4x1WzL2XszP3io6nSp9lVYUm5LyFJnz3tnHY8FrwlWHEA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR18MB3871
X-Proofpoint-GUID: hH_ubE3rtTN6mXiXHjChtbdQCTKWk8Lh
X-Proofpoint-ORIG-GUID: hH_ubE3rtTN6mXiXHjChtbdQCTKWk8Lh
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-03-22_21,2023-03-23_02,2023-02-09_01
X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE autolearn=unavailable
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Leon Romanovsky <leon@kernel.org>
> Sent: Thursday, March 23, 2023 3:39 AM
> To: Veerasenareddy Burru <vburru@marvell.com>
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Abhijit Ayareka=
r
> <aayarekar@marvell.com>; Sathesh B Edara <sedara@marvell.com>;
> Satananda Burla <sburla@marvell.com>; linux-doc@vger.kernel.org; David S.
> Miller <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>;
> Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>
> Subject: [EXT] Re: [PATCH net-next v4 6/8] octeon_ep: support
> asynchronous notifications
>=20
> External Email
>=20
> ----------------------------------------------------------------------
> On Wed, Mar 22, 2023 at 02:19:55AM -0700, Veerasenareddy Burru wrote:
> > Add asynchronous notification support to the control mailbox.
> >
> > Signed-off-by: Veerasenareddy Burru <vburru@marvell.com>
> > Signed-off-by: Abhijit Ayarekar <aayarekar@marvell.com>
> > ---
> > v3 -> v4:
> >  * 0005-xxx.patch in v3 is 0006-xxx.patch in v4.
> >  * addressed review comments
> >    https://urldefense.proofpoint.com/v2/url?u=3Dhttps-
> 3A__lore.kernel.org_all_Y-2B0J94sowllCe5Gs-
> 40boxer_&d=3DDwIBAg&c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DXkP_75lnbPIeeucsP
> X36ZgjiMqEKttwZfwNyWMCLjT0&m=3D5CnsD-
> SX6ZoW98szwM0k4IXgNC3wY0EwCQHxDKGyNIRUJxdaNe3zorLcOhc9iU6d&s
> =3Dk73McQSsjbjj87VbCCB8EFFtGWtksMIGhn15RK12XF8&e=3D
> >    - fixed rct violation.
> >    - process_mbox_notify() now returns void.
> >
> > v2 -> v3:
> >  * no change
> >
> > v1 -> v2:
> >  * no change
> >
> >  .../marvell/octeon_ep/octep_ctrl_net.c        | 29 +++++++++++++++++++
> >  1 file changed, 29 insertions(+)
> >
> > diff --git a/drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_net.c
> > b/drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_net.c
> > index cef4bc3b1ec0..465eef2824e3 100644
> > --- a/drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_net.c
> > +++ b/drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_net.c
> > @@ -271,6 +271,33 @@ static void process_mbox_resp(struct
> octep_device *oct,
> >  	}
> >  }
> >
> > +static int process_mbox_notify(struct octep_device *oct,
> > +			       struct octep_ctrl_mbox_msg *msg) {
> > +	struct net_device *netdev =3D oct->netdev;
> > +	struct octep_ctrl_net_f2h_req *req;
> > +
> > +	req =3D (struct octep_ctrl_net_f2h_req *)msg->sg_list[0].msg;
> > +	switch (req->hdr.s.cmd) {
> > +	case OCTEP_CTRL_NET_F2H_CMD_LINK_STATUS:
> > +		if (netif_running(netdev)) {
> > +			if (req->link.state) {
> > +				dev_info(&oct->pdev->dev,
> "netif_carrier_on\n");
> > +				netif_carrier_on(netdev);
> > +			} else {
> > +				dev_info(&oct->pdev->dev,
> "netif_carrier_off\n");
> > +				netif_carrier_off(netdev);
> > +			}
>=20
> Shouldn't netdev changes be protected by some lock?
> Is is safe to get event from FW and process it as is?
>=20
> Thanks

Thanks for the kind feedback.
I do not see netif_carrier_on/off require any protection. I referred few ot=
her drivers and do not see such protection used for carrier on/off.
Please suggest if I am missing something here.