Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a9985035-237a-467c-6516-f996d56cb7e5@redhat.com>
Date:   Thu, 23 Mar 2023 18:27:28 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH] mm: Be less noisy during memory hotplug
Content-Language: en-US
To:     Tomas Krcka <krckatom@amazon.de>, linux-mm@kvack.org
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Pavel Tatashin <pavel.tatashin@microsoft.com>,
        Alexander Duyck <alexander.h.duyck@linux.intel.com>,
        linux-kernel@vger.kernel.org
References: <20230323171904.14444-1-krckatom@amazon.de>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat
In-Reply-To: <20230323171904.14444-1-krckatom@amazon.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 23.03.23 18:19, Tomas Krcka wrote:
> Turn a pr_info() into a pr_debug() to prevent dmesg spamming on systems
> where memory hotplug is a frequent operation.
> 
> Fixes: 966cf44f637e ("mm: defer ZONE_DEVICE page initialization to the point where we init pgmap")
> 

Fixes? I suggest top drop that tag here.

> Suggested-by: Jan H. Schönherr <jschoenh@amazon.de>
> Signed-off-by: Tomas Krcka <krckatom@amazon.de>
> ---
>   mm/page_alloc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index ac1fc986af44..14d70f4e6c0a 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -6959,7 +6959,7 @@ void __ref memmap_init_zone_device(struct zone *zone,
>   				     compound_nr_pages(altmap, pfns_per_compound));
>   	}
>   
> -	pr_info("%s initialised %lu pages in %ums\n", __func__,
> +	pr_debug("%s initialised %lu pages in %ums\n", __func__,
>   		nr_pages, jiffies_to_msecs(jiffies - start));
>   }
>   

Acked-by: David Hildenbrand <david@redhat.com>

-- 
Thanks,

David / dhildenb