Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp7958167rwl; Thu, 23 Mar 2023 10:42:10 -0700 (PDT) X-Google-Smtp-Source: AK7set9vK3f2mn4ZGVIaoXKJHa3AT5yNATteeQ3bmREfc07mQFIzOAy9aln0m11EBjkYYlSgP2ZA X-Received: by 2002:a05:6a20:c11e:b0:d9:4d77:643e with SMTP id bh30-20020a056a20c11e00b000d94d77643emr526361pzb.4.1679593329994; Thu, 23 Mar 2023 10:42:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679593329; cv=none; d=google.com; s=arc-20160816; b=mn2jVfF6/yrsMsOsmrFbdPHFQhKzFpDfpNGiIIBmo0YmJ4T9k83D+ztzi3CBJ8ll0T MDSY8CnNfUrMOj/TYbv7V0tpwnvRXuT3HxRhcDTftNHA6mM++N3J9DZvh7m16JLrL1vI PabztY170xCKObKzD1bBFrGM3m3zietOubhUODZoikKDuMSzJGCS96baEDWSfndTnawK GjjJw+XGZloCe25gOqYAI2WxwhuLIApkhhamPKthGj4gnVnO+HsZqRJbDKP3NSqBYnFP HXL1fCUKx9cqVFeU+qW1r8GUMN5Xe88jvgc67HYKPCnZX+qrF+BD/807ZKdWJxqKRnt1 DttA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=kSh+/2YWzVBauPfUlVnhO7fzXKFSdxWRdAkQZySqbF4=; b=Dn9UKNPaR6N5XE5m2id8GILxDAU+h+co10LXhNnD2hguB68PYYkbyhab2nYfF/Rq7p cxjCc99fX1U7MmAViWhn5CQTx61akbfxcOgn/eQSqBjxNNpt5+SB6tnrZSofYyuq9Igq WybLAZvoJ/SdyO+b0I27eaetWBJOOxlwGrDM/j///5TgOCYfwVj7flr+O+/LPN9+2c67 8Agd3lhi52Ge17MfAQnJze4yLFfXJDM28ezZ9FS5/rkd3YHu4AkfhQa5eBVeGpB48fkv JyixvB0/sLx5p+iS4PeC26L2sGtUpiO65Yk3eBENun320zWW2bF1ABsRjw/N+VBk3smP JoOA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="M/nKxx1b"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 123-20020a630381000000b00500a71d8b47si19333183pgd.214.2023.03.23.10.41.47; Thu, 23 Mar 2023 10:42:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="M/nKxx1b"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229885AbjCWRiJ (ORCPT + 99 others); Thu, 23 Mar 2023 13:38:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231216AbjCWRhw (ORCPT ); Thu, 23 Mar 2023 13:37:52 -0400 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD22738B63 for ; Thu, 23 Mar 2023 10:36:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679593008; x=1711129008; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=+oRZBGlRDE2mN2HqkB0otRZAMosS9UyIjnPhkCjAn4k=; b=M/nKxx1bD6EOLfH/WqiAW7+01tb+RJSOglwJi+ynOWE0yrbuIb8AgsCM Yls1TIHrCWZBtyCI5j4kQH5TS1FhTJIq8w78P1euXzdUw+vL3BRuivwsk mZGArlBZa/JYeEqsbQmWb8WMVKfi/sCoYWvKBTRU91U2BrVFGm5cHJ4CQ ooaC4jemCG1E9zcu6pq4vFOnx8N+JqQ2zht2jwAsCNnpYyfDdxZpSH48r RldH84U7SOVf+mlx2GJQsn6I5rZYSOMRzAf8HRnAlPcnjfuMIDUJKSwQe UwZo8YEotU7jRsPV3Jq5hPUT/XvQn+m23efAeKPhD9SqLQflAE/1vfqb0 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10658"; a="319228538" X-IronPort-AV: E=Sophos;i="5.98,285,1673942400"; d="scan'208";a="319228538" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2023 10:36:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10658"; a="806351892" X-IronPort-AV: E=Sophos;i="5.98,285,1673942400"; d="scan'208";a="806351892" Received: from aschofie-mobl2.amr.corp.intel.com (HELO aschofie-mobl2) ([10.252.131.62]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2023 10:36:47 -0700 Date: Thu, 23 Mar 2023 10:36:46 -0700 From: Alison Schofield To: Sumitra Sharma Cc: outreachy@lists.linux.dev, johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] Staging: greybus: Convert macro definitions to Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS, SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 23, 2023 at 02:01:04AM -0700, Sumitra Sharma wrote: > Convert macros to a static inline function, to make the relevant > types apparent in the definition and to benefit from the type > checking performed by the compiler at call sites. > > Sumitra Sharma (3): > Staging: greybus: Convert macro gpio_chip_to_gb_gpio_controller to an > inline function > Staging: greybus: Convert macro struct gb_audio_manager_module to an > inline function > Staging: greybus: Convert macro struct pwm_chip_to_gb_pwm_chip to an > inline function Hi Sumitra, Please review: https://kernelnewbies.org/Outreachyfirstpatch#:~:text=Following%20the%20Driver%20commit%20style That is the section on 'Following the driver commit style'. Cover letter Subject seems to be needlessly truncated. Alison > > drivers/staging/greybus/audio_manager_module.c | 7 +++++-- > drivers/staging/greybus/gpio.c | 7 +++++-- > drivers/staging/greybus/pwm.c | 6 ++++-- > 3 files changed, 14 insertions(+), 6 deletions(-) > > -- > 2.25.1 > >