Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ce57dcbb-5464-3340-34d0-af1e3f191b85@intel.com>
Date:   Thu, 23 Mar 2023 10:58:14 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.9.0
Subject: Re: [PATCH v4 1/3] x86/resctrl: Factor rdtgroup lock for multi-file
 ops
Content-Language: en-US
To:     Peter Newman <peternewman@google.com>, <fenghua.yu@intel.com>
CC:     <Babu.Moger@amd.com>, <bp@alien8.de>,
        <dave.hansen@linux.intel.com>, <eranian@google.com>,
        <gupasani@google.com>, <hpa@zytor.com>, <james.morse@arm.com>,
        <linux-kernel@vger.kernel.org>, <mingo@redhat.com>,
        <skodak@google.com>, <tglx@linutronix.de>, <tony.luck@intel.com>,
        <x86@kernel.org>
References: <20230308131452.383914-1-peternewman@google.com>
 <20230308131452.383914-2-peternewman@google.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230308131452.383914-2-peternewman@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NHZLSDhKOTh4Um82UXFZT3M3eDJTdnlrU25zcHFWckM2dTVydHlPU3Y0eEw5?=
 =?utf-8?B?OVU1SE5tWXV3R3NOUlJjdko1eXNzVytIdzc0Vi9jdHJkM3BRVk1EU0t3TkFV?=
 =?utf-8?B?ZThOY0cxaWc5N3VYbWFQQXJLakF1ZCtoMkJxMlFGZi9zdGR1aXRIRzNnSzkx?=
 =?utf-8?B?YlBWRG5mNUJydWcvUXMrS0pNRkN3a3VuajhHempuanovMTdnK01KT2RXUSs4?=
 =?utf-8?B?MkVWVDlnTWd1dDROYzN1N3l4RUh6NFN2TEs2MndGeWMzeXp4SkNieFBuVy81?=
 =?utf-8?B?Mks5anYzaE05aFhQcjQzeHRtc2ZoRzBiTHNBVk5LUGxLYVY1ekF2MUtKUFRQ?=
 =?utf-8?B?ZXNnQkM0OUswVjJ1U2liQ04vR1VLMDBvODU5bEJxL05ta2JNT3VWZ1hYbWVn?=
 =?utf-8?B?ZEJlZld6Tm1mc3QvYXpQWlZ4YWlFYXJBMCtOZEQ4RWpYWXpXakp4c2RlUTds?=
 =?utf-8?B?VXRCKzBPZ2hUODFYOWdFZUlYb0ZiZTZjL2NkV1FrSGFtbVFLVW9qMm9memoy?=
 =?utf-8?B?Q0ZEcW1Rc1UyQkxJZXUzbW9hSU90Z2ZpTDFCVURhSFUrUzBycEF1YUY0Z2I4?=
 =?utf-8?B?UEFvOE9nR2JGZU1JU2N5b3NkQnMrTXBSU0xPTi9aaDdDWWxLY0xtTmRCQVkv?=
 =?utf-8?B?SElhbVhpVjFpMEFtNUVtU3RJTVR1UkU4Mlk5bEhBcmF6VXBNUmJZZVRiQkta?=
 =?utf-8?B?TGdHMU9SMlQybzVZdmlBWE45NDM0VklkY1BqQTUxc05DdzBPSlAwUEJ4dDJK?=
 =?utf-8?B?QkJrVzlsb3AvYVFIREhJaUUwNE1jcjZGRmpIOE9Rd3dhVHd6WjJOZ09VN2l3?=
 =?utf-8?B?SDVHUGM2NER1dUhVN2hJZjBoMGRGb0dtNXB6MkZ1VG9EdG92RXBJN29CT3p5?=
 =?utf-8?B?YXl4U0J2VUhINU03b1h6SnpqN3BJUWJXbTJwN3krWUt2UldIVjc2eDZSYUxv?=
 =?utf-8?B?dXl3QlN4MWgxWjFrVHJJVGRpQXZmZ1ZtRC9lQTRsQ2xPZXBaMitkYmptZVFm?=
 =?utf-8?B?TGwxZVZXM0tYK3RETDM3UkYvQWUzWnJWRkpTYWZPZVBMR0hwVTFFV3kraEEw?=
 =?utf-8?B?aWlxejBHOFE1eG45eTNhaitpRGY1b2JBdDREenRsM1pidFRqVlhOcEVZcTFQ?=
 =?utf-8?B?M3NndFRiUEZhNEdiRm9zWURiTUxvOGVOL29xNjIrMUE0NkNvMlR2QmRMTmJQ?=
 =?utf-8?B?eTQvdTJySkN1THFzazdLWmQxcTdoSHJZa3pObWZGVmRLWTBubmgrbFdTWGN0?=
 =?utf-8?B?eU85L1RHK3FaazZRbUNqekoxL3d3bXBDdHA1RHhPSi9nelRRZFNFOUpkUDhC?=
 =?utf-8?B?dlFLbUNoeGQyVnNFNmlObDh2aGlpcHZoQWVwdEJTcXNUT2FyOVVTbHVBOTJx?=
 =?utf-8?B?TGFWMG5HRmRNaEgrQkt6NWozeHhHdmtjNWFiekN3VS94S0Q2OTlHQXVLKzg0?=
 =?utf-8?B?eXJxM0E1UG12UGU5Q3VYdVgyMFFzb1c1TFdkU3VZSDg0NmcyQktYMU5ZdTBz?=
 =?utf-8?B?WE1rU2R4czZueU53MVA1OHlQQ2tYbFU1b0RvZXo2b3VzU1ZDejJnd2tKbGEw?=
 =?utf-8?B?eFNRajRkWXp2UXFSSFdBSUsvRVY0NnRkSU1PbG5HR21iaG5uYVVHVkd4NGI4?=
 =?utf-8?B?Qm9TRzZVMzZ6L1B5eHVMOXgxbHNUK2ppSlVBNjhuc1JIZ1VxSS9Xbi9JZEU2?=
 =?utf-8?B?N0phYld1djRpT3RkS0RWMHR4cEZFSHBiVklhUStmOVlTK3Z3bThXcklEY2hv?=
 =?utf-8?B?Q2ZqT1BNZHhKd1F2OXJjbUQwMGNrTXpxdDBiNmZZQWtIb1YvUnFBVGp6aHdQ?=
 =?utf-8?B?MEU3VTZWUDZIUnU1enpMZGpSQSttVDZEcGRkZzc2UElueGlFTkx6SENtM0p3?=
 =?utf-8?B?cXJTZzdLcmVhYmZLTGdBakU1c3JQWk1wSXdHZmo2SU5FcUM3UzloRHVjWkJK?=
 =?utf-8?B?RnkwczBXeDJHdDBtc2Jmci9acjBRRjFyL3VpRHhCN3ZlVG9uKzYzUEJ5Mk1z?=
 =?utf-8?B?YXRDTzVLR0hWRUVvOVN5ZXFLNWpTVnBwZ3hMb0puc1VSNEpXQTNyVGxyR2Rs?=
 =?utf-8?B?SHRQZlQyV25hWmJvemV6bTh5b05EQjIxcldjdkJQMkhMRjdyNEk1NGwzSEJp?=
 =?utf-8?B?MmYwTzZWN1U0SVg3aGRQUS9udzFLUk5ibWgyMFRmeEwxKy9XMmNmYnM3a0ZF?=
 =?utf-8?B?bmc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cb8e9245-3d58-406c-3882-08db2bc82edd
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2023 17:58:18.5104
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NP0hcdBI5lW0fpweHhIvLfBYuCdFgChhhBNDNT5z1ZseEE+FCIE0bmkmXX5SkSPNGtkxn3jRn3llaKltL5eBNSlBbt9nW+WFo9NekWHf9/A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6965
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Peter,

On 3/8/2023 5:14 AM, Peter Newman wrote:
> rdtgroup_kn_lock_live() can only release a kernfs reference for a single
> file before waiting on the rdtgroup_mutex, limiting its usefulness for
> operations on multiple files, such as rename.
> 
> Factor the work needed to respectively break and unbreak active
> protection on an individual file into rdtgroup_kn_{get,put}().
> 
> No functional change.
> 
> Signed-off-by: Peter Newman <peternewman@google.com>

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette