Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp8007830rwl; Thu, 23 Mar 2023 11:20:03 -0700 (PDT) X-Google-Smtp-Source: AK7set8wZHPnHYihudatTJ4acDF71/tniYiWsFR1FSfX2VJF1+ObPtv0xIUtbTbKK7HDEiIZEBrJ X-Received: by 2002:a17:90a:1d1:b0:23b:2963:ec94 with SMTP id 17-20020a17090a01d100b0023b2963ec94mr9149296pjd.29.1679595602802; Thu, 23 Mar 2023 11:20:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679595602; cv=none; d=google.com; s=arc-20160816; b=quSuj8m67kKp4XTSsS1QagAMDASkq/CqdzqwfS0dS68CgOzmWqRfM/ibiLysFH+nhd 10H168CHsh5o2iSjNiWFfK2LFuRGg3J/oh8AXBNHYP/BoPm5sATPTIgzeukioupDnO8b IMRG7MolxxaGHIKnj8/WDU8dA+NJQqS52XdKXquFVp0uk9x61kHXvtQfrT3TFW/WBXX+ ENBcWplXVwlXBG2A6mxt860l+MnHXK11E64fT24655z3sEGt9r6tNwtfRir02MKAyNLP MUVeIs222E4sAm2MrTXESR7WJAZBdTllSwAvc/gKLhNKMdQmR6rxr+B8RhpLNwDBxFyC 9MmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=lr4zpNX332cV4rotNuftOEMCNojpvKIZNiJ2CNNLsAM=; b=CNIJyTMoDL6wAXFHz1i++3Cmc3DDlLTMYFYXCacNFZal9uN4ICuU+DiNTArktIxmi+ IDgHCK8ZnyVzzZwX23P+tcx/ynON3bc248octIuFq6HOhntCBtqfk0a4lByIJmtAuVFb g8Sf9wD+HrPoJSutaXk0Z7obulCPtiHXle0WJYekL8H17llEWSE8EEvntL7FFkMJ8wJd Syn5CEyPWNSf3w/FWK1dRshanT2FlK0O901qzX+k2iON6+/J6XaFsxA9xxq+dpNxExG+ Ohrxa/87SjXrDcQP1A8m+OKhZDl9+ZKFuFMBu3zFMUmhlnke69hfFAGDFqq+M2QrByK4 exIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=OKs6VHVl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v1-20020a17090a0c8100b0023d387cbcb4si2185100pja.14.2023.03.23.11.19.49; Thu, 23 Mar 2023 11:20:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=OKs6VHVl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231285AbjCWSFe (ORCPT + 99 others); Thu, 23 Mar 2023 14:05:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231263AbjCWSFd (ORCPT ); Thu, 23 Mar 2023 14:05:33 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A463DA270; Thu, 23 Mar 2023 11:05:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2888E6284F; Thu, 23 Mar 2023 18:05:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F3B43C433D2; Thu, 23 Mar 2023 18:05:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1679594730; bh=0865JfiFypru3FJc8vbsQvn4GQFZBP1qlUEDcWCh/Yo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OKs6VHVlxFd3kssyCa5WNZh9bqaD/EUq+z3FJehHT9Sk6YUwbBMf7LWnHIpcaAZ6B XA92fwloEDTSnzwb0ry4iBWzHLPTitwI6Hoy/2hS+t9UPG8VHYM2HIURbcu/taKksj KORCAzG7IAsoFSb4UOJyTAwGqQUjQA5WTda5zDaA= Date: Thu, 23 Mar 2023 19:05:22 +0100 From: Greg Kroah-Hartman To: Ye Xiang Cc: Arnd Bergmann , Matthias Kaehlcke , Lee Jones , Wolfram Sang , Tyrone Ting , Mark Brown , Linus Walleij , Bartosz Golaszewski , linux-usb@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-gpio@vger.kernel.org, srinivas.pandruvada@intel.com, heikki.krogerus@linux.intel.com, andriy.shevchenko@linux.intel.com, sakari.ailus@linux.intel.com, zhifeng.wang@intel.com, wentong.wu@intel.com, lixu.zhang@intel.com Subject: Re: [PATCH v6 1/6] usb: Add support for Intel LJCA device Message-ID: References: <20230323172113.1231050-1-xiang.ye@intel.com> <20230323172113.1231050-2-xiang.ye@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230323172113.1231050-2-xiang.ye@intel.com> X-Spam-Status: No, score=-5.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 24, 2023 at 01:21:08AM +0800, Ye Xiang wrote: > +config USB_LJCA > + tristate "Intel La Jolla Cove Adapter support" > + select AUXILIARY_BUS > + depends on USB > + help > + This adds support for Intel La Jolla Cove USB-I2C/SPI/GPIO > + Master Adapter (LJCA). Additional drivers such as I2C_LJCA, > + GPIO_LJCA and SPI_LJCA must be enabled in order to use the > + functionality of the device. > + > + This driver can also be built as a module. If so, the module > + will be called ljca. That's a very generic name for a USB driver, why not "usb_ljca"? > +struct ljca_dev { > + struct usb_device *udev; You didn't remove this like you said you would :(