Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <19ec60aa-fa11-c44e-a6d1-9583f2e7707a@amd.com>
Date:   Thu, 23 Mar 2023 13:28:38 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH v16 8/8] x86/smpboot: Allow parallel bringup for SEV-ES
To:     "Woodhouse, David" <dwmw@amazon.co.uk>,
        "usama.arif@bytedance.com" <usama.arif@bytedance.com>,
        "bp@alien8.de" <bp@alien8.de>
Cc:     "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "brgerst@gmail.com" <brgerst@gmail.com>,
        "arjan@linux.intel.com" <arjan@linux.intel.com>,
        "hewenliang4@huawei.com" <hewenliang4@huawei.com>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "simon.evans@bytedance.com" <simon.evans@bytedance.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "oleksandr@natalenko.name" <oleksandr@natalenko.name>,
        "kim.phillips@amd.com" <kim.phillips@amd.com>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "fam.zheng@bytedance.com" <fam.zheng@bytedance.com>,
        "mimoja@mimoja.de" <mimoja@mimoja.de>,
        "seanjc@google.com" <seanjc@google.com>,
        "liangma@liangbit.com" <liangma@liangbit.com>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "hpa@zytor.com" <hpa@zytor.com>,
        "punit.agrawal@bytedance.com" <punit.agrawal@bytedance.com>,
        "pmenzel@molgen.mpg.de" <pmenzel@molgen.mpg.de>,
        "piotrgorski@cachyos.org" <piotrgorski@cachyos.org>,
        "gpiccoli@igalia.com" <gpiccoli@igalia.com>,
        "paulmck@kernel.org" <paulmck@kernel.org>,
        "Rapan, Sabin" <sabrapan@amazon.com>,
        "rcu@vger.kernel.org" <rcu@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>
References: <20230321194008.785922-1-usama.arif@bytedance.com>
 <20230321194008.785922-9-usama.arif@bytedance.com>
 <20230322224735.GAZBuFh9ld6FuYEyoH@fat_crate.local>
 <2c3dd773-31ca-d4b1-78a2-b39f3785c7c5@amd.com>
 <751f572f940220775054dc09324b20b929d7d66d.camel@amazon.co.uk>
Content-Language: en-US
From:   Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <751f572f940220775054dc09324b20b929d7d66d.camel@amazon.co.uk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c2N1N29mcU11TkJXd3ZqbnZkQVg2RmVPcURIWTZ0S2M1TEM2aW5POTFIS0pY?=
 =?utf-8?B?Nmk5ekg0Und6QUp2azFmRDQxb0pOYnR1dDJjbHVXeFJHUFQ4N21KMDAya1Vw?=
 =?utf-8?B?OTZVbllSWGJVeG1HOWhvRjNyUjM4UlJWamtlSWdkVmJ3enR1aFRyNmRjNkw4?=
 =?utf-8?B?c0h4cm9Id3p0SWQxclNOUFRDQXY3VnIveTJZeDhaaDhGa2kydEdZSjQ5K2E1?=
 =?utf-8?B?VkUzUmloL3p2dmRGN3VsVndXSmVxU2hrN2JNYjM5cSt1bWVJUy81ODQvRnN2?=
 =?utf-8?B?QUFmVzJuUEVzUm1GN1BjZlFzbDVEbmo2VlpWeFlSZDFUc1o0cFF6bUFsOHEw?=
 =?utf-8?B?amRXaW55T3NJWG5KZFRUZjh1UGx6cUM3VzQzeXRBb0YrUUx5dmhKL1dKNnA5?=
 =?utf-8?B?bUYyc0NxVi9scmwzRU1QSXE0OWJIQVp3MEVsSUFacVpMQi9GbGM0aENzZ2pV?=
 =?utf-8?B?YWR1UEVxdy92OXV4a3E4aVlURDYzNDdrTmFraEJ5U1g0aWExTzI3VnlqT1FF?=
 =?utf-8?B?eGF6aFRkajBzZnA3eWNQempYN2JVZkVqTXBFUkhNa214R0FNZ1R1QzdnMkZL?=
 =?utf-8?B?dnpDRlE5UlNYV0tKMEloeVVLNGVJd0RqeU5BR1ZsaXl4V0dVMGl1dXZwS2hI?=
 =?utf-8?B?VHErL2RxMFE3OHZoZUZVd3EvS3Q3R2pNRjhxMnA5UytWcHFEay9lbVNtdzdv?=
 =?utf-8?B?RkZZRUZsMDJpeWtwVVZRUTJYdHp2NEJaUjE0WDJ6aGVyaEl3QWJsRFJkdUZn?=
 =?utf-8?B?UEUxOWFwaW8rNDFTWjRZbnByWmpHR2M5MTNqNHdFV2ZoKyt6Zm9FUlBxS0Zl?=
 =?utf-8?B?OFR3R3dUMklFYitOSFQ0R0xJWWh6YzZ3Nk42ZUtmNkFIOTB1a0RnMnNHbUlQ?=
 =?utf-8?B?d25oMlVJZ3FIQ2xGdEcyQ29QZHZMVFpDb2N5YWxmekFsL2w3ZXplOGlKdTdk?=
 =?utf-8?B?TGo0ck1LYnZUcUFXbnlSUm1IM014dXYvN2w2MzRaUmdpeFlVYS9CUWg1Qzlj?=
 =?utf-8?B?cDdvWkttSHE3U252TE40elBHWm8xQjRoNXNmL1NLdkZaWjc5cjBOS0dvd2JB?=
 =?utf-8?B?ZFk5amdRRGJrVmpaZXlZYWRhSStyM05zVkdzd2ZWSUdWNGg5RlAreHJydnlw?=
 =?utf-8?B?MUZjT25rYlFpSUpPaS90bGFCbktpd1ZHRUZQNVFwWDRPR1plQ0plUzhGSVA1?=
 =?utf-8?B?Wmg5aW5mWDJYc3dtOERJWHBGUDRuUThCVGtwZXpZRkJjZTVuSUpkMHJ0K1Zy?=
 =?utf-8?B?OC9JSFhLVXFTZTIwandXM0ZiWjNMS2pDME12alhRdGxPMWk2NmFrN0d3bXB6?=
 =?utf-8?B?S291cktOMlI5cEROZHFidU45Ny9BclR0RVFuWHNPT0Y2R21sTnpqbmp6TUl5?=
 =?utf-8?B?VUZTS01yWFlOOS9SNENlSHBwTXpGamQvaHdDM2x5NEJtSUZuRGpEK2QwRW5N?=
 =?utf-8?B?UkI0N1NrSG1OdWtsaGpEeGVidkZMeXdkNHhYSGppcnF3dFFPakQ4dkdvWjhr?=
 =?utf-8?B?MjlaVVp6dVVocFlkVDQvYWJMZFJUdkVYdUR1ZHhZUUh3cCs2QThIUHdmQm9p?=
 =?utf-8?B?NDlWOC9JcldWN0xVNUNrZ1lIZmNYLy9RbDRUcngweG1HNkZ3ekVjM2VMWHk4?=
 =?utf-8?B?bTVRLys1OHRwYUNEdHB6b0UycDRKNFNzL0pMR0t3SjdRUUpJRXV4dFA4YlJK?=
 =?utf-8?B?bVdtTXAxblpwL3dzVTZZWHBXa3luQWZESUlnQzNqMnRiTmdsSzlzSTFURGcr?=
 =?utf-8?B?TkVhS0xrakhuZjR0OWF3RVh1SGtRQXNZOXc1UFpXSUhxUll2OU1vSXY4aFJn?=
 =?utf-8?B?UUdCaGRuWnJuaVJ0ai9teG5Oc2JMcjFvQVFxMjlXWXVkaUV0SGpPT1pPVjZN?=
 =?utf-8?B?M1hlWUV3QVRIVFMvZys5NE1Qc1dyL0YzVmZHejVTd1hVQTUySnJLUk5uV2hP?=
 =?utf-8?B?Nndtdm91M1M1ckw1QWJzOXRLR1h2bWY1cG9nZXJqVkxvRjdEMnhSM0hEdkRs?=
 =?utf-8?B?NndSWVFvVHc3cEVmUkovWmpvYThlQ3lpN2cvenptYjFHcVA0TW5wd0Z4TmlV?=
 =?utf-8?B?VGF1eVdQb2N3WTVnNkZDRDEwWlVHQmFOREJLVTlmdVpCQU82ZjRCeVo5QnRs?=
 =?utf-8?Q?kM0jJttCjvFiemv5KGDMfg/Lh?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 42f9d9e4-52a8-4570-1a69-08db2bcc6dd9
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2023 18:28:42.0886
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Kf7Bw4+8wyD+HUjouyRiRcHD800WtQJoOts/crp+KvmJcJc1Z2xrdgcQtwaJ3GY4vpUrkJvCKQgdXTOZK59TVA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4536
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/23/23 10:34, Woodhouse, David wrote:
> On Thu, 2023-03-23 at 08:16 -0500, Tom Lendacky wrote:
>>
>> Maybe call this sev_early_get_cpuid_0b() or such to imply that the MSR
>> protocol is being used and only retrieving / returning edx.
> 
> Or indeed sev_early_get_apicid() since that's what it's actually doing,
> and the caller doesn't care *how*.

Sounds good.

> 
>> Also, since it is a function now and can be used at any point, the current
>> GHCB MSR should be saved on entry and restored on exit.
> 
> Well, I don't know that it should be callable at any point. This is
> only supposed to be called from head_64.S.

I agree. But once it's there, someone somewhere in the future may look and 
go, oh, I can call this. So I think it either needs a nice comment above 
it about how it is currently used/called and what to do if it needs to be 
called from someplace other than head_64.S or the MSR needs to be 
saved/restored.

Thanks,
Tom

> 
> 
> 
> 
> 
> Amazon Development Centre (London) Ltd. Registered in England and Wales with registration number 04543232 with its registered office at 1 Principal Place, Worship Street, London EC2A 2FA, United Kingdom.
> 
> 
>