Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <79f7638e-bbeb-d959-6143-c678a8225459@efficios.com>
Date:   Thu, 23 Mar 2023 14:44:02 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH] tracepoint: Fix CFI failures with tp_stub_func
Content-Language: en-US
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     Mark Rutland <mark.rutland@arm.com>, linux-kernel@vger.kernel.org,
        mhiramat@kernel.org, "Jose E. Marchesi" <jose.marchesi@oracle.com>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Sami Tolvanen <samitolvanen@google.com>,
        Peter Zijlstra <peterz@infradead.org>
References: <20230323114012.2162285-1-mark.rutland@arm.com>
 <20230323085321.0f8d1b98@gandalf.local.home>
 <ZBxX/uu/s5IKBQOw@FVFF77S0Q05N.cambridge.arm.com>
 <ZBx9+ZyiF6LoKbPr@FVFF77S0Q05N.cambridge.arm.com>
 <20230323123455.36dd83f6@gandalf.local.home>
 <ed29379c-d683-7140-ba82-b3fe8e4d49a5@efficios.com>
 <20230323144220.2729561c@gandalf.local.home>
From:   Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
In-Reply-To: <20230323144220.2729561c@gandalf.local.home>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2023-03-23 14:42, Steven Rostedt wrote:
> On Thu, 23 Mar 2023 14:37:15 -0400
> Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:
> 
>>> Repeated again so Mathieu doesn't have to search for it.
>>>
>>>       [ Note, this version does use undefined compiler behavior (assuming that
>>>         a stub function with no parameters or return, can be called by a location
>>>         that thinks it has parameters but still no return value. Static calls
>>>         do the same thing, so this trick is not without precedent.
>>>
>>>         There's another solution that uses RCU tricks and is more complex, but
>>>         can be an alternative if this solution becomes an issue.
>>>
>>>         Link: https://lore.kernel.org/lkml/20210127170721.58bce7cc@gandalf.local.home/
>>>       ]
>>
>> Ugh. The last thing we need there is more RCU complexity. My brain is still recovering
>> from fixing the last time the introduction of static calls special-cases ended up subtly
>> breaking tracepoints.
> 
> Well, we can go back to your approach with doing the check in the iterator.
> Setting it to 0x1UL I think is what you wanted (to know it's a removed
> function and not a random NULL).
> 
> I could write that up if you want.

I can write the patch and send an RFC, won't take long.

Thanks,

Mathieu

> 
> -- Steve

-- 
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com