Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 24 Mar 2023 02:44:20 +0800
From:   "Ye, Xiang" <xiang.ye@intel.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     Arnd Bergmann <arnd@arndb.de>,
        Matthias Kaehlcke <mka@chromium.org>,
        "Lee Jones" <lee@kernel.org>, Wolfram Sang <wsa@kernel.org>,
        Tyrone Ting <kfting@nuvoton.com>,
        Mark Brown <broonie@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        <linux-usb@vger.kernel.org>, <linux-i2c@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-spi@vger.kernel.org>,
        <linux-gpio@vger.kernel.org>, <srinivas.pandruvada@intel.com>,
        <heikki.krogerus@linux.intel.com>,
        <andriy.shevchenko@linux.intel.com>,
        <sakari.ailus@linux.intel.com>, <zhifeng.wang@intel.com>,
        <wentong.wu@intel.com>, <lixu.zhang@intel.com>
Subject: Re: [PATCH v6 1/6] usb: Add support for Intel LJCA device
Message-ID: <ZByeBLrNIX8cWO4u@ye-NUC7i7DNHE>
References: <20230323172113.1231050-1-xiang.ye@intel.com>
 <20230323172113.1231050-2-xiang.ye@intel.com>
 <ZByU4tbhkhnF4kMw@kroah.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ZByU4tbhkhnF4kMw@kroah.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dNY93k/dWlNJ677rj7NcecpT4eLqMTmFssYStQB+GKUyuV6yVCkIgH0Mqs7V?=
 =?us-ascii?Q?7yfvIJxbTx7JL2ZyHf5m84u5hNiS03ewvJXFBHPBeSGGaaA7H8cjfjjiiREM?=
 =?us-ascii?Q?Jpl65ULUlToAUtZI+STkmyH7XyrFYirXbFTsTdBFkd/6JDZ0K9PrHiKBazmR?=
 =?us-ascii?Q?ACg9+pUtDlGfcC96Xz0sVLXvpD1JKRcwOq364LmtWLe59JE/50HTfuTmQbLu?=
 =?us-ascii?Q?j9LFVT49ae0QGBSTXzEUl/MCSuRFxCQLozPxoCGrl/ebRhfHSvZFFa4rmKor?=
 =?us-ascii?Q?i4zVIKHy3qoT8s0yCT/eGUBkh/Qvodf7YtreA2S3XeFUW+OnJNoF7RiJMSj7?=
 =?us-ascii?Q?jWcAxVSlVqL1EcReWWZ4YVHapC77s1ndyuwRbsWn8bVCXxPAqVdetunkNrLL?=
 =?us-ascii?Q?U6FgjOv0eMDC3SSLeANBm34j+QQY4RKKEnQxTPhSmvHZeUTcWjF9C5393JA7?=
 =?us-ascii?Q?dkiDJJxDRNHh42e/e5kTDpnIYWxTtXLzyfz9ND9DT/kphh1m6t4vG1j9UXYN?=
 =?us-ascii?Q?7NgRVwiRcOimu+TtsRQKJrWBtu8xJE9+YTEB82wT2PpEm4Wjcb8tRxM9VNlE?=
 =?us-ascii?Q?H0+IQ6aL/mOMlwJ3TW9rKxC5MBMjveR2HAbJDwC/VLtRlAbQuX+N8gy6bhPy?=
 =?us-ascii?Q?Y2bE6TVbZrGqg+I5ihhivLeiQ5OOF6CpSm2t1EG1Zz5zqI4jqyMiM0u/RMWK?=
 =?us-ascii?Q?Nxxiaoo3FK9omIGJ49AbBvY8uONb9q8jrTgBdqHMXc/V/VRyzUfU87q2QOZ7?=
 =?us-ascii?Q?N7PH9cZIsmgsMAj47SPuK+cJwSSpSu0BCGWY0B61rqE1rTy8D8bKbzjZUX/k?=
 =?us-ascii?Q?x09IOPBgFf4RXkmJhJws9EvUScnLoCiW4hD36n9Q3GTTui3CnppjfEj9N/tm?=
 =?us-ascii?Q?egpv7be7xZ6wKqkUE22F/xYaPqxc3p2MK1iqnzBld5w8lNjatTvQTkyv467w?=
 =?us-ascii?Q?/Ho0J+VMV9uzmGdav9wkpfku2sG3ht+cQ/goiqoF/9rM3Cw2k2w2EWG8aW5H?=
 =?us-ascii?Q?oJWFHjaRwWA1qBWqWtgbyaoQhkemoZ0cP1JqfydMYQGG6GNSzOuVBS8I0R81?=
 =?us-ascii?Q?dMdMBQOC7vWUOXWn1BAnovKo+yfvqIoq/2C+z7fzfR+XShR9BdpoZn8r0GdD?=
 =?us-ascii?Q?Sy4DoY+MSoyn2e9e/oQN07VtB5GKZhzWAEXSG3eoQVFpdwq811Ms1NUiWtan?=
 =?us-ascii?Q?/FSvvwgZ1IaGZQPCf8nAY9PcPQCVlQmgo+g5FngJrP+1qeDEW5Bd9B34RCEH?=
 =?us-ascii?Q?Sss29oz7huGvIJRZoZP2qjfJN5MsHWXktYe8ww3bNnKvuBRfrqFlx2GkXy0/?=
 =?us-ascii?Q?sgIYy+8M1RkghiApR5bvOUyHH9NBFpeu+jP5rduXVzOOk6IyiQTFoT5OlgLA?=
 =?us-ascii?Q?Rou6WgIZybZryoBZc0UF5fmqehFq0nHRmfUMqdo+o28RQnr0314Fj8cC9ZAG?=
 =?us-ascii?Q?V14RzBu5p2WWg+OwqiS+aO1zPOXhtiq+8vBqZdmN6BeWkmkujkCLvfY76UM0?=
 =?us-ascii?Q?C7HJQEEyj47xpEYCbUxMNMgRsFTubZ7IuJyh1dp8EwcyTr3UfItSnv00ca+F?=
 =?us-ascii?Q?61RE34QYr7XPMHrJC71e8IMXAVxm+BD+YyxpnkZk?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c1adc6a3-9787-4dc9-1b90-08db2bce9f10
X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1418.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2023 18:44:23.8072
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YMXamm3s8fPNk5oD/lchWQHwnnKDGugvGAYbrGR3YTpZ3pIZxfBsT+jF6+YR2IXVKsy8LTUhEMCGJI5tIsnWXg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5591
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Greg,

Thanks for your review.
On Thu, Mar 23, 2023 at 07:05:22PM +0100, Greg Kroah-Hartman wrote:
> On Fri, Mar 24, 2023 at 01:21:08AM +0800, Ye Xiang wrote:
> > +config USB_LJCA
> > +	tristate "Intel La Jolla Cove Adapter support"
> > +	select AUXILIARY_BUS
> > +	depends on USB
> > +	help
> > +	  This adds support for Intel La Jolla Cove USB-I2C/SPI/GPIO
> > +	  Master Adapter (LJCA). Additional drivers such as I2C_LJCA,
> > +	  GPIO_LJCA and SPI_LJCA must be enabled in order to use the
> > +	  functionality of the device.
> > +
> > +	  This driver can also be built as a module. If so, the module
> > +	  will be called ljca.
> 
> That's a very generic name for a USB driver, why not "usb_ljca"?
Thanks for the suggestion. Will adopt it on next version.
> 
> > +struct ljca_dev {
> > +	struct usb_device *udev;
> 
> You didn't remove this like you said you would :(
Sorry. I just stopped using it, but I forgot to delete it in struct ljca_dev.
The udev field is unused in this driver now. I will definitely delete
it on next version.

--
Thanks
Ye Xiang