Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 23 Mar 2023 20:35:02 +0100
From:   Pavel Machek <pavel@ucw.cz>
To:     "Lin, Meng-Bo" <linmengbo0689@protonmail.com>
Cc:     linux-kernel@vger.kernel.org, Lee Jones <lee@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Nikita Travkin <nikita@trvn.ru>,
        Stephan Gerhold <stephan@gerhold.net>,
        linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
        ~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v2 2/2] leds: aw2013: Add vddio regulator
Message-ID: <ZByp5gzspOVcYyah@duo.ucw.cz>
References: <20230320174949.174600-1-linmengbo0689@protonmail.com>
 <20230320175150.174711-1-linmengbo0689@protonmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="59RaXGfovOuoCF5q"
Content-Disposition: inline
In-Reply-To: <20230320175150.174711-1-linmengbo0689@protonmail.com>
Precedence: bulk


--59RaXGfovOuoCF5q
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

> Some LEDs controllers are used with external pull-up for the interrupt
> line and the I2C lines, so we might need to enable a regulator to bring
> the lines into usable state. Otherwise, this might cause spurious
> interrupts and reading from I2C will fail.
>=20
> Implement support for "vddio-supply" that is enabled by the aw2013 driver
> so that the regulator gets enabled when needed.
>=20
> Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com>

> @@ -348,16 +350,20 @@ static int aw2013_probe(struct i2c_client *client)
>  		goto error;
>  	}
> =20
> -	chip->vcc_regulator =3D devm_regulator_get(&client->dev, "vcc");
> -	ret =3D PTR_ERR_OR_ZERO(chip->vcc_regulator);
> -	if (ret) {
> +	chip->regulators[0].supply =3D "vcc";
> +	chip->regulators[1].supply =3D "vddio";
> +	ret =3D devm_regulator_bulk_get(&client->dev,
> +				      ARRAY_SIZE(chip->regulators),
> +				      chip->regulators);
> +	if (ret < 0) {
>  		if (ret !=3D -EPROBE_DEFER)
>  			dev_err(&client->dev,
>  				"Failed to request regulator: %d\n", ret);
>  		goto error;

Won't this cause failures when optional vddio is unavailable?

BR,
							Pavel
						=09
--=20
People of Russia, stop Putin before his war on Ukraine escalates.

--59RaXGfovOuoCF5q
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCZByp5gAKCRAw5/Bqldv6
8hkzAJ95xl/kGY8uKTWuWX12QJuhBM2uMQCgg21hmFNALojBHzMSFd7aDS+yVfQ=
=646S
-----END PGP SIGNATURE-----

--59RaXGfovOuoCF5q--