Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 23 Mar 2023 20:47:13 +0100
From:   Pavel Machek <pavel@ucw.cz>
To:     Tom Rix <trix@redhat.com>
Cc:     lee@kernel.org, quic_fenglinw@quicinc.com,
        linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: flash: set varaiables mvflash_3,4ch_regs
 storage-class-specifier to static
Message-ID: <ZByswXZdvtaLOT02@duo.ucw.cz>
References: <20230317191341.1670660-1-trix@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="MlvgGa6aPZUA/Ytr"
Content-Disposition: inline
In-Reply-To: <20230317191341.1670660-1-trix@redhat.com>
Precedence: bulk


--MlvgGa6aPZUA/Ytr
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri 2023-03-17 15:13:41, Tom Rix wrote:
> smatch reports
> drivers/leds/flash/leds-qcom-flash.c:103:18: warning:
>   symbol 'mvflash_3ch_regs' was not declared. Should it be static?
> drivers/leds/flash/leds-qcom-flash.c:115:18: warning:
>   symbol 'mvflash_4ch_regs' was not declared. Should it be static?
>=20
> These variables are only used in leds-qcom-flash.c,
> so it should be static.
>=20
> Signed-off-by: Tom Rix <trix@redhat.com>

Acked-by: Pavel Machek <pavel@ucw.cz>

BR,
								Pavel
							=09
--=20
People of Russia, stop Putin before his war on Ukraine escalates.

--MlvgGa6aPZUA/Ytr
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCZByswQAKCRAw5/Bqldv6
8hQMAKCEU+lvVVTeYJd+VCSdUYTHj6c4cgCgijcjRaytSXdJ8jS6QfD1udDiL0s=
=zJ1D
-----END PGP SIGNATURE-----

--MlvgGa6aPZUA/Ytr--