Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 23 Mar 2023 13:43:49 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     "Liang, Kan" <kan.liang@linux.intel.com>,
        Ian Rogers <irogers@google.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        "Namhyung Kim" <namhyung@kernel.org>,
        Zhengjun Xing <zhengjun.xing@linux.intel.com>,
        <linux-perf-users@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        "Edward Baker" <edward.baker@intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        <perry.taylor@intel.com>, <caleb.biggers@intel.com>,
        <samantha.alt@intel.com>, <weilin.wang@intel.com>
Subject: Re: [PATCH v2 8/9] perf metrics: Add has_optane literal
Message-ID: <641cba052d0f8_1b98bb294ab@dwillia2-xfh.jf.intel.com.notmuch>
References: <20230323192028.135759-1-irogers@google.com>
 <20230323192028.135759-9-irogers@google.com>
 <44476adc-3797-504b-2b82-8ec670c691b6@linux.intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <44476adc-3797-504b-2b82-8ec670c691b6@linux.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?XjBgpbPzlX21rpidoKllVANYQrD39GLqpcdaQcvjGX5MmYepZuW/hGBZVBmK?=
 =?us-ascii?Q?GW9LEou8acr3BGPT5fNFjmkH1/zDdGYBK6j0PXx3gTeq2CBdegxvF/0ZC7sO?=
 =?us-ascii?Q?jd81yJILRakjxdcts9X/dvoZNQbkMsVTqbFlhKR+RLmD0soJKVee4SyXvXoy?=
 =?us-ascii?Q?BhsyGG7yIwyrkxOKgLeH6IYhFvy/Bt38xDV3NsY29nM+YwQmox3aqlygqVcZ?=
 =?us-ascii?Q?lJgCtVYCpJfqI6H0p2fdDVrdmzZaCrCeQVSziva2+jvh5K3C7kphQ00gGFyH?=
 =?us-ascii?Q?ZLogDx3bH/UG8O7ZDV7Vk/XhSMkJ4wjwUIrM2kJbONa21aw8m7LxiX9FwlTS?=
 =?us-ascii?Q?Vdh0Lu/1S/APQx2E4Su/7DsTHX0wf0owuYP6Jr0lMPiTKJIFCb2b0HcwpXyN?=
 =?us-ascii?Q?l9KNwZOdp+9OAarzhdTEZVrkziejato+7RYkDPXKi5Dv93+RFoKBO4BrtgIg?=
 =?us-ascii?Q?MIvaFWbhZUyDHWRmo1EnT+40wPeBDSjUbQDyLwbOhke9L6UqVEg/h9XTspZn?=
 =?us-ascii?Q?znD4bpkkSXr/B/CAtt6l+W1IApHHItKsFku0nVXDTZcKYZs37LqKMsLNQdGC?=
 =?us-ascii?Q?n1iq5XQsJ4CmWV624a1ItDofyJidux/kUKtiWAQz6Jubcsr1MHTzg8xMFdTd?=
 =?us-ascii?Q?rf/WYvLZnMGObDbkVawy0vllO5WeXiykDdJRz27s/VAGav68MD+ajPtK0ZIe?=
 =?us-ascii?Q?z4cub9CWeO2nRrIZfyp1l0t7tVzgodHymj77IkvarHPLmfggHyWbifOFooDr?=
 =?us-ascii?Q?uUgK2W6Y+3slouyFb2QxgOZpa6zCy2fE1/dPe8sSaGoBnpS3az3d7e4IVsPg?=
 =?us-ascii?Q?VqKJOjcaBT1hOUHUGQWO51Rw/uc9s0+l/O3I8G0Kd0tYTqwDA/MHZVyGiK1R?=
 =?us-ascii?Q?FagSiTLtTgyrPDHZWbdL8r3xWvws8MZMx/+zPMSCLPgwqtXiWaLkEzds8nGR?=
 =?us-ascii?Q?DtxHL/H0kfTcyrSTwQYu5mw5/e3jeIFNASRzpKX16zVQSNEpqzXsYMw/M1dQ?=
 =?us-ascii?Q?U3no3r7ULt8aGxDkx9t7Auj6t9rBviA3qKchMYrM2Lp4ZiYAPWz9usApr0fn?=
 =?us-ascii?Q?jDxcOa/x6K54+91PYI2gptq2VJC/6+HYifswNk3yc8PKHlQUsBuYPqg8zMkL?=
 =?us-ascii?Q?1T6ChujIRyGZrI7Qs49Xlg/6tybN0mJL/kqkzDEYSYJ/5PvCcmqPKYQ5TYfl?=
 =?us-ascii?Q?JV9jxi3IPVgIZFMwQWSOuEGTMweV/9Z9J8OAau68bj8W4Veqv4/zx5JA2pZx?=
 =?us-ascii?Q?1I1AFYJ3NAyubj5pqY0QcpmWY7UGQD4I4ac+odfPdmNa8XoRAVyJuxJaHsd4?=
 =?us-ascii?Q?TLTk2dzjilN94uDNPfrESqkXMdGv2ZIVg+21PYq5yRU2I0PVAuQjKYqTMuif?=
 =?us-ascii?Q?9clMbFV+h9zSNsUO+CXy04YVbEBscKrawGJVmQ8SPyUt5q5jnQF9mNauNzOz?=
 =?us-ascii?Q?qzK287Lt8xzI5djU+guuSTSlJchOXmfy8X+WtdrbZJVeIFHSSPd0WefmE0fi?=
 =?us-ascii?Q?wBMIW7SdrwbKBhcyXW9pNdLnjhviBlgAfcyjdoR8QpdL2HztQmf0op8pz/Iv?=
 =?us-ascii?Q?+ccaRkYuCDoK7oFyOCeE5ujnnzgS1xkvoxcguTmvPEGF6UA0+/Lhhg6AKwzD?=
 =?us-ascii?Q?lw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 86fea268-854b-47ac-eadd-08db2bdf50b7
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2023 20:43:53.6551
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6LMK+T+uQcm3QC0JgW9mmxtXWT/Pb2TdI6MwwDnAMFTsnmQ5aopCnnCW5M1Z9c/CtCWyOLmocRRAuAiQg93JYyZ+DbWiLvkELPDjrAuOOgI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB8120
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Liang, Kan wrote:
> 
> 
> On 2023-03-23 3:20 p.m., Ian Rogers wrote:
> > Add literal so that if optane memory isn't installed we can record
> > fewer events.  
> 
> I think we call it pmem (Persistent Memory) everywhere in the Linux
> code. Maybe we should use #has_pmem instead?

That makes sense especially because has_optane implies more precision
than the the check is performing. In general Optane is probably the
widest deployed NVDIMM type, but this check will succeed with battery
backed NVDIMMs and emulated PMEM in VMs which I think is perfectly ok
for making a default event record decision.