Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp134682rwl; Thu, 23 Mar 2023 13:48:20 -0700 (PDT) X-Google-Smtp-Source: AKy350ZFIPwx95Z3RmbQK8darP83xRVziIDMs42vZjDNDJurkXpAvbht1MNb3ZGdXX2PQVM2/k/p X-Received: by 2002:a17:90a:e7ca:b0:23d:2415:c9a9 with SMTP id kb10-20020a17090ae7ca00b0023d2415c9a9mr217566pjb.34.1679604500239; Thu, 23 Mar 2023 13:48:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679604500; cv=none; d=google.com; s=arc-20160816; b=ZaJWb3DB7LRryyVWOpaXgxBAYBqJmgyvqPa77+ka6SHvKSII+hHo1SRTx3OPpAHU2H mwD8smju2H8C4sAzUOxvm0TJmmNwx4FJTGLyM9nbYvIPvc1w12FrNhbGVH0PC3yBR9Kl ziAqeBrXwnJfgNz2d+uH+6SAd3USwGYF6NYAeN0Rk+AaRYd/SC2ytJoE21BUkXaFH2FM ClkLS6JrOErnzjPub8ucnOZSLDcsGiZidu8c2p7qMG4WQ3yTc8nDub4QYmKwfhriYzzu 5ATNMbSLtpaoUVZjAPlSxx2UYgzGkah5apx2MZ6lRLMMZ3UCjbOd0IJHIoGbuXSG2azi AwHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:date:to:from:subject:references :in-reply-to:content-transfer-encoding:mime-version:message-id :dkim-signature; bh=P6I0W6qPAsf0hZMdu29TtpwKztyniEZ29LfDRXsGq7w=; b=iUg/Edl6K4rybiOWEJFPWW6Eh/5mhzK89FQy/7xhZ/wiYPikxhHrRKEm/GNS2IrBGQ LrithcYf7yXBJGxqSG5zlZ4Z0HmhUcAK5LXlsg8k7N2sM8XGkPQDBF4AFR3DjCgySlGZ LjyjejVIbunNA9Jb9BYVnl3HrblU2pM512oJXEjcgKMc+AUtcZm/EJ2+2PDyaDTW12fH RdtTDq7m2kBft5bUsrzS+95M/BdDN10jpqqzqGW/v+N6AEuQIHi4DyXYilopu2dNLxoh 631nqld3jWDW02KN64OiLL7dvegpaWlY9vBOHt2vuUQnOB9TQv5XXkbIWWwro78OrgzR n1vw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HGkcOxq8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t21-20020a17090aba9500b002344ef1a33esi2533641pjr.98.2023.03.23.13.48.06; Thu, 23 Mar 2023 13:48:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HGkcOxq8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231503AbjCWUqq (ORCPT + 99 others); Thu, 23 Mar 2023 16:46:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33578 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231504AbjCWUql (ORCPT ); Thu, 23 Mar 2023 16:46:41 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80EB118B26; Thu, 23 Mar 2023 13:46:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 185E3628AC; Thu, 23 Mar 2023 20:46:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6CFF3C433D2; Thu, 23 Mar 2023 20:46:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679604395; bh=P6I0W6qPAsf0hZMdu29TtpwKztyniEZ29LfDRXsGq7w=; h=In-Reply-To:References:Subject:From:To:Date:From; b=HGkcOxq8/EGtQMuOQjnEgKzxYEn6jA+Tkv/UlOH6epkeISTnRnPz0LjAgMNk30+BK hzQ5nrKVAfC2B5/h8brgxFunzYp6nf1TL/P7rCn3bPcYN1Ylbp5EMeDdv4/cMfVOXx S359U2GjKhuUieB+GOYFFswsZU2VTyEgKYrw36fa4o0xaLiv6ntKlpGs9KGGJLxyKF ODuVJ5oPwQ5OHQcuBhUCQBVPGgGp7UL0ElTsGVFX4QPhHwHkEBtgeGGjCpigpJTeSs n8GOjvk6+xr2k1wgEoeJhRrSn4m7hc5Y3CxcBf0KwbB5//OlrdZn3Lc8Lb+rIMp8E2 eAwY1Y9AOlGLg== Message-ID: <8e0fac7e756272e2593e7c220f9ae69f.sboyd@kernel.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <5b3fcceb-1a0d-d0c7-910d-eb4e65892676@quicinc.com> References: <20230317141622.1926573-1-quic_mohs@quicinc.com> <20230317141622.1926573-5-quic_mohs@quicinc.com> <406d02f72767afafa8e563ec2ee7f310.sboyd@kernel.org> <5b3fcceb-1a0d-d0c7-910d-eb4e65892676@quicinc.com> Subject: Re: [PATCH v9 4/4] clk: qcom: lpassaudiocc-sc7280: Modify qcom_cc_probe to qcom_cc_probe_by_index From: Stephen Boyd To: Mohammad Rafi Shaik , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, quic_visr@quicinc.com Date: Thu, 23 Mar 2023 13:46:33 -0700 User-Agent: alot/0.10 X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Mohammad Rafi Shaik (2023-03-23 00:45:26) >=20 > On 3/17/2023 11:57 PM, Stephen Boyd wrote: > > Quoting Mohammad Rafi Shaik (2023-03-17 07:16:22) > >> Modify AHB clocks explicit registration from qcom_cc_probe to > >> qcom_cc_probe_by_index. > > Why? Isn't it the same? > yes, it is same. >=20 > As per the previous version review comment, modified qcom_cc_probe to=20 > qcom_cc_probe_by_index. Previously you were probing with index 1. That necessitated using qcom_cc_probe_by_index() instead of qcom_cc_probe(). That is no longer the case though, so this patch is unnecessary.