Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ee39474effb15c0a82e8ae115caf77fe8a1d1d33.camel@linux.ibm.com>
Subject: Re: perf tools power9 JSON files build breakage on ubuntu 18.04
 cross build
From:   Benjamin Gray <bgray@linux.ibm.com>
To:     Ian Rogers <irogers@google.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     Heiko Carstens <hca@linux.ibm.com>,
        Thomas Richter <tmricht@linux.ibm.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>,
        linuxppc-dev@lists.ozlabs.org
Date:   Fri, 24 Mar 2023 08:51:31 +1100
In-Reply-To: <CAP-5=fX-0giZxATOVXO5PmCD6yfhoGMb4_vMcWAQLnSq=+DMhQ@mail.gmail.com>
References: <ZBxP77deq7ikTxwG@kernel.org>
         <CAP-5=fX-0giZxATOVXO5PmCD6yfhoGMb4_vMcWAQLnSq=+DMhQ@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2023-03-23 at 08:50 -0700, Ian Rogers wrote:
> On Thu, Mar 23, 2023 at 6:11=E2=80=AFAM Arnaldo Carvalho de Melo
> <acme@kernel.org> wrote:
> >=20
> > Exception processing pmu-events/arch/powerpc/power9/other.json
> > Traceback (most recent call last):
> > =C2=A0 File "pmu-events/jevents.py", line 997, in <module>
> > =C2=A0=C2=A0=C2=A0 main()
> > =C2=A0 File "pmu-events/jevents.py", line 979, in main
> > =C2=A0=C2=A0=C2=A0 ftw(arch_path, [], preprocess_one_file)
> > =C2=A0 File "pmu-events/jevents.py", line 935, in ftw
> > =C2=A0=C2=A0=C2=A0 ftw(item.path, parents + [item.name], action)
> > =C2=A0 File "pmu-events/jevents.py", line 933, in ftw
> > =C2=A0=C2=A0=C2=A0 action(parents, item)
> > =C2=A0 File "pmu-events/jevents.py", line 514, in preprocess_one_file
> > =C2=A0=C2=A0=C2=A0 for event in read_json_events(item.path, topic):
> > =C2=A0 File "pmu-events/jevents.py", line 388, in read_json_events
> > =C2=A0=C2=A0=C2=A0 events =3D json.load(open(path), object_hook=3DJsonE=
vent)
> > =C2=A0 File "/usr/lib/python3.6/json/__init__.py", line 296, in load
> > =C2=A0=C2=A0=C2=A0 return loads(fp.read(),
> > =C2=A0 File "/usr/lib/python3.6/encodings/ascii.py", line 26, in decode
> > =C2=A0=C2=A0=C2=A0 return codecs.ascii_decode(input, self.errors)[0]
> > UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in
> > position 55090: ordinal not in range(128)
> > =C2=A0 CC=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /tmp/build/perf/tests/expr.o
> > pmu-events/Build:35: recipe for target '/tmp/build/perf/pmu-
> > events/pmu-events.c' failed
> > make[3]: *** [/tmp/build/perf/pmu-events/pmu-events.c] Error 1
> > make[3]: *** Deleting file '/tmp/build/perf/pmu-events/pmu-
> > events.c'
> > Makefile.perf:679: recipe for target '/tmp/build/perf/pmu-
> > events/pmu-events-in.o' failed
> > make[2]: *** [/tmp/build/perf/pmu-events/pmu-events-in.o] Error 2
> > make[2]: *** Waiting for unfinished jobs....
> >=20
> >=20
> > Now jevents is an opt-out feature so I'm noticing these problems.
> >=20
> > A similar fix for s390 was accepted today:
>=20
> The JEVENTS_ARCH=3Dall make option builds the s390 files even on x86.
> I'm confused as to why that's been working before these fixes.

This is the non-breaking space in the file (UTF8 C2 A0). Telling Python
to decode with UTF8 would work (note it's breaking with the 'ascii'
codec). Setting the environment variable LC_CTYPE=3D"C.UTF-8" sets the
default, or the script can specify explicitly.

But I also doubt the NBS was intentional in the first place.