Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 23 Mar 2023 15:15:20 -0700
From:   David Matlack <dmatlack@google.com>
To:     Vipin Sharma <vipinsh@google.com>
Cc:     seanjc@google.com, pbonzini@redhat.com, bgardon@google.com,
        jmattson@google.com, mizhang@google.com, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [Patch v4 12/18] KVM: x86/mmu: Allocate NUMA aware page tables
 on TDP huge page splits
Message-ID: <ZBzPeETL7/R1Qwwe@google.com>
References: <20230306224127.1689967-1-vipinsh@google.com>
 <20230306224127.1689967-13-vipinsh@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230306224127.1689967-13-vipinsh@google.com>
Precedence: bulk

On Mon, Mar 06, 2023 at 02:41:21PM -0800, Vipin Sharma wrote:
> +
> +void *kvm_mmu_get_free_page(gfp_t gfp, int nid)
> +{
> +#ifdef CONFIG_NUMA

Is this #ifdef necessary? alloc_pages_node() is defined regardless of
CONFIG_NUMA.

> +	struct page *page;
> +
> +	if (nid != NUMA_NO_NODE) {
> +		page = alloc_pages_node(nid, gfp, 0);
> +		if (!page)
> +			return (void *)0;
> +		return page_address(page);
> +	}
> +#endif /* CONFIG_NUMA */
> +	return (void *)__get_free_page(gfp);
> +}
> +