Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230321023136.57986-1-aford173@gmail.com> <CAOMZO5B9odY1-EnKcAi=TQgzb5mwnPRXDtCdGNj+t=3wOyeAjw@mail.gmail.com>
In-Reply-To: <CAOMZO5B9odY1-EnKcAi=TQgzb5mwnPRXDtCdGNj+t=3wOyeAjw@mail.gmail.com>
From:   Adam Ford <aford173@gmail.com>
Date:   Thu, 23 Mar 2023 17:44:33 -0500
Message-ID: <CAHCN7xJaR=ORrRg=9S0sx8DKQpYdk_iU0_DwYwr_=QCEGi+GRA@mail.gmail.com>
Subject: Re: [PATCH V2 0/4] clk: imx: Improve imx8mm/imx8mn LCDIF clocks
To:     Fabio Estevam <festevam@gmail.com>
Cc:     linux-clk@vger.kernel.org, aford@beaconembedded.com,
        Abel Vesa <abelvesa@kernel.org>, Peng Fan <peng.fan@nxp.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        NXP Linux Team <linux-imx@nxp.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Mar 23, 2023 at 5:31=E2=80=AFPM Fabio Estevam <festevam@gmail.com> =
wrote:
>
> On Mon, Mar 20, 2023 at 11:31=E2=80=AFPM Adam Ford <aford173@gmail.com> w=
rote:
> >
> > Both the i.MX8M Mini and Nano have a video_pll which can be used
> > to source a clock which feeds the lcdif interface.  This interface
> > currently fixes video_pll and divides down the clock feeding LCDIF.
> > However, when connected to an HDMI bridge chip that supports a
> > variety of video resolutions and refresh rates, the only settings
> > that properly sync are ones that evenly divide from the video_pll_out
> > clock.
> >
> > This series adds the ability for the clk-compolsite-8m to
> > request a better parent clock rate if the proper clock flag is
> > enable and sets that flag in the corresponding imx8mm and
> > imx8mn video_pll clocks to increase the number of resolutions
> > and refresh rates timings that the LCDIF can produce.
> >
> > This also has a side benefit of allowing the video-pll to run
> > at a lower clock speed which can potentially save some power
> > depending on the requested resolution and refresh rate.
> >
> > V2:  Split off the new imx8m_clk_hw_composite_flags definition
> >      into its own patch and re-order to fix build error.
> >
> > Adam Ford (3):
> >   clk: imx: composite-8m: Add support to determine_rate
> >   clk: imx8mm: Let IMX8MM_CLK_LCDIF_PIXEL set parent rate
> >   clk: imx: Let IMX8MN_CLK_DISP_PIXEL set parent rate
>
> For the series:
>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
>
Thanks!

> Should drivers/clk/imx/clk-imx8mp.c also be adjusted in the same way?

The LVDS and the DSI clocks are shared from a common parent, so I am
not sure of the impact of this.  I have an IMX8MP and I have it
working with DSI->HDMI and the LVDS, but I was waiting on the DSI
series from Jagan to get applied first and I wanted to make sure this
series gets accepted before I started work on the 8MP.

I will be traveling to Thailand for the next 3 weeks, so I'm hoping to
review the 8MP when I return.

adam