Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 23 Mar 2023 16:49:39 -0700
From:   "Paul E. McKenney" <paulmck@kernel.org>
To:     Akira Yokosawa <akiyks@gmail.com>
Cc:     parri.andrea@gmail.com, stern@rowland.harvard.edu, will@kernel.org,
        peterz@infradead.org, boqun.feng@gmail.com, npiggin@gmail.com,
        dhowells@redhat.com, j.alglave@ucl.ac.uk, luc.maranget@inria.fr,
        linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
        kernel-team@meta.com, mingo@kernel.org
Subject: Re: [PATCH memory-model scripts 01/31] tools/memory-model: Document
 locking corner cases
Message-ID: <7f977c87-c2ba-4897-8d03-dc35ef706f9e@paulmck-laptop>
Reply-To: paulmck@kernel.org
References: <4e5839bb-e980-4931-a550-3548d025a32a@paulmck-laptop>
 <20230321010549.51296-1-paulmck@kernel.org>
 <f940cb6c-4aa6-41a4-d9d7-330becd5427a@gmail.com>
 <cd356db2-1643-4b01-bb13-16a7f92cf980@paulmck-laptop>
 <2d26aad2-a1d5-649c-86ec-9457c577333f@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2d26aad2-a1d5-649c-86ec-9457c577333f@gmail.com>
Precedence: bulk

On Fri, Mar 24, 2023 at 08:30:38AM +0900, Akira Yokosawa wrote:
> On Thu, 23 Mar 2023 11:52:15 -0700, Paul E. McKenney wrote:
> > On Thu, Mar 23, 2023 at 11:52:57AM +0900, Akira Yokosawa wrote:
> >> Hi Paul,
> >>
> >> On Mon, 20 Mar 2023 18:05:19 -0700, Paul E. McKenney wrote:
> >>> Most Linux-kernel uses of locking are straightforward, but there are
> >>> corner-case uses that rely on less well-known aspects of the lock and
> >>> unlock primitives.  This commit therefore adds a locking.txt and litmus
> >>> tests in Documentation/litmus-tests/locking to explain these corner-case
> >>> uses.
> >>>
> >>> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> >>> ---
> >>>  .../litmus-tests/locking/DCL-broken.litmus    |  55 +++
> >>>  .../litmus-tests/locking/DCL-fixed.litmus     |  56 +++
> >>>  .../litmus-tests/locking/RM-broken.litmus     |  42 +++
> >>>  .../litmus-tests/locking/RM-fixed.litmus      |  42 +++
> >>>  tools/memory-model/Documentation/locking.txt  | 320 ++++++++++++++++++
> >>
> >> I think the documentation needs adjustment to cope with Andrea's change
> >> of litmus tests.
> >>
> >> Also, coding style of code snippets taken from litmus tests look somewhat
> >> inconsistent with other snippets taken from MP+... litmus tests:
> >>
> >>   - Simple function signature such as "void CPU0(void)".
> >>   - No declaration of local variables.
> >>   - Indirection level of global variables.
> >>   - No "locations" clause
> >>
> >> How about applying the diff below?
> > 
> > Good eyes, thank you!  I will fold this in with attribution.
> 
> Feel free to add
> 
> Reviewed-by: Akira Yokosawa <akiyks@gmail.com>

Thank you, I will apply on my next full rebase.

							Thanx, Paul