Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i58a146ae:Fastmail
Date:   Fri, 24 Mar 2023 11:08:21 +1100 (AEDT)
From:   Finn Thain <fthain@linux-m68k.org>
To:     Geert Uytterhoeven <geert@linux-m68k.org>
cc:     Andreas Schwab <schwab@linux-m68k.org>,
        linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] nubus: Don't list card resources by default
In-Reply-To: <CAMuHMdUQ3+OUKZ-6DqcJfMgq8_90Cejzc=onhUmbaYTWJkZHRw@mail.gmail.com>
Message-ID: <c882ca59-e75d-7ca2-d63f-70aab1b46ade@linux-m68k.org>
References: <5b7c473247d66776343d82a55b9815195b1b11fb.1679551394.git.fthain@linux-m68k.org> <mvmttybx3ng.fsf@linux-m68k.org> <CAMuHMdUQ3+OUKZ-6DqcJfMgq8_90Cejzc=onhUmbaYTWJkZHRw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="-1463811774-1838988264-1679616501=:26267"
Precedence: bulk

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

---1463811774-1838988264-1679616501=:26267
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Thu, 23 Mar 2023, Geert Uytterhoeven wrote:

> On Thu, Mar 23, 2023 at 9:39=E2=80=AFAM Andreas Schwab <schwab@linux-m68k=
=2Eorg> wrote:
> > On M=C3=A4r 23 2023, Finn Thain wrote:
> >
> > > Checkpatch says "externs should be avoided in .c files" and if this o=
ne
> > > appeared twice I would agree. But as it only appears once, I can't se=
e
> > > any advantage to putting it in a new .h file instead of the .c file..=
=2E
> >
> > Anything wrong with declaring it in <linux/nubus.h>?
>=20
> It's not meant for NuBus device drivers (at least in its current form).
> So a drivers/nubus/nubus.h would be the most logical place.
>=20

I think Andreas is right inasmuchas the existing prototypes shared between=
=20
drivers/nubus/nubus.c and drivers/nubus/proc.c are found there, and this=20
extern is another one of those.

But I take Geert's point that much of include/linux/nubus.h could be moved=
=20
to drivers/nubus/something.h. But is there anything to be gained from=20
splitting it up that way?
---1463811774-1838988264-1679616501=:26267--