Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8271c37c-4995-445c-89b7-90848f7ef3cc@hust.edu.cn>
Date:   Fri, 24 Mar 2023 09:46:40 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.8.0
Subject: Re: [PATCH v2] usb: dwc3: host: remove dead code in
 dwc3_host_get_irq()
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Mingxuan Xiang <mx_xiang@hust.edu.cn>
Cc:     Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
        hust-os-kernel-patches@googlegroups.com, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230323095311.1266655-1-mx_xiang@hust.edu.cn>
 <ZBxy9LYz+JyNW6GY@kroah.com>
From:   Dongliang Mu <dzm91@hust.edu.cn>
In-Reply-To: <ZBxy9LYz+JyNW6GY@kroah.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2023/3/23 23:40, Greg Kroah-Hartman wrote:
> On Thu, Mar 23, 2023 at 05:53:10PM +0800, Mingxuan Xiang wrote:
>> platform_get_irq() no longer returns 0, so there is no
>> need to check whether the return value is 0.
> How did you find this issue?
>
> How was it tested?

Hi Greg,

We found this issue by Smatch. Our team is trying fix some true bugs 
found by Smatch, with the help of Dan.

Since this is a dead code removal, we only do compilation testing.

>
> thanks,
>
> greg k-h