Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp488064rwl; Thu, 23 Mar 2023 20:01:48 -0700 (PDT) X-Google-Smtp-Source: AKy350aJVoZkZXXOmJIWr2sgeJTjdxWuLuXQmIOwTLmxt0i2R6xpesS1xdGxKwEmynH+df09/kKU X-Received: by 2002:aa7:8bd0:0:b0:627:82a7:11f9 with SMTP id s16-20020aa78bd0000000b0062782a711f9mr1493745pfd.12.1679626908456; Thu, 23 Mar 2023 20:01:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679626908; cv=none; d=google.com; s=arc-20160816; b=fqyw7Qt5MTJYO2p2mWb4MvE7/wGyJCeSYEADTxxNqARHxrjuOO9cKafmTRJEH/34tD FwdECo7p28VF+CORU8puZmnYf+hRXVtwwee4JAiCeZ+LOAhELMKaOuV+jKwfr2brcX3r El6F3HhWaf2G/hUnEiIBVFZVbx+/0xi7l0fSuPltAVyGPI2dk50xYD/REfFq5Xv/pVe2 /VS12rtR3PdTf4FEPXxA9C1WcKjHd5926LL/CCjfsUUmoCXT6XEdtgGYpKQCPvNeQBUJ XmPExrrMjKR/8iKmM6XpSpwgfNnuHvdylkllAhLkDRpr89p2/dfkealu2Gc/q3p+qv9t SNbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=ucuudy0GdvvIAdYzp3COWWr9OeuwTbr7vdkIlbOp0n0=; b=seMwuQI1x2QMXCWy4JsY7a4D34KB79xWV48INeScEMJGKfPMTA9VGUKNk9de5Fp6CN 0kPQa6UxvPhjUAEww33EWoBCqJmvUECI7JcJPwBQXyMRsvEmavMyaKCv9Ez1GLufloQB kS2zApQYgmqRejT/S/nl60uI0IBu2hofqfKYOxrQCvK4wcexVNMzesahB2QBRQ2Dao7B IcAamBjviENU/lstxcRRI9juvTAWw7qaEsmplYQ4xu30q0ZmJRRTXKAQfscHBd0MRsxp vakHxpvOp3ZxQYBVoJplaHNDbf8KNJ6deEu2fSWV+qU/7ffyFrVqG8kPCCzvKMRhPyWm 1G1w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j36-20020a634a64000000b005030eb175d1si9379651pgl.107.2023.03.23.20.01.35; Thu, 23 Mar 2023 20:01:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230476AbjCXC4H (ORCPT + 99 others); Thu, 23 Mar 2023 22:56:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231153AbjCXC4E (ORCPT ); Thu, 23 Mar 2023 22:56:04 -0400 Received: from out30-124.freemail.mail.aliyun.com (out30-124.freemail.mail.aliyun.com [115.124.30.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82162FF24; Thu, 23 Mar 2023 19:55:55 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R101e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046060;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=12;SR=0;TI=SMTPD_---0VeWDAvu_1679626549; Received: from localhost(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0VeWDAvu_1679626549) by smtp.aliyun-inc.com; Fri, 24 Mar 2023 10:55:52 +0800 From: Jiapeng Chong To: saeedm@nvidia.com Cc: leon@kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, richardcochran@gmail.com, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Chong , Abaci Robot Subject: [PATCH 2/2] net/mlx5e: Fix missing error code in mlx5e_rx_reporter_err_icosq_cqe_recover() Date: Fri, 24 Mar 2023 10:55:41 +0800 Message-Id: <20230324025541.38458-2-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c In-Reply-To: <20230324025541.38458-1-jiapeng.chong@linux.alibaba.com> References: <20230324025541.38458-1-jiapeng.chong@linux.alibaba.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.0 required=5.0 tests=ENV_AND_HDR_SPF_MATCH, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The error code is missing in this code scenario, add the error code '-EINVAL' to the return value 'err'. drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c:105 mlx5e_tx_reporter_err_cqe_recover() warn: missing error code 'err'. Reported-by: Abaci Robot Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4600 Signed-off-by: Jiapeng Chong --- drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c b/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c index 44c1926843a1..5e2e2449668d 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c @@ -101,8 +101,10 @@ static int mlx5e_tx_reporter_err_cqe_recover(void *ctx) goto out; } - if (state != MLX5_SQC_STATE_ERR) + if (state != MLX5_SQC_STATE_ERR) { + err = -EINVAL; goto out; + } mlx5e_tx_disable_queue(sq->txq); -- 2.20.1.7.g153144c