Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230324020838.67149-1-zhanggenjian@kylinos.cn>
 <78422b96-52ed-b48a-27d0-1cfaa89a6608@gmx.com> <20230324022904.GD10580@twin.jikos.cz>
In-Reply-To: <20230324022904.GD10580@twin.jikos.cz>
From:   genjian zhang <zhanggenjian123@gmail.com>
Date:   Fri, 24 Mar 2023 11:05:57 +0800
Message-ID: <CAOd03yQUD1ehcfApW++7buVDOiWzggnvjTzsgiWGqf+pdrL9sA@mail.gmail.com>
Subject: Re: [PATCH] btrfs: fix uninitialized variable warning
To:     dsterba@suse.cz
Cc:     Qu Wenruo <quwenruo.btrfs@gmx.com>, clm@fb.com,
        josef@toxicpanda.com, dsterba@suse.com,
        linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
        Genjian Zhang <zhanggenjian@kylinos.cn>,
        k2ci <kernel-bot@kylinos.cn>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Mar 24, 2023 at 10:35=E2=80=AFAM David Sterba <dsterba@suse.cz> wro=
te:
>
> On Fri, Mar 24, 2023 at 10:24:55AM +0800, Qu Wenruo wrote:
> > On 2023/3/24 10:08, Genjian wrote:
> > > From: Genjian Zhang <zhanggenjian@kylinos.cn>
> > >
> > > compiler warning:
> >
> > Compiler version please.
> >
> > >
> > > ../fs/btrfs/volumes.c: In function =E2=80=98btrfs_init_new_device=E2=
=80=99:
> > > ../fs/btrfs/volumes.c:2703:3: error: =E2=80=98seed_devices=E2=80=99 m=
ay be used uninitialized in this function [-Werror=3Dmaybe-uninitialized]
> > >   2703 |   btrfs_setup_sprout(fs_info, seed_devices);
> > >        |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > >
> > > ../fs/btrfs/send.c: In function =E2=80=98get_cur_inode_state=E2=80=99=
:
> > > ../include/linux/compiler.h:70:32: error: =E2=80=98right_gen=E2=80=99=
 may be used uninitialized in this function [-Werror=3Dmaybe-uninitialized]
> > >     70 |   (__if_trace.miss_hit[1]++,1) :  \
> > >        |                                ^
> > > ../fs/btrfs/send.c:1878:6: note: =E2=80=98right_gen=E2=80=99 was decl=
ared here
> > >   1878 |  u64 right_gen;
> > >        |      ^~~~~~~~~
> > >
> > > Initialize the uninitialized variables.
> > >
> > > Reported-by: k2ci <kernel-bot@kylinos.cn>
> > > Signed-off-by: Genjian Zhang <zhanggenjian@kylinos.cn>
> > > ---
> > >   fs/btrfs/send.c    | 2 +-
> > >   fs/btrfs/volumes.c | 2 +-
> > >   2 files changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
> > > index e5c963bb873d..af2e153543a5 100644
> > > --- a/fs/btrfs/send.c
> > > +++ b/fs/btrfs/send.c
> > > @@ -1875,7 +1875,7 @@ static int get_cur_inode_state(struct send_ctx =
*sctx, u64 ino, u64 gen,
> > >     int left_ret;
> > >     int right_ret;
> > >     u64 left_gen;
> > > -   u64 right_gen;
> > > +   u64 right_gen =3D 0;
> >
> > IIRC this is not my first time explaining why this is a false alert.
> >
> > Thus please report your compiler version first.
>
> This is probably because of the -Wmaybe-uninitialized we enabled, on
> some combination of architecture and compiler. While I'm also interested
> in the compiler and version we need to fix the warnings before 6.3 final.
> We'd be gettting the warnings and reports/patches, which is wasting
> peoples' time, it's not a big deal to initialize the variables. But
> still I also want to know which version reports that.

aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110 and
aarch64-linux-gnu-gcc (7.3.0-20190804.h30.ky10.aarch64 )

Thanks,

Genjian.