Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 24 Mar 2023 08:17:19 +0300
From:   Dan Carpenter <error27@gmail.com>
To:     Dongliang Mu <dzm91@hust.edu.cn>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Mingxuan Xiang <mx_xiang@hust.edu.cn>,
        Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
        hust-os-kernel-patches@googlegroups.com, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] usb: dwc3: host: remove dead code in
 dwc3_host_get_irq()
Message-ID: <adcd6c67-cedf-4831-9a9d-53c3ee2ebb88@kili.mountain>
References: <20230323095311.1266655-1-mx_xiang@hust.edu.cn>
 <ZBxy9LYz+JyNW6GY@kroah.com>
 <8271c37c-4995-445c-89b7-90848f7ef3cc@hust.edu.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8271c37c-4995-445c-89b7-90848f7ef3cc@hust.edu.cn>
Precedence: bulk

On Fri, Mar 24, 2023 at 09:46:40AM +0800, Dongliang Mu wrote:
> 
> On 2023/3/23 23:40, Greg Kroah-Hartman wrote:
> > On Thu, Mar 23, 2023 at 05:53:10PM +0800, Mingxuan Xiang wrote:
> > > platform_get_irq() no longer returns 0, so there is no
> > > need to check whether the return value is 0.
> > How did you find this issue?
> > 
> > How was it tested?
> 
> Hi Greg,
> 
> We found this issue by Smatch. Our team is trying fix some true bugs found
> by Smatch, with the help of Dan.

LOL.  What did I do to get thrown under the bus like this?

> 
> Since this is a dead code removal, we only do compilation testing.
> 

Just v3 and mention in the commit message that the issue was found by
Smatch and the warning message that Smatch prints.  Put under the ---
cut off line that it has only been compile tested.

Also we needed to send a v3 anyway to remove the {} curly braces.

regards,
dan carpenter