Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp600563rwl; Thu, 23 Mar 2023 22:24:03 -0700 (PDT) X-Google-Smtp-Source: AKy350YzbhydXL9GeUjPBa7kwskTJD2USeH6gj54chp4qNC2x3DKhs6t1r8Vgr9w28lZ6Dqsyg0R X-Received: by 2002:a17:906:a148:b0:92b:ff31:45bc with SMTP id bu8-20020a170906a14800b0092bff3145bcmr1260922ejb.44.1679635442818; Thu, 23 Mar 2023 22:24:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679635442; cv=none; d=google.com; s=arc-20160816; b=PFCwzUjpOTJPV8XIs5sUZP6R1xtjlyA/vPpUQf4IfnPmFi+rS8sq7/Hp14yuhEPtHc Ur+u0V9ZMmiH5OKEuOBSy1xfmcSv0h2QjugkdgX43MkB0k50mudtDyVLlsdcuCl7k9qo 9l1BAh5Q7+VnytAsPypvQvtuhXjcOAyFRCyGpWi8EE27Rw7PXYQnJ2qHme7vddiMTK8S nR7OkGy0865BAkRf8SVbrVGyRNaoGeLKuN63IgZZgNjZdOUoVVHelILd/M4MtPUxWbiG 33JcWcGOwj4KktzPdr1ke1CHxXTzXfPUVoIIklJpTJB8cgUnaOLUMKc7fFAWh5XeOSuc VfQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=YTAhaq5ytV358L4VcK1oscf2Tc7ZdoiPYpWpL7/l6MM=; b=aDPmtlnoPGIsiWA0G9BnZngTWa3ijm7xN9/YIuN5vTxAjUBUevrambfqPkGrP3MiWu YFm33FyTMIUaX0ihGwUs65Q1sfl8v6AEUH8Chzj9AMTKPY/mJWMRTHhiEKm/WKuz/goL jWsRxPxXv4IHgctIkQn2E6zwsSTuoHRJYBiuEKk6+VHP86PyLD+iVDw2fuTQhUjQ2Bi2 jcj4GC3xDmtx1uyhv5Z1IIV2HHW0wYZaymIkrglOvsve4mRLQoVoh9P06iVAmHgcjlPq arVhppKsWp6xG//bVCpNLTteB+tuimd9zDq1TUSeturbPUEX37Y3ysT8upIRUTFS7bGb a5cg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=UvOe+puK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fy32-20020a1709069f2000b00934faf70453si11218231ejc.533.2023.03.23.22.23.38; Thu, 23 Mar 2023 22:24:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=UvOe+puK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231434AbjCXFVC (ORCPT + 99 others); Fri, 24 Mar 2023 01:21:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231222AbjCXFVB (ORCPT ); Fri, 24 Mar 2023 01:21:01 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4D201A48D; Thu, 23 Mar 2023 22:20:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=YTAhaq5ytV358L4VcK1oscf2Tc7ZdoiPYpWpL7/l6MM=; b=UvOe+puKuKDuEPQvHkI0sYJL8t p/iMPytS1f582JKtyEEyxIFVhsggfoHbMjc1pEJWVirwe269swiljNyeSe9dyGE7DzYfTxYLFeV3I YsRP3Df0v4aeksbFBsSidZQ45QxwsCpNimh9b6GADzvViHQeH+FeTbF0EaRNcff5GtRZWgU2UHHXc cCizAN9Xr5jrd1IFNksG/2/ox5OU8OgUpe5KGVF9l4ha1h2+4LkprvjuTyVvLTNjd78SvpN+va4IM 0roeigi3/XzGjnwb0FiXvFEcjxGL4zHUkrP/tZEs6X8rPv/v7SttN8Phelv+5mGXIQQz5oiKF0Lz1 jjix0tSQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pfZr8-004baj-5t; Fri, 24 Mar 2023 05:20:50 +0000 Date: Fri, 24 Mar 2023 05:20:50 +0000 From: Matthew Wilcox To: aloktiagi Cc: viro@zeniv.linux.org.uk, brauner@kernel.org, David.Laight@aculab.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, keescook@chromium.org, hch@infradead.org, Tycho Andersen Subject: Re: [RFC v3 1/3] file: Introduce iterate_fd_locked Message-ID: References: <20230324051526.963702-1-aloktiagi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230324051526.963702-1-aloktiagi@gmail.com> X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 24, 2023 at 05:15:24AM +0000, aloktiagi wrote: > Callers holding the files->file_lock lock can call iterate_fd_locked instead of > iterate_fd You no longer call iterate_fd_locked() in patch 3/3, so this patch can be dropped?