Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp641020rwl; Thu, 23 Mar 2023 23:11:13 -0700 (PDT) X-Google-Smtp-Source: AK7set+9z8Lg/GQVz3U5l98vIA/RViWOcgV509CnvV1i3PtHFS6u3GqGTTWU8jXZ1kOvB9DnyDIO X-Received: by 2002:a17:906:1950:b0:921:54da:831c with SMTP id b16-20020a170906195000b0092154da831cmr8273289eje.31.1679638273295; Thu, 23 Mar 2023 23:11:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679638273; cv=none; d=google.com; s=arc-20160816; b=QOzBTq1I5BGwp1XJXhVCZxGETNcfUWEW0kkCjHS2AXx6vhI4o35J9xCHgPazM5yFVr LnIsthAoySH08sAteNXFT5BNBsDVNdL0/JOA+7shYRwrwGqbKYBwRucKOT/DRzvHRRDH zeYBC+DXIDDPmu4QP1vCvx1pZD/GV7WxjdR6oeYhv9q7jiBGOiCkt3S+By928JS0/beH 0DWW4zGV0tF1CZK6Jc1NFVF2otMWAs2X5TJAilZwkS7LMZOYiPs0M3BwKwuxvEmdI6BW zgDdYlK+D2rVLgCoeMD1jc9EowbFAA5y0dfVYCT0w6Y/VItm/wSuI89y0WxLAbKYlDxh i31Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=N+nHbDgNlg7sUA7QNCABsdxPp+66d6lY+QYGpnTvvxM=; b=ngEFjpo72cZQlv+T2Fx426BDkD2XN9sCgH9ckWYh97t2MvbHyZPvUs+9mdlZb5cwIl 4C66maEBmxfvV8MoE0zindZ0xdBvekfDZoZphF+ZiSd5nkYj5LXXckImNOWeCciWL8r4 G3MMa/GJnrp54R7FphbawlMOHi2LtUZ7K3NuhvolgUNsrHCAD4wWuvzVNTLjxInVGAjR hCMKABMk2At+URXkknRWwath3s2m3WH9hFT6v47d42jv/Ekr6oQcU2oTh3BRY5XCh9hW Mk0YHU/jnRGqgr/uOViNWehvpFlPD1V6vNQJdIUhgWxQntxbz69cLInGp0EuetwvIRv5 6uEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=VVgsI1XF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w14-20020a1709064a0e00b00930943f134esi20204080eju.8.2023.03.23.23.10.49; Thu, 23 Mar 2023 23:11:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=VVgsI1XF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231438AbjCXFwS (ORCPT + 99 others); Fri, 24 Mar 2023 01:52:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229729AbjCXFwR (ORCPT ); Fri, 24 Mar 2023 01:52:17 -0400 Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8944ADBE8; Thu, 23 Mar 2023 22:52:16 -0700 (PDT) Received: by mail-pg1-x52a.google.com with SMTP id 41be03b00d2f7-503e7129074so27623a12.0; Thu, 23 Mar 2023 22:52:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679637136; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=N+nHbDgNlg7sUA7QNCABsdxPp+66d6lY+QYGpnTvvxM=; b=VVgsI1XFwPwPlRwCBkQ4XjJ+m0Jr+l72bCNWn37y+KnHSOJ7jNlT0R23sHTpW7rAg7 pv2aqJlwqxpZYQQ7ZKx0J4fabCfIKv56fQci30ctgHLn611s/nFiQ5R1aZPh7XO/nGp6 mvTuTkkIud+zB6ovsQDyLcnwF2h+1IUIrVdSY/bRERI85meLaIDtn7H5JvVxp2iKNJ91 +Mu33S33l0dut25SWAcjmmXaNmc332xdWfhB7AWo9YpIpcjFW1zfR0YMwda7jNr+/Y14 JxcsIRApSTxLcLB7k8HeCEkkgty5tNAyE0HflC4ccjmULycabhAhqaJQvJxWDrC39Ra6 8veg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679637136; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=N+nHbDgNlg7sUA7QNCABsdxPp+66d6lY+QYGpnTvvxM=; b=YxRSi0XDcUFTObEFPtrI9CH5j9Vl2prr0jrt/rK2GXVv438eeYN8pgRbWYfM8MwhXo z8aoHQ1jEBKYkrPQWNUNyfG1LsjY7HMSi3TUbM8USTUC+xmHuA3cqzSD4AKwe52q6ELH 6+EOGzhj3a+VzfpnxSIoC5E05kBJb+N9vVQBfGDMfBJM+PMvX7p6RfxcI2fyJTM+UFs3 DPhPg9FjU7nJ3LUb0RZJUD8//u/4Gigfv3xL2xPvlsJZ+fA0cidZktbpQqo18dcv6IyP qQgZ9yKwL+5BEKiQzLQQpGW1khPoscbVmAjqWhuSrNQfy6M2l3wz84na2gayq9wViy9F nwsA== X-Gm-Message-State: AAQBX9e2hCodXcJwBhPMzZNj3uXcgc4wVUMMUAZDDr2ZZty1VIwSBGBa abMs+ppM+FuV/2olsevzYls= X-Received: by 2002:a05:6a00:1894:b0:626:62f:38d8 with SMTP id x20-20020a056a00189400b00626062f38d8mr298838pfh.3.1679637135750; Thu, 23 Mar 2023 22:52:15 -0700 (PDT) Received: from ip-172-31-38-16.us-west-2.compute.internal (ec2-52-37-71-140.us-west-2.compute.amazonaws.com. [52.37.71.140]) by smtp.gmail.com with ESMTPSA id k23-20020aa790d7000000b006247123adf1sm13311953pfk.143.2023.03.23.22.52.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Mar 2023 22:52:15 -0700 (PDT) Date: Fri, 24 Mar 2023 05:52:13 +0000 From: Alok Tiagi To: Matthew Wilcox Cc: viro@zeniv.linux.org.uk, brauner@kernel.org, David.Laight@aculab.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, keescook@chromium.org, hch@infradead.org, Tycho Andersen Subject: Re: [RFC v3 1/3] file: Introduce iterate_fd_locked Message-ID: References: <20230324051526.963702-1-aloktiagi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 24, 2023 at 05:20:50AM +0000, Matthew Wilcox wrote: > On Fri, Mar 24, 2023 at 05:15:24AM +0000, aloktiagi wrote: > > Callers holding the files->file_lock lock can call iterate_fd_locked instead of > > iterate_fd > > You no longer call iterate_fd_locked() in patch 3/3, so this patch can > be dropped? yes looks like we won't need this patch and can be dropped. Thank you.