Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <96475152-6add-f359-3cfb-d274f296a713@ti.com>
Date:   Fri, 24 Mar 2023 11:45:47 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [EXTERNAL] Re: [PATCH v2] arm64: defconfig: Enable CAN PHY
 transceiver driver
Content-Language: en-US
To:     Geert Uytterhoeven <geert@linux-m68k.org>,
        Bjorn Andersson <quic_bjorande@quicinc.com>
CC:     <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <catalin.marinas@arm.com>,
        <will@kernel.org>, <dmitry.baryshkov@linaro.org>, <arnd@arndb.de>,
        <krzysztof.kozlowski@linaro.org>, <geert+renesas@glider.be>,
        <nfraprado@collabora.com>, <broonie@kernel.org>, <rafal@milecki.pl>
References: <20230323113324.361991-1-b-kapoor@ti.com>
 <20230323135323.GA309305@hu-bjorande-lv.qualcomm.com>
 <CAMuHMdUF5x=nVMKFFffbbe6S2nGWzq2UZWX36JgyXBGLBVL1rw@mail.gmail.com>
From:   Bhavya Kapoor <b-kapoor@ti.com>
In-Reply-To: <CAMuHMdUF5x=nVMKFFffbbe6S2nGWzq2UZWX36JgyXBGLBVL1rw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 23/03/23 21:39, Geert Uytterhoeven wrote:
> On Thu, Mar 23, 2023 at 2:53 PM Bjorn Andersson
> <quic_bjorande@quicinc.com> wrote:
>> On Thu, Mar 23, 2023 at 05:03:24PM +0530, Bhavya Kapoor wrote:
>>> Enable CAN PHY transceiver driver to be built as a module.
>> Please use the commit message to describe why the driver should be
>> enabled. The patch and the subject already states clearly that the
>> driver is being enabled.
> And if no one has inspiration: I wouldn't mind "because it is needed
> for CAN-FD on the Renesas White-Hawk development board" ;-)

Ahh , i do have the inspiration,lol ????. I just wanted to keep it 
concise. Lemme send a v3 with necessary details.

Thanks.

>
>>> --- a/arch/arm64/configs/defconfig
>>> +++ b/arch/arm64/configs/defconfig
>>> @@ -1292,6 +1292,7 @@ CONFIG_RESET_QCOM_PDC=m
>>>   CONFIG_RESET_RZG2L_USBPHY_CTRL=y
>>>   CONFIG_RESET_TI_SCI=y
>>>   CONFIG_PHY_XGENE=y
>>> +CONFIG_PHY_CAN_TRANSCEIVER=m
>>>   CONFIG_PHY_SUN4I_USB=y
>>>   CONFIG_PHY_CADENCE_TORRENT=m
>>>   CONFIG_PHY_CADENCE_SIERRA=m
> For the actual change:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Gr{oetje,eeting}s,
>
>                          Geert
>