Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 24 Mar 2023 09:20:02 +0300
From:   Dan Carpenter <error27@gmail.com>
To:     Mingxuan Xiang <mx_xiang@hust.edu.cn>
Cc:     Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        hust-os-kernel-patches@googlegroups.com,
        Dongliang Mu <dzm91@hust.edu.cn>, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] usb: dwc3: host: remove dead code in
 dwc3_host_get_irq()
Message-ID: <eb34470f-c86e-4d80-a6a1-811d6cd452b9@kili.mountain>
References: <20230324060934.1686859-1-mx_xiang@hust.edu.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230324060934.1686859-1-mx_xiang@hust.edu.cn>
Precedence: bulk

On Fri, Mar 24, 2023 at 02:09:34PM +0800, Mingxuan Xiang wrote:
> According to the description of platform_get_irq()
>  * Return: non-zero IRQ number on success, 
>  			negative error number on failure.
> and the code, platform_get_irq() will return -EINVAL
> instead of IRQ0.
> 
> So platform_get_irq() no longer returns 0, there is no
> need to check whether the return value is 0.
> 
> Found by Smatch:
> drivers/usb/dwc3/host.c:60 dwc3_host_get_irq() 
> 	warn: platform_get_irq() does not return zero
> 
> Signed-off-by: Mingxuan Xiang <mx_xiang@hust.edu.cn>
> ---
> v2->v3: remove curly braces
> v1->v2: remove redundant goto
> Only compile tested.

Reviewed-by: Dan Carpenter <error27@gmail.com>

regards,
dan carpenter