Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 24 Mar 2023 07:48:35 +0100
From:   Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To:     Nuno =?iso-8859-1?Q?Gon=E7alves?= <nunog@fr24.com>
CC:     =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= <bjorn@kernel.org>,
        Magnus Karlsson <magnus.karlsson@intel.com>,
        Jonathan Lemon <jonathan.lemon@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "Christian Brauner" <brauner@kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        "Daniel Borkmann" <daniel@iogearbox.net>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        John Fastabend <john.fastabend@gmail.com>,
        <netdev@vger.kernel.org>, <bpf@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH bpf-next V3] xsk: allow remap of fill and/or completion
 rings
Message-ID: <ZB1Hw6XZnrDLLNhA@boxer>
References: <20230323210125.10880-1-nunog@fr24.com>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230323210125.10880-1-nunog@fr24.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?kAklK8qlxUA1bOMcQxSgBdvfGV5ufdEBdDD4747l9REOMoL9xRuxd1D7kS?=
 =?iso-8859-1?Q?dfJhZq4X3DMVxe72FmkWahc/wPoRuLwPdHJ1yk2UiEPQwxW2lXZt0pH6Up?=
 =?iso-8859-1?Q?Kv2btRT1C13snA719/WY4/ujSKSXgP/W4Dw3hir+gm79XaH/RJPNeSjpTt?=
 =?iso-8859-1?Q?+u0H21WcfYCJTFUeYfc33ZmU4I9tCMFx1YOypdYgVQPJp5paQhjwyZvpu+?=
 =?iso-8859-1?Q?WyqGf12sU2n8i0PVVXqJULIE0TWJuscjlYfoTmWyTFzsISO/BDiY+ZfW7l?=
 =?iso-8859-1?Q?t/8AzwPXhAHxPPvgWSxyZQnRdRQW9J5XzLCUj6E5hDApwLZ2GnNO769myv?=
 =?iso-8859-1?Q?x70KAHi6umKi7QMQwQTUNfP8Bgcgxi8M9cWbLNjSl4IryyCzeo26GTBLu1?=
 =?iso-8859-1?Q?xfDYyhPsfja2bHedKxE98O0Y4uXM5cXV0C+qEFEa89a7f5GgJG0NNGksNI?=
 =?iso-8859-1?Q?poWg5uyy1PbR66HFmDL01iVH8jkGOeWEkaryH7NTcdD7rfEWMWYzypSKwJ?=
 =?iso-8859-1?Q?vcyhyNSc6tnFzp3Uw+ogCgE5QzyalTEWkPXOuaaKsUEuKeBuhelZZBlNGt?=
 =?iso-8859-1?Q?7bXB4iMTShuJRDjiLul+zev3fwSsh5BI9abkIKgMSsiPgwGL6/zgHBwVSx?=
 =?iso-8859-1?Q?63BrFTujV1DnbGF8u2721m+OsfMDgMStLN4qj08RiAjcpjV0feZpk7pZie?=
 =?iso-8859-1?Q?JXGSpTpsIxAvaLv01BXIPtedpgjFulmQ1g5lKqKy0hi5f6eDD+vpivs939?=
 =?iso-8859-1?Q?tqLpaT5Tch8lXA/aaYFFji6seoL3gGs8O5EHYyovwoBcR/QhgL/MQewg4b?=
 =?iso-8859-1?Q?yODn1/F7p3kfvmpqveYA4EVIjjUEoDbKkZ+n1BlV5mFe7gr4PAItRPV38G?=
 =?iso-8859-1?Q?SuhezLHGrg1TkS8GwHLYli2gXaAi2taSD6YDOqJzelvFTVuajtm5zG8Ze9?=
 =?iso-8859-1?Q?JMOQ/CeEuPH0UYYnRYSbKX6fOQ9O24tI8xISDO9uFA/5rWkVY+p8u+DCZI?=
 =?iso-8859-1?Q?YV6+4cLuJgopZHk5Yb0YvR+LusNg+l3uSK4KRQdm30lv3IP5celiK9ubE+?=
 =?iso-8859-1?Q?r2a+nT0WgYX6z9SzGL9ML/j7u7aLrDTJJ6Lp8nskgxVTQSQ70opCDhipnK?=
 =?iso-8859-1?Q?ZhtYoS4OPQOjDCT2aE3y+lpZfolMAavf9iIboUszaUz+HK2OGDHJNvyKJk?=
 =?iso-8859-1?Q?nY/CW//68E9zVdGciQOsvm01ooa/31YD0DC9aM5YX5D9nisFvJxcV+FN0W?=
 =?iso-8859-1?Q?wJXkmI3CeMR/8fTBCSqw/MS+ZPgAzw+X02VSfYrWUvE+thCmoG6+MphHDw?=
 =?iso-8859-1?Q?DzjKX7Nn/qn3qijiaeFLue5k8R+JssaOIK4jVOt+Q7gXsrR0rkDsSIR/oi?=
 =?iso-8859-1?Q?C/SEY9k6tMx7zCdrLIcmq9ytbGTQyW7WnIOfQQdvJvrd8UNCwiOIYdPNI2?=
 =?iso-8859-1?Q?OZH0QAzLZ/O9DaV6L4BQmIcbF+mkoK84jtp723lThXSYyD0AbWwRVlH4s+?=
 =?iso-8859-1?Q?ztc1zqxHy32fCKaQfrl22N4E28LVzy33ijG1PXBpNSxqhxZOGtvlKFdBtT?=
 =?iso-8859-1?Q?rDbBWIGYe9O/dkcFqfYOlzwKgStlz7WhNzbXzH+NOY0IQtznt9NAFJ8k4W?=
 =?iso-8859-1?Q?6rxIx7VLWF+Gd/jt2j6vZf7rVg7iDhbKGtu0x9Iobsm0oOa+t81znU7Dsr?=
 =?iso-8859-1?Q?ZbQu+y6RGxWRloNUQNE=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8d36c5e8-1c3b-4f15-fd81-08db2c33cee0
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6097.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2023 06:48:43.0425
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QFS/O+b0QKSedWvw+ON8E7BJX8XJocbgwLpOr7C695opWPkX0Y2WpBhbaM95c4jShahtIxlcq3fHEz0hjoAjF+Wd0fgRnbAejTWloLOa458=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6736
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 23, 2023 at 09:01:24PM +0000, Nuno Gon?alves wrote:
> The remap of fill and completion rings was frowned upon as they
> control the usage of UMEM which does not support concurrent use.
> At the same time this would disallow the remap of these rings
> into another process.
> 
> A possible use case is that the user wants to transfer the socket/
> UMEM ownership to another process (via SYS_pidfd_getfd) and so
> would need to also remap these rings.
> 
> This will have no impact on current usages and just relaxes the
> remap limitation.
> 
> Signed-off-by: Nuno Gon?alves <nunog@fr24.com>
> ---
>  net/xdp/xsk.c | 166 +++++++++++++++++++++++++-------------------------
>  1 file changed, 84 insertions(+), 82 deletions(-)

Interesting, 166 lines touched whereas v2 was about only 9 :) Please make
yourself familiar with Documentation/process/submitting-patches.rst.

Tell us what are the differences between your patch revisions, e.g. how
did you fix the build error that Daniel reported.

Don't include irrevelant changes such as style fixes to this patch.