Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230323204427.3594372-1-maskray@google.com> <202303241443.0sSziFDY-lkp@intel.com>
In-Reply-To: <202303241443.0sSziFDY-lkp@intel.com>
From:   Fangrui Song <maskray@google.com>
Date:   Fri, 24 Mar 2023 00:31:54 -0700
Message-ID: <CAFP8O3+J47WNj76hK4tZad4wJJpZZjT28OBbRBkiYcaCVhJxMQ@mail.gmail.com>
Subject: Re: [PATCH] Makefile: use -z pack-relative-relocs
To:     kernel test robot <lkp@intel.com>
Cc:     Masahiro Yamada <masahiroy@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        linux-kbuild@vger.kernel.org, oe-kbuild-all@lists.linux.dev,
        linux-kernel@vger.kernel.org, Peter Collingbourne <pcc@google.com>,
        Will Deacon <will@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Mar 23, 2023 at 11:51=E2=80=AFPM kernel test robot <lkp@intel.com> =
wrote:
>
> Hi Fangrui,
>
> Thank you for the patch! Perhaps something to improve:
>
> [auto build test WARNING on masahiroy-kbuild/for-next]
> [also build test WARNING on masahiroy-kbuild/fixes linus/master v6.3-rc3 =
next-20230323]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url:    https://github.com/intel-lab-lkp/linux/commits/Fangrui-Song/Makef=
ile-use-z-pack-relative-relocs/20230324-044515
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-k=
build.git for-next
> patch link:    https://lore.kernel.org/r/20230323204427.3594372-1-maskray=
%40google.com
> patch subject: [PATCH] Makefile: use -z pack-relative-relocs
> config: arm64-randconfig-r022-20230322 (https://download.01.org/0day-ci/a=
rchive/20230324/202303241443.0sSziFDY-lkp@intel.com/config)
> compiler: aarch64-linux-gcc (GCC) 12.1.0
> reproduce (this is a W=3D1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbi=
n/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://github.com/intel-lab-lkp/linux/commit/8f47a36faf182f96a=
2bbf4d3b9305fe9a90c5cde
>         git remote add linux-review https://github.com/intel-lab-lkp/linu=
x
>         git fetch --no-tags linux-review Fangrui-Song/Makefile-use-z-pack=
-relative-relocs/20230324-044515
>         git checkout 8f47a36faf182f96a2bbf4d3b9305fe9a90c5cde
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-12.1.0 make.cro=
ss W=3D1 O=3Dbuild_dir ARCH=3Darm64 olddefconfig
>         COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-12.1.0 make.cro=
ss W=3D1 O=3Dbuild_dir ARCH=3Darm64 SHELL=3D/bin/bash
>
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@intel.com>
> | Link: https://lore.kernel.org/oe-kbuild-all/202303241443.0sSziFDY-lkp@i=
ntel.com/
>
> All warnings (new ones prefixed by >>):
>
> >> aarch64-linux-ld: warning: -z pack-relative-relocs ignored
> >> aarch64-linux-ld: warning: -z pack-relative-relocs ignored
> >> aarch64-linux-ld: warning: -z pack-relative-relocs ignored
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests

I forgot to check aarch64-linux-gnu-ld. To address the issue I can use:

# ld.lld before 15 did not support -z pack-relative-relocs.
if ! $LD $tmp_file.o -shared -Bsymbolic --pack-dyn-relocs=3Drelr -o
$tmp_file 2>/dev/null; then
        $LD $tmp_file.o -shared -Bsymbolic -z pack-relative-relocs -o
$tmp_file 2>&1 |
                grep -q pack-relative-relocs && exit 1
fi


--=20
=E5=AE=8B=E6=96=B9=E7=9D=BF