Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 24 Mar 2023 15:45:49 +0800
From:   Chester Lin <clin@suse.com>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        NXP S32 Linux Team <s32@nxp.com>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        Ghennadi Procopciuc <Ghennadi.Procopciuc@oss.nxp.com>,
        Andrei Stefanescu <andrei.stefanescu@nxp.com>,
        Radu Pirea <radu-nicolae.pirea@nxp.com>,
        Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>,
        Matthias Brugger <mbrugger@suse.com>
Subject: Re: [PATCH v3 6/6] pinctrl: s32: separate const device data from
 struct s32_pinctrl_soc_info
Message-ID: <ZB1VLbvTudD2Ye5C@linux-8mug>
References: <20230323144833.28562-1-clin@suse.com>
 <20230323144833.28562-7-clin@suse.com>
 <CAHp75VfnVzrVLUpXdspw1H-e4qxVzia+hf_2uJ5xgSm6Q0C7ug@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAHp75VfnVzrVLUpXdspw1H-e4qxVzia+hf_2uJ5xgSm6Q0C7ug@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UkJzQjdzbkxFdkdncFJFV1hXZFMxekVlMnNiSTJoVmQwRkg4VUI5a0tVcWll?=
 =?utf-8?B?c1VLL3JzZHVYQVRYZ1JEMHNMQmIxanA0RHFyMTNST0xvTkwzc0Q4WWhHbUxr?=
 =?utf-8?B?QUV6czVVVFBkOHk0YWFET0VoSVhWSXhNR3hZYXR5aHo0dDRHc01qSXZrZlRu?=
 =?utf-8?B?MmJiM05lTEtoMmNBNnFHZFhWU3lUeDNPa2pXZVpqUzdScGx1dERzVEt1eGhh?=
 =?utf-8?B?enhTWFRWS09xa2tZMlZ5cVNvYnE3NlpKU0E0TUxrNlBiZmdUd1RyRmg4em0r?=
 =?utf-8?B?NlpYL1JjZnduUittRTFZZlBoZndnT1Z0bFlUVnRnd0tRYUdDczJwbTRPZjJC?=
 =?utf-8?B?dnZzVGtlVXVBYzJmNGhvMDhCVVRpNDNWNlFFRFBaSzRkTzRLb0d1SFY5S1l3?=
 =?utf-8?B?VnlHUHc1UElVWWZnMlNEMS84NkloOVhjNmtkdTdNMVlFWWpjTmw5aTBFb1ZU?=
 =?utf-8?B?Z0NpVklNVUJCRHBZM3Q3WHFQN2MxNW04ZWZ1Z3krQmZocEFQYVZkMDBEaVYv?=
 =?utf-8?B?SzdjUndGMkxwcTRXNGVPTDNQQmtGM1VSMStxRGtlaFRWR056dFFYNTRmUkpv?=
 =?utf-8?B?LzFUOFpFdjdQTDFsMFBxRW1OZEtkc3lzeDltV1JremxrVnpUOXN0QTdVcGxv?=
 =?utf-8?B?dmV3TXpnM25HaU1XM2JLdU95UW1rR2hJbVVQVkJQdXlHeXFvMUJ0UmxkVUVN?=
 =?utf-8?B?WldKU1ZyZ2xwLzlaQTA3Rml2V05wL2pDUHdONHBPV1hIUDY4c1plVG8ycU1V?=
 =?utf-8?B?SG1KOVg2ZFFOTUhJNEF3WnVaNHlCVXQ2SDdmL2NVTFdFYlZQdkJ0RlQ4U3pR?=
 =?utf-8?B?MEd3REpvZ3h3dTBQeUlqMXM2NldJb3NQOG96VU5RQ2NmbFdMZ1oxWVplcFpF?=
 =?utf-8?B?L0EwTEEwL3EzUGNXZEZ0WDVncTF2L2NtR0pDS1lOWFZ5dTdWODBCSldzZi9z?=
 =?utf-8?B?L1lqellYNGtHN1Y4d3hCVG5HMHZQbXFtbUtWYlN6WGFyWGJSSHBFT0JLNmZT?=
 =?utf-8?B?OXd0SXRZT0NYV1N2ckRWWTBsdm1OSnlLOTJwNFNRQ0JUYVdDQkZOKzE3VTBr?=
 =?utf-8?B?Vi9IN2JpcGJoRmcyRTZEMUlqMXdTQWdqOGNqREJ3ckdMZ3VVdWU0dlFvd0E1?=
 =?utf-8?B?UHhYMDlkSzlmZFBDTG5FdHh2dDdwYko0aDdBSUhNVmVveDh2NHFRRHNzQmg1?=
 =?utf-8?B?ekhiK1ZBcGdsQ3dYWGpOYlFXQjRSMmxuQ3RjV1lMUHRyYXRyUnJVZzBUbENH?=
 =?utf-8?B?c1VTZ3NoSzVKdGVUeEhFV01MSE5zNE40YmxZRy9nV01sVkpDZGJpZzREd2No?=
 =?utf-8?B?eVZxV0pBYm9CcVRVOWduL0RMWW1XYUpCZm1yZ3RSOXJadXNvMlZEY3RqWTBV?=
 =?utf-8?B?UmxsRUhHMGxwbmVpN29aUkNOZjRHNGpSclhTcko3Z2xvc0lMQlR5NE1ocFRx?=
 =?utf-8?B?SmE5WFR0aXd3UU8vSnBiSThDL2tLQWlpOWdCaWJiRnpzRk5QdXlVYTRUYThG?=
 =?utf-8?B?Rm5kdHRCUlF0TXhQRU9mMkg3MTQ4eEFMVXVxbk96aDFVYTZjMUlVQmMwWE02?=
 =?utf-8?B?c1pLakdPWlJVcDhVamVDekRqTHprdEVjZUhxbjdPeTkwemZGOU5iemx5S1JE?=
 =?utf-8?B?dHdUY2thenZydVVFSEd6VDUwWTltQzZJcTRqNWpQOTlTa3Nlc3pCK2hTRmtV?=
 =?utf-8?B?RUFCU010NG5FMXBndGQ2WFJTdk42WERZcjJDbVBNeDhydFV5QnkyNkVlaitO?=
 =?utf-8?B?U0xUSFZqVGloMmhPNCtlWld3RnR1MVFLaTdPZUc5WCtLSURVN1V1T2ZnUWJM?=
 =?utf-8?B?R1AwejY3aHJrSmYzc0dMQjE3R1VxL293VXR6WmN3WjN5TmJ3YlIxYjJscHY2?=
 =?utf-8?B?ejVCcForaTdqbVJzR1BId3R2cGNGK3NZSm45ZWgrb1dBZ3JpYnhtc2F3R2tL?=
 =?utf-8?B?SDlhSWZUS3FZRlpTTlljcWFCcVFzTENpclBwQXM0YUphSFpsQ2xnK1ByWTU4?=
 =?utf-8?B?VTVPMmRBY2taeitPczhPclhpS2haRmQ4VUdXbzgxQU5BRCtWdHNld1NUS1kz?=
 =?utf-8?B?VmwxSmFJbGhLTm5PWmpLK2tISlB0ZWxzcy9nZjJXdm1OQ0J6Wlh1OFdGRjEx?=
 =?utf-8?Q?9o44=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a05d1d4e-515f-473e-eafd-08db2c3bd0ce
X-MS-Exchange-CrossTenant-AuthSource: VI1PR0402MB3439.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2023 07:46:02.3627
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Sq7XLJdO6IimL06LFzrmYlyCq4175CdZ+Sa+JNhUcxHSEJUGf0OBE2xMfkulXIaM
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7863
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS autolearn=unavailable autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Andy,

Thanks for reviewing this patch!

On Thu, Mar 23, 2023 at 08:50:41PM +0200, Andy Shevchenko wrote:
> On Thu, Mar 23, 2023 at 4:49 PM Chester Lin <clin@suse.com> wrote:
> >
> > The .data field in struct of_device_id is used as a const member so it's
> > inappropriate to attach struct s32_pinctrl_soc_info with of_device_id
> > because some members in s32_pinctrl_soc_info need to be filled by
> > pinctrl-s32cc at runtime.
> >
> > For this reason, struct s32_pinctrl_soc_info must be allocated in
> > pinctrl-s32cc and then create a new struct s32_pinctrl_soc_data in order
> > to represent const .data in of_device_id. To combine these two structures,
> > a s32_pinctrl_soc_data pointer is introduced in s32_pinctrl_soc_info.
> 
> So, the first patch has to be embedded in this one, correct?

Correct. Leave the first patch alone will cause a compiler warning.

> Don't forget to compile and test your contributions beforehand.

Will do.

Regards,
Chester

> 
> -- 
> With Best Regards,
> Andy Shevchenko