Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d4c133c1-38c7-93e3-deaf-b55161057409@quicinc.com>
Date:   Fri, 24 Mar 2023 16:25:16 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH v3 01/11] dt-bindings: arm: Add support for DSB element
 size
To:     Suzuki K Poulose <suzuki.poulose@arm.com>,
        Mathieu Poirier <mathieu.poirier@linaro.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Konrad Dybcio <konradybcio@gmail.com>,
        Mike Leach <mike.leach@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
CC:     Jinlong Mao <quic_jinlmao@quicinc.com>,
        Leo Yan <leo.yan@linaro.org>,
        "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
        <coresight@lists.linaro.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
        Tingwei Zhang <quic_tingweiz@quicinc.com>,
        Yuanfang Zhang <quic_yuanfang@quicinc.com>,
        Trilok Soni <quic_tsoni@quicinc.com>,
        Hao Zhang <quic_hazha@quicinc.com>,
        <linux-arm-msm@vger.kernel.org>,
        Bjorn Andersson <andersson@kernel.org>
References: <1679551448-19160-1-git-send-email-quic_taozha@quicinc.com>
 <1679551448-19160-2-git-send-email-quic_taozha@quicinc.com>
 <e6ad7301-09ea-93e0-929e-86e0eb0a02e7@arm.com>
Content-Language: en-US
From:   Tao Zhang <quic_taozha@quicinc.com>
In-Reply-To: <e6ad7301-09ea-93e0-929e-86e0eb0a02e7@arm.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Suzuki,

在 3/23/2023 7:18 PM, Suzuki K Poulose 写道:
> On 23/03/2023 06:03, Tao Zhang wrote:
>> Add property "qcom,dsb-elem-size" to support DSB(Discrete Single
>> Bit) element for TPDM. The associated aggregator will read this
>> size before it is enabled. DSB element size currently only
>> supports 32-bit and 64-bit.
>>
>> Signed-off-by: Tao Zhang <quic_taozha@quicinc.com>
>> ---
>>   .../devicetree/bindings/arm/qcom,coresight-tpdm.yaml | 11 +++++++++++
>>   1 file changed, 11 insertions(+)
>>
>> diff --git 
>> a/Documentation/devicetree/bindings/arm/qcom,coresight-tpdm.yaml 
>> b/Documentation/devicetree/bindings/arm/qcom,coresight-tpdm.yaml
>> index 5c08342..d9b6b613 100644
>> --- a/Documentation/devicetree/bindings/arm/qcom,coresight-tpdm.yaml
>> +++ b/Documentation/devicetree/bindings/arm/qcom,coresight-tpdm.yaml
>> @@ -44,6 +44,15 @@ properties:
>>       minItems: 1
>>       maxItems: 2
>
>
>>   +  qcom,dsb-element-size:
>> +    description:
>> +      Specifies the DSB(Discrete Single Bit) element size supported by
>> +      the monitor. The associated aggregator will read this size 
>> before it
>> +      is enabled. DSB element size currently only supports 32-bit 
>> and 64-bit.
>> +    $ref: /schemas/types.yaml#/definitions/uint32
>> +    minimum: 32
>> +    maximum: 64
>
> Shouldn't this be something like oneOf ? It is not a range, but one of
> those two specific values ?

Yes, "qcom,dsb-element-size" should be an optional option required in TPDM

devicetree. Other properties like "qcom,cmb-element-size", 
"qcom,tc-element-size"

and etc. will be added in a later patch series.

I will update this doc according to your advice in the next version of 
the patch.

Tao

>
> Suzuki
>
>