Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <5b7c473247d66776343d82a55b9815195b1b11fb.1679551394.git.fthain@linux-m68k.org>
 <mvmttybx3ng.fsf@linux-m68k.org> <CAMuHMdUQ3+OUKZ-6DqcJfMgq8_90Cejzc=onhUmbaYTWJkZHRw@mail.gmail.com>
 <c882ca59-e75d-7ca2-d63f-70aab1b46ade@linux-m68k.org>
In-Reply-To: <c882ca59-e75d-7ca2-d63f-70aab1b46ade@linux-m68k.org>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Fri, 24 Mar 2023 09:26:23 +0100
Message-ID: <CAMuHMdVSvPk8wYZKVKX_xW_VSHu2qMoX-N4ePRJHejw2nh9JKg@mail.gmail.com>
Subject: Re: [PATCH v2] nubus: Don't list card resources by default
To:     Finn Thain <fthain@linux-m68k.org>
Cc:     Andreas Schwab <schwab@linux-m68k.org>,
        linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

Hi Finn,

On Fri, Mar 24, 2023 at 1:05 AM Finn Thain <fthain@linux-m68k.org> wrote:
> On Thu, 23 Mar 2023, Geert Uytterhoeven wrote:
> > On Thu, Mar 23, 2023 at 9:39 AM Andreas Schwab <schwab@linux-m68k.org> wrote:
> > > On Mär 23 2023, Finn Thain wrote:
> > > > Checkpatch says "externs should be avoided in .c files" and if this one
> > > > appeared twice I would agree. But as it only appears once, I can't see
> > > > any advantage to putting it in a new .h file instead of the .c file...
> > >
> > > Anything wrong with declaring it in <linux/nubus.h>?
> >
> > It's not meant for NuBus device drivers (at least in its current form).
> > So a drivers/nubus/nubus.h would be the most logical place.
>
> I think Andreas is right inasmuchas the existing prototypes shared between
> drivers/nubus/nubus.c and drivers/nubus/proc.c are found there, and this
> extern is another one of those.
>
> But I take Geert's point that much of include/linux/nubus.h could be moved
> to drivers/nubus/something.h. But is there anything to be gained from
> splitting it up that way?

Splitting it would prevent NuBus device drivers from messing with
internal NuBus variables they're not intended to access.
But I agree that's not a big concern...

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds