Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp776918rwl; Fri, 24 Mar 2023 01:38:22 -0700 (PDT) X-Google-Smtp-Source: AKy350YjGKpgakZGPvBPGMKBiCpU8iAuwsABriGlJ37rbBIa4bwZjgXNGcYcqhxahufHzH0p5F4n X-Received: by 2002:a17:903:2347:b0:1a0:50bd:31c0 with SMTP id c7-20020a170903234700b001a050bd31c0mr2241176plh.24.1679647102633; Fri, 24 Mar 2023 01:38:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679647102; cv=none; d=google.com; s=arc-20160816; b=N5XUlVzcXsnf3upPO0uO/DrVNXuprSiUpmj6A/zs8PiC1RZv72eks6NhiRt8WYRbZX mcFnG36Ng8g/lWXm5bJaUiEgI3P3Edz7HcW7tR9Z1K3Jo2Zqu1l6egUJ8cuKX8/BsS7a O3wNBDA+Uv3O4HVjEijyMdBDF5zEKKfdVkjs1ETVd3pnoa56lbXEYYw6yxPTC8PcCqt1 E2Baxz5UlNquecBhBIYNoOpE3DRfyaNmAWjhbNFutvZVfKpEUxkLzkZnCYmKAcTKlNaD HwQLVE8YZCJzjnnuXfdp+fOBppPGRqfjFUMYkPfax6a0Nrk3B7LGWBYQf+v5tPmSY9mu l6Jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=zlO8vIxk/v/7h+JUeiO6J20xzFvMff7zL1SzTAQ6yJo=; b=j+3d2brHeyiZQOaFQ1HvbfkG1RlR1QfQU2etD/3+5EaIGRQPpIPPHYPmrxVeyeGgCr e274LsihcyIwBX/n04qgLB7EoRGc4yMPOPZ7W156E+kZJy8GcRjGfy3Mi/pLjcbOOEwe yfbdhSyTJHZbj0UcmbNJDGgdmoK6E9FZkenUfVe/FRTYZ+VZEQ/MXXJh/ZkXkd+WQNxx CEle8sPv2OTJ9iWNj6C1J1aVpGJAd7QUB5YP5na8m2UblIwhcpkQb4ZJxmKE/+oFeRkk zzhoanoAP6NL9ZmHkwYYk0tVPFC9+6U2rjjz8uIKG9/KsXI4XHsFtvvpnqD1nNcdpzp6 izAA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="GK/SDvZc"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k10-20020a170902c40a00b001a1b6562148si4710300plk.96.2023.03.24.01.37.38; Fri, 24 Mar 2023 01:38:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="GK/SDvZc"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231582AbjCXIcW (ORCPT + 99 others); Fri, 24 Mar 2023 04:32:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229508AbjCXIcU (ORCPT ); Fri, 24 Mar 2023 04:32:20 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7871412853 for ; Fri, 24 Mar 2023 01:31:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679646695; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zlO8vIxk/v/7h+JUeiO6J20xzFvMff7zL1SzTAQ6yJo=; b=GK/SDvZc7aSzTR3bfMzCpU3ZkmRYZhs/Q/Mz9vgFfllEufPdLVrNPDqEHbm9VH/yoeTE1t ixTKC8eaj+avaILBFhJhC2rEmFW4ap1SuTMydSIVWZipoIekYw7ZhLqHIxBYvBhymDwciw UfViK2piUgNVlzG33Vx0IteAWIubJPA= Received: from mail-yw1-f197.google.com (mail-yw1-f197.google.com [209.85.128.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-177-MvYpiCPxPWmzpZJvvOyazw-1; Fri, 24 Mar 2023 04:31:34 -0400 X-MC-Unique: MvYpiCPxPWmzpZJvvOyazw-1 Received: by mail-yw1-f197.google.com with SMTP id 00721157ae682-536a5a0b6e3so12126527b3.10 for ; Fri, 24 Mar 2023 01:31:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679646693; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zlO8vIxk/v/7h+JUeiO6J20xzFvMff7zL1SzTAQ6yJo=; b=TyJIZWfKziz9KpeBrHzJ7n9hu+1sfeAVNIA4KfEyadhs8Og+hJ0sgQDH2oq+bpQOD9 dM7UbwAKWtPTsbckjQpbBf2v9+kQj1IApCvlRvFH+bOk5Ysb/lMhDg/WRDrvFRR582zn dtKPDrIo2YsfPedasEONoSzrbu7R5tT1fgratJrggv1se1D7o/uMTbe0ECthXSi6qAoS Km976c47J6QVokmyFhXRGmkw6R7uzJmP+iiTTcdf5Dr05pUUcTXaELCpp/V0s5VZ+MWs w4EvP2RbsycgQD5l/uG9+KmzuqoqqsWAlAwks7/yApsWAjuAsSkICtH5GNFTaO063N5c JyqQ== X-Gm-Message-State: AAQBX9dflBsWDCfxmjt0WCLZbeoFLEP+O86XVVdwNls4exMbxy95BxKX aKJ6zJpU5JnP3JJZPTZYmghUYeFlMSkvk5xOi28+QME13qpo6+nd8sHe8YqnhTN1eHMzBz0PyRU t/g0PrVk1e0MuZsjmV/RHgK4oDPljIJOGJ5+J3ra4 X-Received: by 2002:a25:b909:0:b0:b39:b0d3:9a7f with SMTP id x9-20020a25b909000000b00b39b0d39a7fmr662627ybj.7.1679646693231; Fri, 24 Mar 2023 01:31:33 -0700 (PDT) X-Received: by 2002:a25:b909:0:b0:b39:b0d3:9a7f with SMTP id x9-20020a25b909000000b00b39b0d39a7fmr662615ybj.7.1679646692854; Fri, 24 Mar 2023 01:31:32 -0700 (PDT) MIME-Version: 1.0 References: <000000000000708b1005f79acf5c@google.com> In-Reply-To: <000000000000708b1005f79acf5c@google.com> From: Stefano Garzarella Date: Fri, 24 Mar 2023 09:31:20 +0100 Message-ID: Subject: Re: [syzbot] [kvm?] [net?] [virt?] general protection fault in virtio_transport_purge_skbs To: Bobby Eshleman , Bobby Eshleman Cc: syzbot , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, pabeni@redhat.com, stefanha@redhat.com, syzkaller-bugs@googlegroups.com, virtualization@lists.linux-foundation.org, Krasnov Arseniy , Krasnov Arseniy Vladimirovich Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bobby, can you take a look at this report? It seems related to the changes we made to support skbuff. Thanks, Stefano On Fri, Mar 24, 2023 at 1:52=E2=80=AFAM syzbot wrote: > > Hello, > > syzbot found the following issue on: > > HEAD commit: fff5a5e7f528 Merge tag 'for-linus' of git://git.armlinux.= o.. > git tree: upstream > console+strace: https://syzkaller.appspot.com/x/log.txt?x=3D1136e97ac8000= 0 > kernel config: https://syzkaller.appspot.com/x/.config?x=3Daaa4b45720ca0= 519 > dashboard link: https://syzkaller.appspot.com/bug?extid=3Dbefff0a9536049e= 7902e > compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binuti= ls for Debian) 2.35.2 > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=3D14365781c80= 000 > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=3D12eebc66c8000= 0 > > Downloadable assets: > disk image: https://storage.googleapis.com/syzbot-assets/997791f5f9e1/dis= k-fff5a5e7.raw.xz > vmlinux: https://storage.googleapis.com/syzbot-assets/0b0155b5eac1/vmlinu= x-fff5a5e7.xz > kernel image: https://storage.googleapis.com/syzbot-assets/8d98dd2ba6b6/b= zImage-fff5a5e7.xz > > IMPORTANT: if you fix the issue, please add the following tag to the comm= it: > Reported-by: syzbot+befff0a9536049e7902e@syzkaller.appspotmail.com > > general protection fault, probably for non-canonical address 0xdffffc0000= 000000: 0000 [#1] PREEMPT SMP KASAN > KASAN: null-ptr-deref in range [0x0000000000000000-0x0000000000000007] > CPU: 0 PID: 8759 Comm: syz-executor379 Not tainted 6.3.0-rc3-syzkaller-00= 026-gfff5a5e7f528 #0 > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS G= oogle 03/02/2023 > RIP: 0010:virtio_transport_purge_skbs+0x139/0x4c0 net/vmw_vsock/virtio_tr= ansport_common.c:1370 > Code: 00 00 00 00 fc ff df 48 89 c2 48 89 44 24 28 48 c1 ea 03 48 8d 04 1= a 48 89 44 24 10 eb 29 e8 ee 27 a3 f7 48 89 e8 48 c1 e8 03 <80> 3c 18 00 0f= 85 a6 02 00 00 49 39 ec 48 8b 55 00 49 89 ef 0f 84 > RSP: 0018:ffffc90006427b48 EFLAGS: 00010256 > RAX: 0000000000000000 RBX: dffffc0000000000 RCX: 0000000000000000 > RDX: ffff8880211157c0 RSI: ffffffff89dfbd12 RDI: ffff88802c11a018 > RBP: 0000000000000000 R08: 0000000000000001 R09: 0000000000000003 > R10: fffff52000c84f5b R11: 0000000000000000 R12: ffffffff92179188 > R13: ffffc90006427ba0 R14: ffff88801e0f1100 R15: ffff88802c11a000 > FS: 00007f01fdd51700(0000) GS:ffff8880b9800000(0000) knlGS:0000000000000= 000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 00007f01fdd30718 CR3: 000000002a3f9000 CR4: 0000000000350ef0 > Call Trace: > > vsock_loopback_cancel_pkt+0x1c/0x20 net/vmw_vsock/vsock_loopback.c:48 > vsock_transport_cancel_pkt net/vmw_vsock/af_vsock.c:1284 [inline] > vsock_connect+0x852/0xcc0 net/vmw_vsock/af_vsock.c:1426 > __sys_connect_file+0x153/0x1a0 net/socket.c:2001 > __sys_connect+0x165/0x1a0 net/socket.c:2018 > __do_sys_connect net/socket.c:2028 [inline] > __se_sys_connect net/socket.c:2025 [inline] > __x64_sys_connect+0x73/0xb0 net/socket.c:2025 > do_syscall_x64 arch/x86/entry/common.c:50 [inline] > do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 > entry_SYSCALL_64_after_hwframe+0x63/0xcd > RIP: 0033:0x7f01fdda0159 > Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 41 15 00 00 90 48 89 f8 48 89 f= 7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff= ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 > RSP: 002b:00007f01fdd51308 EFLAGS: 00000246 ORIG_RAX: 000000000000002a > RAX: ffffffffffffffda RBX: 00007f01fde28428 RCX: 00007f01fdda0159 > RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000004 > RBP: 00007f01fde28420 R08: 0000000000000000 R09: 0000000000000000 > R10: 0000000000000000 R11: 0000000000000246 R12: 00007f01fddf606c > R13: 0000000000000000 R14: 00007f01fdd51400 R15: 0000000000022000 > > Modules linked in: > ---[ end trace 0000000000000000 ]--- > RIP: 0010:virtio_transport_purge_skbs+0x139/0x4c0 net/vmw_vsock/virtio_tr= ansport_common.c:1370 > Code: 00 00 00 00 fc ff df 48 89 c2 48 89 44 24 28 48 c1 ea 03 48 8d 04 1= a 48 89 44 24 10 eb 29 e8 ee 27 a3 f7 48 89 e8 48 c1 e8 03 <80> 3c 18 00 0f= 85 a6 02 00 00 49 39 ec 48 8b 55 00 49 89 ef 0f 84 > RSP: 0018:ffffc90006427b48 EFLAGS: 00010256 > RAX: 0000000000000000 RBX: dffffc0000000000 RCX: 0000000000000000 > RDX: ffff8880211157c0 RSI: ffffffff89dfbd12 RDI: ffff88802c11a018 > RBP: 0000000000000000 R08: 0000000000000001 R09: 0000000000000003 > R10: fffff52000c84f5b R11: 0000000000000000 R12: ffffffff92179188 > R13: ffffc90006427ba0 R14: ffff88801e0f1100 R15: ffff88802c11a000 > FS: 00007f01fdd51700(0000) GS:ffff8880b9800000(0000) knlGS:0000000000000= 000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 00007f01fdd30718 CR3: 000000002a3f9000 CR4: 0000000000350ef0 > ---------------- > Code disassembly (best guess), 6 bytes skipped: > 0: df 48 89 fisttps -0x77(%rax) > 3: c2 48 89 retq $0x8948 > 6: 44 24 28 rex.R and $0x28,%al > 9: 48 c1 ea 03 shr $0x3,%rdx > d: 48 8d 04 1a lea (%rdx,%rbx,1),%rax > 11: 48 89 44 24 10 mov %rax,0x10(%rsp) > 16: eb 29 jmp 0x41 > 18: e8 ee 27 a3 f7 callq 0xf7a3280b > 1d: 48 89 e8 mov %rbp,%rax > 20: 48 c1 e8 03 shr $0x3,%rax > * 24: 80 3c 18 00 cmpb $0x0,(%rax,%rbx,1) <-- trapping in= struction > 28: 0f 85 a6 02 00 00 jne 0x2d4 > 2e: 49 39 ec cmp %rbp,%r12 > 31: 48 8b 55 00 mov 0x0(%rbp),%rdx > 35: 49 89 ef mov %rbp,%r15 > 38: 0f .byte 0xf > 39: 84 .byte 0x84 > > > --- > This report is generated by a bot. It may contain errors. > See https://goo.gl/tpsmEJ for more information about syzbot. > syzbot engineers can be reached at syzkaller@googlegroups.com. > > syzbot will keep track of this issue. See: > https://goo.gl/tpsmEJ#status for how to communicate with syzbot. > syzbot can test patches for this issue, for details see: > https://goo.gl/tpsmEJ#testing-patches >