Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp806417rwl; Fri, 24 Mar 2023 02:08:45 -0700 (PDT) X-Google-Smtp-Source: AKy350YIGz0N6fzrKJAnVLjGhozwatSNOmQGJ0aXgmisdncUNOgUnO/8QTOGnZIlEl98kYSLXtbO X-Received: by 2002:a17:907:7f25:b0:931:f57a:4bcd with SMTP id qf37-20020a1709077f2500b00931f57a4bcdmr2211789ejc.77.1679648924739; Fri, 24 Mar 2023 02:08:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679648924; cv=none; d=google.com; s=arc-20160816; b=elK0zi6vJiP5jnD20zIbD6jLioMSwUL02oUH03mPlKFqsmoqsXBpGrfu6tgH4o9ke6 WT502AZnbg93Di7ZSK5jGY58KURd2aPYvV2GIjpXFvNqz4eQA+J1g3HMkhED+xaxM2TV sekDvMXEiZnDHLE3t69rBYLMHf/q8YTSrbBZORElRaQeYDKSDSZIIo8NWEMq0L8YfAuC l4iN5PzSsFcLRIfa+p/dySqpIPiW2EwzXkq6E4aYnV4Z1R11ihFDCGcpSH2CoUyBZxYX jceFelY/QtTefTFmVB0v2jMPPgfbM8sTeRx4N+5Aez95SqA1IdGU9WjatosAWsJ/97HY jwfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=n243IrPXTdbsIKu5fMm4CD6r1EOzF5PeneoBpB/y4a4=; b=AWo76eikvItYCheXFZ1d7lYTUUTXAUO6eqIrC8p56om752kmfAC+hM4zNo2gHgyYle /qaERIQJiFrNcSu8V3x4TIMwqSlSDVOIuQzbPmQlnuSCAb5m5DCuBFGptzicGTrTWk+9 wtnfAecMTcbwUf4LP3JCOoRi5Z2ym3dwlhBY+/PYkdobdkX0dxQe2qi6aiYbK+K9wgE6 q6b28mskJ6gf30R4s1SwHFH+eLsC2BWYBu3W3gclZbhZzt6EQHYMygj/Aji7AO0Pnxvt 993dvKtTvSuJilwh6NZWpJNJzXP2z1tKcD9O2NWrL+5TJwueoeB2GPZYfVvd7o9oQfcm E/RA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WdoFuibS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sk19-20020a170906631300b00939e87fcf99si8906555ejc.417.2023.03.24.02.08.12; Fri, 24 Mar 2023 02:08:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WdoFuibS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231978AbjCXJCZ (ORCPT + 99 others); Fri, 24 Mar 2023 05:02:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231754AbjCXJCY (ORCPT ); Fri, 24 Mar 2023 05:02:24 -0400 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95028A3 for ; Fri, 24 Mar 2023 02:02:21 -0700 (PDT) Received: by mail-wr1-x432.google.com with SMTP id o7so992173wrg.5 for ; Fri, 24 Mar 2023 02:02:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679648540; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=n243IrPXTdbsIKu5fMm4CD6r1EOzF5PeneoBpB/y4a4=; b=WdoFuibSoYq7PItUra7h1o7dNN+dLoO5akaOdiXzNB0GAE6fZrgXjLHEQ59DSfNlbF cgR9upm2UnMKp/K2iMTwYQO21eNLlcZA3VTjTQNcOKl6oB0YptTJSukTiMpZuSldqpht hT88zEf4E+gJCKG8bgBmZ3XtNmerD2XLEjORhA0Q/BXrUscdTef1dpRx9JDa6Bv504ko b2kwoYvEBcdXwhSFs2mCJx6XhNHoIVhKWvY4ugN0Krhnhx9JD7Gr1ZRwtzNsp6GxXu5W oQsFCmuvbtw0zcJ+Dg4t9K3RUmnMmVMxySl96IxGJYoNSUSPaDNY3cwVaR2TYMM/uF88 /2CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679648540; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=n243IrPXTdbsIKu5fMm4CD6r1EOzF5PeneoBpB/y4a4=; b=tqbLvAr04dE0vdduK1+07xvre5lXFm0Tq4+075vlGQhX3jir6akXTDfYvEP+jurFkS NvInIzRs2O2lLLHgE9ZAiPgI4hAiYG7XQfbIeuFVMNVhR4bVPad/M0byWKOeyZ4WxBsH ptQHffmSsPjCNkmbcsDqbJgVReW/abxPpOV+x5ynZsRsRR50DiFYUVgaOPG7cW6m7ZnJ Sk1xSd6FGTCxYtMwOJTi2lgJLvR/TiOHsXDnNLZxidUARqpoo7RNJ8Eg3M0Pmj5wGKVf QtKMoKdXD4nY+viv8rE5zYSLeb9sOfyLecOa4QiDTgeqm5rKXs8x3voSWLeCj18+Buwe lIcA== X-Gm-Message-State: AAQBX9cFEnO3QQVu6Ie7YpYAKtvJTsEH0Gxt43Pyw65PE9ikS42LVygK 4D8ONEFbsVLJRTLQjlO0mBK0PQ== X-Received: by 2002:a05:6000:1192:b0:2c7:17a4:4ece with SMTP id g18-20020a056000119200b002c717a44ecemr1496737wrx.26.1679648540094; Fri, 24 Mar 2023 02:02:20 -0700 (PDT) Received: from [192.168.69.115] ([176.176.152.149]) by smtp.gmail.com with ESMTPSA id t6-20020adff606000000b002d828a9f9ddsm9869841wrp.115.2023.03.24.02.02.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Mar 2023 02:02:19 -0700 (PDT) Message-ID: <43e7ef6d-6248-4ee5-7144-70809e5c93e0@linaro.org> Date: Fri, 24 Mar 2023 10:02:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v7 4/6] EISA: Convert to use less arguments in pci_bus_for_each_resource() Content-Language: en-US To: Andy Shevchenko , =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= , Mika Westerberg , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Michael Ellerman , Randy Dunlap , Arnd Bergmann , Niklas Schnelle , Bjorn Helgaas , "Rafael J. Wysocki" , =?UTF-8?Q?Pali_Roh=c3=a1r?= , "Maciej W. Rozycki" , Juergen Gross , Dominik Brodowski , linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org Cc: Miguel Ojeda , Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Thomas Bogendoerfer , Nicholas Piggin , Christophe Leroy , Anatolij Gustschin , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , "David S. Miller" , Bjorn Helgaas , Stefano Stabellini , Oleksandr Tyshchenko References: <20230323173610.60442-1-andriy.shevchenko@linux.intel.com> <20230323173610.60442-5-andriy.shevchenko@linux.intel.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20230323173610.60442-5-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/3/23 18:36, Andy Shevchenko wrote: > The pci_bus_for_each_resource() can hide the iterator loop since > it may be not used otherwise. With this, we may drop that iterator > variable definition. > > Signed-off-by: Andy Shevchenko > Reviewed-by: Krzysztof Wilczyński > --- > drivers/eisa/pci_eisa.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/eisa/pci_eisa.c b/drivers/eisa/pci_eisa.c Since this is *PCI* EISA, could be squashed into previous patch. Reviewed-by: Philippe Mathieu-Daudé