Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 24 Mar 2023 11:16:24 +0100
From:   Michal =?utf-8?Q?Koutn=C3=BD?= <mkoutny@suse.com>
To:     Jens Axboe <axboe@kernel.dk>
Cc:     Josef Bacik <josef@toxicpanda.com>, linux-block@vger.kernel.org,
        nbd@other.debian.org, linux-kernel@vger.kernel.org,
        Navid Emamdoost <navid.emamdoost@gmail.com>,
        Michal Kubecek <mkubecek@suse.cz>
Subject: Re: [PATCH RESEND v3] nbd_genl_status: null check for nla_nest_start
Message-ID: <20230324101624.mnbagb3jxshucawq@blackpad>
References: <20230323193032.28483-1-mkoutny@suse.com>
 <6c507b78-35fb-fe23-51f0-e5bb754679d0@kernel.dk>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="tly6jqa3p5uzjb5y"
Content-Disposition: inline
In-Reply-To: <6c507b78-35fb-fe23-51f0-e5bb754679d0@kernel.dk>
Precedence: bulk


--tly6jqa3p5uzjb5y
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Thanks for the reply.

On Thu, Mar 23, 2023 at 04:51:17PM -0600, Jens Axboe <axboe@kernel.dk> wrot=
e:
> So please don't mix CVEs into any of this, they don't matter one bit.

Do not shoot the messenger.

(But I'll refrain from that numeric reference to disincentivize such
trophy collecting.)

> Never have, and never will. What's important is how the bug can be
> triggered.

=46rom my perspective it's pragmatic better-safe-than-sorry -- a proof may
be conceived that rules out any triggering condition, it's less work to
put the guard in though.

My .02=E2=82=AC,
Michal

--tly6jqa3p5uzjb5y
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQTrXXag4J0QvXXBmkMkDQmsBEOquQUCZB14dgAKCRAkDQmsBEOq
uQ71AQDGZxjMPEueZul0m/zsn0FkW1akNCWxkd5shBj5jiI4vAD/Ua8Gutx5iw+Y
Sprxj5N+CO+W9Cw4P19YOI66IpM+wAQ=
=4Dp8
-----END PGP SIGNATURE-----

--tly6jqa3p5uzjb5y--