Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4e3e6d50-c6ba-985d-82e6-df52ef17d174@linaro.org>
Date:   Fri, 24 Mar 2023 12:29:27 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH v5 2/2] ARM: dts: exynos: add mmc aliases
To:     Henrik Grimler <henrik@grimler.se>
Cc:     robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        alim.akhtar@samsung.com, m.szyprowski@samsung.com,
        jenneron@protonmail.com, markuss.broks@gmail.com,
        martin.juecker@gmail.com, virag.david003@gmail.com,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
        phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht,
        Valentine Iourine <iourine@iourine.msk.su>
References: <20230316211558.8526-1-henrik@grimler.se>
 <20230316211558.8526-3-henrik@grimler.se>
 <216262b8-fe48-6696-17a4-eaa82e776db7@linaro.org> <ZBds5NFv1Lr8k0jk@L14.lan>
Content-Language: en-US
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <ZBds5NFv1Lr8k0jk@L14.lan>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 19/03/2023 21:13, Henrik Grimler wrote:
>>>  
>>> +	aliases {
>>> +		mmc0 = &sdhci_0;
>>> +		mmc2 = &sdhci_2;
>>
>>
>> Why this is 2? Aliases are continues and match the board. For example
>> Universal calls this mmc1 and the next mmc2, not 3.
> 
> Not sure I follow, Universal calls sdhci_2 mmc1 in schematics? (I have tried searching for
> schematics but cannot really find anything about this board)

Yes. The alias numbers are the numbering exposed on the board. This
might or might not match original numbering. If you have a development
board with a SoM, pretty often not all interfaces, let's say UARTs, are
exposed. SoM might have 10 UARTs, but board has only 4 and numbers them
UART0-3. Aliases should be 0-3, not 0, 5, 7, 9.

> 
>> I bet it is the same on Trats and all other boards.
> 
> Sure, I can change to mmc0, mmc1 for all 4210 devices.

Yes, please.

> 
>>> +		mmc3 = &sdhci_3;
>>> +	};
>>> +
>>>  	chosen {
>>>  		bootargs = "root=/dev/mmcblk0p5 rw rootwait earlyprintk panic=5 maxcpus=1";
>>>  		stdout-path = "serial2:115200n8";
>>> diff --git a/arch/arm/boot/dts/exynos4412-itop-elite.dts b/arch/arm/boot/dts/exynos4412-itop-elite.dts
>>> index 6260da187e92..0e5419c0eaff 100644
>>> --- a/arch/arm/boot/dts/exynos4412-itop-elite.dts
>>> +++ b/arch/arm/boot/dts/exynos4412-itop-elite.dts
>>> @@ -20,6 +20,10 @@ / {
>>>  	model = "TOPEET iTop 4412 Elite board based on Exynos4412";
>>>  	compatible = "topeet,itop4412-elite", "samsung,exynos4412", "samsung,exynos4";
>>>  
>>> +	aliases {
>>> +		mmc2 = &sdhci_2;
>>
>> mmc1
> 
> Ok, will change.
> 
>>> +	};
>>> +
>>>  	chosen {
>>>  		bootargs = "root=/dev/mmcblk0p2 rw rootfstype=ext4 rootdelay=1 rootwait";
>>>  		stdout-path = "serial2:115200n8";
>>> diff --git a/arch/arm/boot/dts/exynos4412-itop-scp-core.dtsi b/arch/arm/boot/dts/exynos4412-itop-scp-core.dtsi
>>> index ca8d42b2ce3b..7bc6968af9c3 100644
>>> --- a/arch/arm/boot/dts/exynos4412-itop-scp-core.dtsi
>>> +++ b/arch/arm/boot/dts/exynos4412-itop-scp-core.dtsi
>>> @@ -23,6 +23,10 @@ memory@40000000 {
>>>  		reg = <0x40000000 0x40000000>;
>>>  	};
>>>  
>>> +	aliases {
>>> +		mmc0 = &mshc_0;
>>> +	};
>>> +
>>>  	firmware@203f000 {
>>>  		compatible = "samsung,secure-firmware";
>>>  		reg = <0x0203f000 0x1000>;
>>> diff --git a/arch/arm/boot/dts/exynos4412-midas.dtsi b/arch/arm/boot/dts/exynos4412-midas.dtsi
>>> index 82aed59cba7c..e6b949c1a00f 100644
>>> --- a/arch/arm/boot/dts/exynos4412-midas.dtsi
>>> +++ b/arch/arm/boot/dts/exynos4412-midas.dtsi
>>> @@ -25,6 +25,9 @@ / {
>>>  	aliases {
>>>  		i2c11 = &i2c_max77693;
>>>  		i2c12 = &i2c_max77693_fuel;
>>> +		mmc0 = &mshc_0;
>>> +		mmc2 = &sdhci_2;
>>> +		mmc3 = &sdhci_3;
>>
>> This is actually correct.
>>
>>>  	};
>>>  
>>>  	chosen {
>>> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>>> index 25e082fda955..45ef7b7ba7e0 100644
>>> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>>> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>>> @@ -13,6 +13,11 @@
>>>  #include "exynos-mfc-reserved-memory.dtsi"
>>>  
>>>  / {
>>> +	aliases {
>>> +		mmc0 = &mshc_0;
>>> +		mmc2 = &sdhci_2;
>>
>> This is also correct.
>>
>>> +	};
>>
>> For all other cases, where schematics are missing, just make them linear.
> 
> Alright, will do in next version, thanks for the feedback!
> 


Best regards,
Krzysztof