Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp1088373rwl; Fri, 24 Mar 2023 06:13:57 -0700 (PDT) X-Google-Smtp-Source: AK7set/Z4bNp7gm6Wp4vZQRpbNoI4K7ivw72sOWPw90qT03gP8zR0KHc/LI367XeMMB1CjEbBbB5 X-Received: by 2002:a05:6a20:c50f:b0:dd:bf6a:4609 with SMTP id gm15-20020a056a20c50f00b000ddbf6a4609mr2787764pzb.49.1679663636672; Fri, 24 Mar 2023 06:13:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679663636; cv=none; d=google.com; s=arc-20160816; b=C8RW7Rjcb+N0IarGXq954UczR+HEMdQ//Zz6R4W7w84c9kbHEzbXVeF2BPejC5HtNH FZbdbmcyVN1pnZYzZbPLksPJrs48jftyZRbZEQQZUQXAVkXXpIMnYIyGQ4KKhX/mCUwk BHBBRq0wzEF9ueO33g1qGZwygvHvy1Q2CaPlqV3WkssoB2lTL37JatPQaZ3oEeot50hC D44jDMC/60HJFTA8qGrNm2MZuHcg0Ea8mzwRxYZmwe6GEPc5mFHgx7f9/jzMWa6C5/4y zcObrFWfpeHVziIu8fBApZZGreGLv+slOkzEWfhvjXKDdnBQLWfHUUt0T10BaMpp/kAM zFZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ewQDzGm+t2NXNO9AbFYlq1fjj1R033V1nKRDmhqg/as=; b=EK+/l/hEObODvWGNk/ay7gqcnmTYXG4FJ85sW74hIOEF77vYz4h+EXECNrX9vZrTk1 iS6wAOgHiJedaflLslfwEi27IrlBu2fbSBZx46FLad3Lzw87GCMNlJND8yTbiOC8lDHl S6q8Vj0XNmncRPcG7ZkLteuqomF5OWT/OFr7hfsg/etvNtoKBKjbJ48E6XVyHuxDnsYU MdNcwFXjaxT08i4A6KgVEwiWVaQxaznDRpsr1jOxjFRNUNteVo52etBEka+zoP0NNWBm /9VQ1UzP/w15Rjfm/SBiMxMcUA2MzTJ/mcEhmfs0vKFmKIMa5kiMRp1L4m6+Hda2WcIv U4MA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ucw.cz header.s=gen1 header.b="gr/5ouit"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ucw.cz Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n127-20020a632785000000b0050be690a621si22503148pgn.327.2023.03.24.06.13.44; Fri, 24 Mar 2023 06:13:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ucw.cz header.s=gen1 header.b="gr/5ouit"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ucw.cz Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231522AbjCXNHJ (ORCPT + 99 others); Fri, 24 Mar 2023 09:07:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229468AbjCXNHG (ORCPT ); Fri, 24 Mar 2023 09:07:06 -0400 Received: from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E72882213F; Fri, 24 Mar 2023 06:07:04 -0700 (PDT) Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 7F0E41C0E0F; Fri, 24 Mar 2023 14:07:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucw.cz; s=gen1; t=1679663222; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ewQDzGm+t2NXNO9AbFYlq1fjj1R033V1nKRDmhqg/as=; b=gr/5ouitw1mix4WCQYdxVyuJvoVtGD6GzE86tmnR0XYOuuhh0ITWxembhzlsxebIpdmIon pRPcTYXrDu2D0HeUz9jx6hcftc+BI/QYXqq/fj6PCgRLUgCxJkSdFaxK2ew+dsbay18JZr eFal8kNvIcChVroFJdoblMq0gyOFZsU= Date: Fri, 24 Mar 2023 14:07:02 +0100 From: Pavel Machek To: Naresh Solanki Cc: Christophe JAILLET , Lee Jones , Patrick Rudolph , linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [PATCH v2 2/2] leds: max597x: Add support for max597x Message-ID: References: <20230323194550.1914725-1-Naresh.Solanki@9elements.com> <20230323194550.1914725-2-Naresh.Solanki@9elements.com> <688423c6-ba98-002c-efe5-7b0997d6af73@9elements.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="KvhWOlauSwJvaynd" Content-Disposition: inline In-Reply-To: <688423c6-ba98-002c-efe5-7b0997d6af73@9elements.com> X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --KvhWOlauSwJvaynd Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > > +++ b/drivers/leds/Kconfig > > > @@ -590,6 +590,17 @@ config LEDS_ADP5520 > > > =A0=A0=A0=A0=A0=A0=A0 To compile this driver as a module, choose M he= re: the > > > module will > > > =A0=A0=A0=A0=A0=A0=A0 be called leds-adp5520. > > > +config LEDS_MAX597X > > > +=A0=A0=A0 tristate "LED Support for Maxim 597x" > > > +=A0=A0=A0 depends on LEDS_CLASS > > > +=A0=A0=A0 depends on MFD_MAX597X > > > +=A0=A0=A0 help > > > +=A0=A0=A0=A0=A0 This option enables support for the Maxim 597x smart= switch > > > indication LEDs > > > +=A0=A0=A0=A0=A0 via the I2C bus. > > > + > > > +=A0=A0=A0=A0=A0 To compile this driver as a module, choose M here: t= he module will > > > +=A0=A0=A0=A0=A0 be called max597x-led. > >=20 > > leds-max597x? > As per struct max597x_led_driver, driver name is max597x-led Please test the modular build and double check the module name. BR, Pavel --=20 People of Russia, stop Putin before his war on Ukraine escalates. --KvhWOlauSwJvaynd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCZB2gdgAKCRAw5/Bqldv6 8qT1AJ4rZ5oeqfJ7mfKo5Zr4u6ashkHcIACgiT8fhIHSmdSMSkC2LAzbtcm4VUI= =wIV7 -----END PGP SIGNATURE----- --KvhWOlauSwJvaynd--