Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8e593a61-8a0e-8e13-603b-ced514b7533e@amd.com>
Date:   Fri, 24 Mar 2023 08:12:01 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH v2 1/5] cxl/pci: Add RCH downstream port AER and RAS
 register discovery
To:     kernel test robot <lkp@intel.com>, alison.schofield@intel.com,
        vishal.l.verma@intel.com, ira.weiny@intel.com, bwidawsk@kernel.org,
        dan.j.williams@intel.com, dave.jiang@intel.com,
        Jonathan.Cameron@huawei.com, linux-cxl@vger.kernel.org,
        rrichter@amd.com
Cc:     oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
        bhelgaas@google.com
References: <20230323213808.398039-2-terry.bowman@amd.com>
 <202303241632.HTxJ0yfj-lkp@intel.com>
Content-Language: en-US
From:   Terry Bowman <Terry.Bowman@amd.com>
In-Reply-To: <202303241632.HTxJ0yfj-lkp@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TkdaeXNjaVlYNUtJKzBRVWNBeEx6T2IxSkhralRPZ29JNVNqbENxVXRzSVpG?=
 =?utf-8?B?N1pKM0Z5WUphejdPeUJMZmMwQ0ZFS0Rta0dscVo1aDZucDJVOFZVRXBIaUVu?=
 =?utf-8?B?VnFyRjFVdldsU1NTZHlBUVFRWityZnVML0NiY09VYVdDcjA0bU45aysyZFBw?=
 =?utf-8?B?a0FUSVhvYjNtbjNtUDJoVm5TVlR0VW1PK0hTMHNBTDBBYkFPMDNaWlljekVa?=
 =?utf-8?B?TG9UVi9ZYkwzM2diUkpPVnBVZVorS09XeG5PQUd2djcwcU5qWnNMYWJLa2wx?=
 =?utf-8?B?bWRqdmF1cklyMEFBOWZHdTNFUFcrSFkzRnByQ0lGc0hycmx1elMyUklPZHRk?=
 =?utf-8?B?SXBtTGZlV1k2ME40MXRxOHNhbW5MbzRlOFozOTBaQ2hWeG9Tdmw5K0E2L2lu?=
 =?utf-8?B?QnJYMjFNTEZTaEZrMTlGRytKUXNZdlZ2SXAzeFB6cU8rUThHcUprdlo1Qkdl?=
 =?utf-8?B?NnpXNG8zNjhMdExaaWcwbnZObGIyblhXN0JmTGJ6QU1Hc3h4dmxTZ1NOYmlp?=
 =?utf-8?B?alRzOFZuNU9PcC83NmhLWmUxUUZjdDE4cHI5bldUUnFqU2tmYjNuY21ZSWlL?=
 =?utf-8?B?ZDRjM2tYZVpvNDRYcFZrNDVqVFdtSGxWbFJHVHhydnVqa2ZGQzU3bFdFS2Ev?=
 =?utf-8?B?ZXdXb0hRSlNMeFgrWFkvdkk0RUY4OEs1R3k0RFkrZW9PNWU3SDJiNzBDS0dR?=
 =?utf-8?B?YXJUZXU0Ly93b0duV3lIbVU4Ni85WVkxeVZXZ1JmMUE2STFtZUt3RU9CTjdw?=
 =?utf-8?B?NHhsV00rR2tCTk4yQ01vT0hlbXlRYVRib1RtcCt4RGxxZFFNSjNka2VuMmZa?=
 =?utf-8?B?M0duQU5mcWZoTWFnR3JiWWpQYXdadE5oOFpMSGFIMnhsZGxpMWdMUXVtKzlm?=
 =?utf-8?B?V3ZrTFdHRWtobjEwZWlyOFVvejhuRUdBNlRlTmZ4Mi9zT0JhUHpJajR3bUo0?=
 =?utf-8?B?QVRIZDhyR0ZNOXNpdTc3ZWJqT1BnWjVUK1JHTHpHYmFnb2F2U0Y5cmtoTEpF?=
 =?utf-8?B?Zzg2WERkakpDOWp2Tk1Ta0JiTURQWmRDanNmVE5IT2FpYW9RL0ZzSDY1WFd1?=
 =?utf-8?B?cUN3QVNNWmlnZDZFVVhKUERkUzFjZVdDS1FYTzlsdmhUMEFWQTBLY2N1KzIy?=
 =?utf-8?B?SGs0b3A1VitHMlh4SG9HMmx1M0sxS0xHYTM2dzQ1azkwaTRBSEs2cWt2WUo2?=
 =?utf-8?B?Vlk2RVlGZE5FVWYzTWF4VEdSR0w0QzdUVVpoaXBHTVVxTmtjQXdxQWU3Rk5z?=
 =?utf-8?B?Qm83QU5QTEUrUDIvU3pHNXFiQzQyaTl3MURSelAzVkNPakdZVDB2RTAzc0JK?=
 =?utf-8?B?QzQ2VzVPcHlJbXZ3dXJudWhWM0VvQlV4NU9JSzlzVzBVQ3lHMHZ5ZUdyRTN4?=
 =?utf-8?B?c0RIQUhGbStwOEJUNmNpays4N0VJeWh2N1RXRW1Fdi9LNlVoY1ZzTEdaRFFG?=
 =?utf-8?B?MnVNN0JsTUFMNENiZVFtSEcxeiszcEFxMlFmR3RRRHBGVHVWVGsrWDhPdkV3?=
 =?utf-8?B?KzMxL05STUM2aGhWeUNKZ0p4NmVBd1gwbTVqeGxyTFQ4NndiVWNNaDk2czRT?=
 =?utf-8?B?NzlHaUlZd05FNTFjSkdxRkNTK2xhdE1EeFdndzhWUHEyNzBKUWg0dkZUWmwr?=
 =?utf-8?B?cyt4S1R6dmhZZU15bFVSYTFQQ0lXUm9uZVpPOXE2NWZ6ckJNU2hMWTJockly?=
 =?utf-8?B?S2owNC9ERUdrYXZVaTFBdUl3eEtiVGxSa3dvUDI2V2ZUV2tmdDhTQWtYMWNm?=
 =?utf-8?B?dk80eUtPa25XNHNXWU92RXZXeEFHd3lMNnd6T0ZiSTF0WWh1aTBaL0VnRlZk?=
 =?utf-8?B?bDZiaDdoZXBKeHh1c0RGb0hIb0YySm5nMTRiNHkxVkZybEFFaWdXNW1MOVNp?=
 =?utf-8?B?eGdkR3ZINlVzdGdmY1VUY01Lc0I1cmZJTG14R3NXc29BbVFGVlZIczVYTTc4?=
 =?utf-8?B?K25XMURadUZHd2J1cDUxUkVrK3BjcFJ5TjV0cDg4S2hQWGtMdzZmZVc5T1Zv?=
 =?utf-8?B?VkhWdzl0RDVrZTQwTGFkeEFMTCs0azFGMk5VZkxkWDl5RC96VjdZQVJZQ1ZM?=
 =?utf-8?B?K2I2bWtaZmlJMklqc1pZWmM2YjFVbkRiblpoQnBxSElzVVdBNmN5djU4RURD?=
 =?utf-8?B?bjRVWUxsVmJOZkpIY0RiSnJqZktUUTF4QUQ3cDFGMG5QYlhPNjF1TXJjTU1z?=
 =?utf-8?Q?VrkCVhjPjG2VJz+krNZHdKEAw+jrfnQW2961XstkeAvv?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 36e8abc6-af06-43c8-47f1-08db2c695d7d
X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6390.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2023 13:12:05.7080
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sRJZArAfIy2Du0EXAHXxEui8pLA4I43bvfeNoETiHK9ToxV+Gg4NcrlZl4gHip/0A7uDJGDL4YDLlHrGPRjeiw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8584
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/24/23 03:53, kernel test robot wrote:

> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@intel.com>
> | Link: https://lore.kernel.org/oe-kbuild-all/202303241632.HTxJ0yfj-lkp@intel.com/
> 
> sparse warnings: (new ones prefixed by >>)
>>> drivers/cxl/core/regs.c:340:24: sparse: sparse: Using plain integer as NULL pointer
>    drivers/cxl/core/regs.c:345:24: sparse: sparse: Using plain integer as NULL pointer
> 
> vim +340 drivers/cxl/core/regs.c
> 
>    338	
>    339		if (!request_mem_region(map->resource, map->max_size, name))
>  > 340			return 0;
>    341	
>    342		map->base = ioremap(map->resource, map->max_size);
>    343		if (!map->base) {
>    344			release_mem_region(map->resource, map->max_size);
>    345			return 0;
>    346		}
>    347	
>    348		return map->base;
>    349	}
>    350	
> 

Yes, I will change the 0 return value to use NULL instead.

Regards,
Terry