Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp1090116rwl; Fri, 24 Mar 2023 06:15:11 -0700 (PDT) X-Google-Smtp-Source: AKy350YRsAbdTOwvRDEJgsiBBW0C/34GQ49KqsVEpjdcySXOXo+PK2x7OYoa45JU78ucxdQdmq0V X-Received: by 2002:a17:90a:4bca:b0:234:b4a7:2abd with SMTP id u10-20020a17090a4bca00b00234b4a72abdmr3037114pjl.12.1679663711473; Fri, 24 Mar 2023 06:15:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679663711; cv=none; d=google.com; s=arc-20160816; b=sKelRbsJayJJ3RyFblWlduuGteeadf7eEmQTgsM2tjE25pxc4qvgrIlwC0O79CU9PS LpZgZsorrJAue3/7pRoSDQ0WM4na+3l9XsKtyoZwVAVOZnTXeEpTv/Kt2WiMs9Mv1al/ iYLULFKtxETl1rP5Bj7Q2biRc0HI8FG7s0huKkyMHKT7nrs01o3ESXwga0KjHOBNBa+y DR17/Z4ahHOugOyB1j5vW2VGRBQzc3kXRsqxsyVF0IsRbTSgGUlRBwjNuP13NwlWCgz/ X1u5m2fGyLGqTnVWkFg89I7rDer+MYYPWLTmOCpBXlCHGXnJEYKjQGFo3IkIu3JozFlZ /Uzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=Eyuqr1fv+cfBlegBDLuNw3DIq2KUKlCp3F/yxM0Lgm0=; b=Lf3Rms/qQNiVucOqsedRzzZJGHC9FnGBC4J2SWHDbSJ32yMKF92NFph/OOWueXjN1s /KAxIeGENbc6wTgXrTjRWEiwhFqNZiq+RIZnb47TmqCExzGuKDuEy2aLKh9x7nDul9CT ujMAHBa9eY/uGmDmBEVUSXl0rLFS8xjFs2xf/9kcuvHlv6qMx3lawsU+dEBTFWK6W7rx MXJwPR9I5F6Nd9TsvOo+v3FRGVZnP1tpuFHibo2At/LCX4uIoEXWSaIu9m98xKhpsQE5 d4VeV7cbaVxkxgokaMqFseV+ikbT0rOx12EP552nmJBsCBykJwPDxo4BSImMR9Ch7cDE f+Cg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l6-20020a654486000000b00503a2a21d1esi20783497pgq.728.2023.03.24.06.14.54; Fri, 24 Mar 2023 06:15:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231822AbjCXNNn (ORCPT + 99 others); Fri, 24 Mar 2023 09:13:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230495AbjCXNNm (ORCPT ); Fri, 24 Mar 2023 09:13:42 -0400 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B0FCD2128; Fri, 24 Mar 2023 06:13:40 -0700 (PDT) Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1pfhEh-00010v-04; Fri, 24 Mar 2023 14:13:39 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 9A431C1B8C; Fri, 24 Mar 2023 14:13:10 +0100 (CET) Date: Fri, 24 Mar 2023 14:13:10 +0100 From: Thomas Bogendoerfer To: Jiaxun Yang Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, hch@lst.de Subject: Re: [PATCH v2 4/4] MIPS: c-r4k: Always install dma flush functions Message-ID: <20230324131310.GE15824@alpha.franken.de> References: <20230222132425.7442-1-jiaxun.yang@flygoat.com> <20230222132425.7442-5-jiaxun.yang@flygoat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230222132425.7442-5-jiaxun.yang@flygoat.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW, SPF_HELO_PASS,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 22, 2023 at 01:24:25PM +0000, Jiaxun Yang wrote: > As nowadays DMA coherence is managed per device, it is possible > to have a system that is defaulted to coherent dma but still > have noncoherent device that needs to use those flush functions. > > Just install them unconditionally. > > Signed-off-by: Jiaxun Yang > --- > arch/mips/mm/c-r4k.c | 12 +++--------- > 1 file changed, 3 insertions(+), 9 deletions(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]