Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp1097739rwl; Fri, 24 Mar 2023 06:20:18 -0700 (PDT) X-Google-Smtp-Source: AKy350YfBNwW/saQCvHOzIb/gXL+rWIdyO6EmLX6MzfROumpLeFzc5RzlX7JnDCVGPwxpdilFAPJ X-Received: by 2002:a17:906:79c8:b0:928:d4f6:6f7b with SMTP id m8-20020a17090679c800b00928d4f66f7bmr2646138ejo.66.1679664017856; Fri, 24 Mar 2023 06:20:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679664017; cv=none; d=google.com; s=arc-20160816; b=WssYvXhq2AEeukmJqc6sdTM0oOTEWjVGmC0zt0mmftIi3Q8Hl4+m5sA7q0CIVlyHh7 2MYweGBN1BTZfprf/6BYAD5ttO4nOKIvmp2fkH6DRWLZLTCGz3ETnmmGSOkTAz+h9+Ll 45E8ixtV2XRP3WeKsmBw9CVzZZ0PPfTH1CNd1rEa/5yPlqI3d904je3dz3GrHk0cihzW SNIJ8vN/Wk8bRhW3Wd6BTuWYK2nFU+cwcS4kurjtAlIizw6teunfFemX1YiK/KxAjyMd qsFR3/eKTkZqWD8mbJA/jZx0sKUERkwTalAiOCuP1+Sf+q4PW2zA/Cp/KrczOkjo1N/N yIIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from; bh=oT+acvdU6eO+amZb5hvogxi4+aOhqk3FEjsaaJ0DV7c=; b=DNhcsKjaDVP+A37LOeHzfqSZ1muum32hqR07EBWRN0AvueDEoM5KUsB3QN9FAudOW/ xFV+wwLbCHGn2BDVZk+wRKGlghWSq7OLr2U7+mnnIQwkaXEt0zGxic3tWowiQXTsRVHr VQ+HeZkpqtg44a9CKp8+UktaZ7BL98ekwPa+70YqagjyNUsovOdsddGTHNmzk0LY82+s yHoe3OsevQRBcNyeNX20/izXzku7CSkrXCPnf6aRvNkdSURhbSLPDwKpe1vCsg+7kkD3 q9Xz93m6wRPe17xS2i5HqfbR6rOENFHFmiyd4ubi7iuz5LAxaXJXYsiU+EOgzycaCy7w bYOw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kx16-20020a170907775000b008c673be343dsi23785597ejc.612.2023.03.24.06.19.54; Fri, 24 Mar 2023 06:20:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231997AbjCXNTi (ORCPT + 99 others); Fri, 24 Mar 2023 09:19:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229508AbjCXNTh (ORCPT ); Fri, 24 Mar 2023 09:19:37 -0400 X-Greylist: delayed 732 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Fri, 24 Mar 2023 06:19:35 PDT Received: from mailout-taastrup.gigahost.dk (mailout-taastrup.gigahost.dk [46.183.139.199]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DD6A12860; Fri, 24 Mar 2023 06:19:35 -0700 (PDT) Received: from mailout.gigahost.dk (mailout.gigahost.dk [89.186.169.112]) by mailout-taastrup.gigahost.dk (Postfix) with ESMTP id B303418837C2; Fri, 24 Mar 2023 13:07:21 +0000 (UTC) Received: from smtp.gigahost.dk (smtp.gigahost.dk [89.186.169.109]) by mailout.gigahost.dk (Postfix) with ESMTP id ACC3F2500B57; Fri, 24 Mar 2023 13:07:21 +0000 (UTC) Received: by smtp.gigahost.dk (Postfix, from userid 1000) id A23749B403F4; Fri, 24 Mar 2023 13:07:21 +0000 (UTC) X-Screener-Id: e32ae469fa6e394734d05373d3a705875723cf1e Received: from fujitsu (2-104-116-184-cable.dk.customer.tdc.net [2.104.116.184]) by smtp.gigahost.dk (Postfix) with ESMTPSA id B3AEB9B403E2; Fri, 24 Mar 2023 13:07:20 +0000 (UTC) From: Hans Schultz To: Ido Schimmel Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Florian Fainelli , Andrew Lunn , Vladimir Oltean , Eric Dumazet , Paolo Abeni , Kurt Kanzenbach , Hauke Mehrtens , Woojung Huh , "maintainer:MICROCHIP KSZ SERIES ETHERNET SWITCH DRIVER" , Sean Wang , Landen Chao , DENG Qingfang , Matthias Brugger , AngeloGioacchino Del Regno , Claudiu Manoil , Alexandre Belloni , =?utf-8?Q?Cl=C3=A9ment_L=C3=A9ger?= , Jiri Pirko , Ivan Vecera , Roopa Prabhu , Nikolay Aleksandrov , Shuah Khan , Christian Marangi , open list , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , "open list:RENESAS RZ/N1 A5PSW SWITCH DRIVER" , "moderated list:ETHERNET BRIDGE" , "open list:KERNEL SELFTEST FRAMEWORK" Subject: Re: [PATCH v2 net-next 1/6] net: bridge: add dynamic flag to switchdev notifier In-Reply-To: References: <20230318141010.513424-1-netdev@kapio-technology.com> <20230318141010.513424-2-netdev@kapio-technology.com> Date: Fri, 24 Mar 2023 14:04:45 +0100 Message-ID: <87h6ua5mhe.fsf@kapio-technology.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 20, 2023 at 10:48, Ido Schimmel wrote: > > I was under the impression that the consensus was to rename this to > 'is_static' so that it is consistent with other flags. > I think the consensus was that the bridge maintainers would decide if it should be changed, this according to Oltean. I still think that is_dyn is more secure codewise in the long run and it is logical as that is what the feature the flag concerns. When you say consistent with other flags, I don't understand the inconsistency. Could you please explain.