Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8b3cb61c-8824-e358-a039-012471d679f2@9elements.com>
Date:   Fri, 24 Mar 2023 19:20:31 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH v2 2/2] leds: max597x: Add support for max597x
Content-Language: en-US
To:     Pavel Machek <pavel@ucw.cz>
Cc:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        Lee Jones <lee@kernel.org>,
        Patrick Rudolph <patrick.rudolph@9elements.com>,
        linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org
References: <20230323194550.1914725-1-Naresh.Solanki@9elements.com>
 <20230323194550.1914725-2-Naresh.Solanki@9elements.com>
 <d6463018-ebdf-30b2-ce0e-f2b5198847f1@wanadoo.fr>
 <688423c6-ba98-002c-efe5-7b0997d6af73@9elements.com>
 <ZB2gdvgFR4ZTIegA@duo.ucw.cz>
From:   Naresh Solanki <naresh.solanki@9elements.com>
In-Reply-To: <ZB2gdvgFR4ZTIegA@duo.ucw.cz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Christophe, Pavel,

On 24-03-2023 06:37 pm, Pavel Machek wrote:
> Hi!
> 
>>>> +++ b/drivers/leds/Kconfig
>>>> @@ -590,6 +590,17 @@ config LEDS_ADP5520
>>>>          To compile this driver as a module, choose M here: the
>>>> module will
>>>>          be called leds-adp5520.
>>>> +config LEDS_MAX597X
>>>> +    tristate "LED Support for Maxim 597x"
>>>> +    depends on LEDS_CLASS
>>>> +    depends on MFD_MAX597X
>>>> +    help
>>>> +      This option enables support for the Maxim 597x smart switch
>>>> indication LEDs
>>>> +      via the I2C bus.
>>>> +
>>>> +      To compile this driver as a module, choose M here: the module will
>>>> +      be called max597x-led.
>>>
>>> leds-max597x?
>> As per struct max597x_led_driver, driver name is max597x-led
> 
> Please test the modular build and double check the module name.
Thank you for your suggestion, it turns out that you were right. The 
correct module name is leds-max597x(./drivers/leds/leds-max597x.ko).
Will update Kconfig message accordingly. Thanks!
> 
> BR,
> 									Pavel
> 
Regards,
Naresh