Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Zi Yan <ziy@nvidia.com>
To:     Mike Rapoport <rppt@kernel.org>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Christophe Leroy <christophe.leroy@csgroup.eu>,
        "David S. Miller" <davem@davemloft.net>,
        Dinh Nguyen <dinguyen@kernel.org>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Guo Ren <guoren@kernel.org>,
        John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Max Filippov <jcmvbkbc@gmail.com>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Rich Felker <dalias@libc.org>,
        Russell King <linux@armlinux.org.uk>,
        Will Deacon <will@kernel.org>,
        Yoshinori Sato <ysato@users.sourceforge.jp>,
        linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org,
        linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-m68k@lists.linux-m68k.org, linux-mm@kvack.org,
        linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org,
        linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org
Subject: Re: [PATCH v2 03/14] arm64: reword ARCH_FORCE_MAX_ORDER prompt and
 help text
Date:   Fri, 24 Mar 2023 09:48:49 -0400
Message-ID: <0D106E04-A043-45B0-8629-11DC10127FD8@nvidia.com>
In-Reply-To: <20230324052233.2654090-4-rppt@kernel.org>
References: <20230324052233.2654090-1-rppt@kernel.org>
 <20230324052233.2654090-4-rppt@kernel.org>
Content-Type: multipart/signed;
 boundary="=_MailMate_C127E265-4DDB-40BB-87AD-DB2006154019_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ArbZemy+uPmNOGcVQHstQSlQXA6XGuqe6IS/t1ThEe707MTrOgZofo0Yo7I4?=
 =?us-ascii?Q?cLWtJQ9HJnRhRGbP2134cbJPdtybTHxoujVlpbQsVCzsCWFAP9T310lPr3Xk?=
 =?us-ascii?Q?M4PxHL993zLz+qCdurR1gUSa9EtSzLPqOumxh/xxdYV2EqJSDVBb+bo0D0q7?=
 =?us-ascii?Q?6hHrRDmkW5JAEhOyigWAMnvpZvZncmHMbblZBh2JR5ixvp6h+g+ZpovL7FLi?=
 =?us-ascii?Q?DX3rrhN2wNqnqOD0kWoXK88muIA0GNJ3SCRc0N6NtpiXU6uGXrnkwt27ad/d?=
 =?us-ascii?Q?+JrdjNmykBlHv7xPQPXtYTKmEK/w30eGGi6NZ+e/fl4SyLL1IQnIkyq3PVtH?=
 =?us-ascii?Q?p2zgYUcBGHqH+gYRTi4yO+z4bgYoRywlLPQvkbBzMPhLB+KTajQVh8qB1ctb?=
 =?us-ascii?Q?IlkfIem99cYGDvVRFZsc7Kgc7VVPfsOWMsa7BdUtj5YvXXouM0Q2ko2ctsSU?=
 =?us-ascii?Q?Zqrq3fzQjNEJhUG9ghOEIrzpPRg92gNfNM0Dc8BPhZQXCGwUL71y+2p5Chp8?=
 =?us-ascii?Q?bqPli6CGXJAEMB0BCn60ZVuvWz012rM8JX4imeRtNXyBKQQqgrNToo+WL3ft?=
 =?us-ascii?Q?GwQ4OUjdw0zEcc7sSGVZxrviVu6Q8E/Da8pLe8drHByNVWz6dl7myXsLUJ2r?=
 =?us-ascii?Q?kKcPnxUipBgVmuRxpQQ95xzc2h8PMnnPlsAdPdbr0ySmsioYbpt3y8LbcpWO?=
 =?us-ascii?Q?DqaiInOzK7uErk+wgXBFyo1UVXe/Qt8s9VPyJ7FMEJKHPqAenem5whvNGu10?=
 =?us-ascii?Q?yP9oYk7NJCugQWGqhzpsjQv9tJBIUxY0PDQ9x7TUq/THSCoSbbya08WPsEce?=
 =?us-ascii?Q?AUlluL1TdDg6lPREb8SbTJAEM6xTB1K6DoTE31itBnzQp5ePba4vCaxha74u?=
 =?us-ascii?Q?HKE58mR4wbYfdBLnWawFCT98/ujfgqZqiNKMRLEnj5kUT4shNw+FUpcygZZW?=
 =?us-ascii?Q?XtDFQA+hVhh0aA49oUbhCRbcz3g7rUtVrGl6o/xGMHmXWRIO/ESQa+ME/aLL?=
 =?us-ascii?Q?ORbUKrY05BVikoruU9Zc9YQ05tff8eWwCD9zfCC2TVlK8FgVirYkvLZWII69?=
 =?us-ascii?Q?vNnWRU/6ufGcVa8goe3YxO51HF2/4+9Kq8MOEP8YaMZ0IjC74SLVCMD0FC2B?=
 =?us-ascii?Q?3W2tZFCAmE1A4bJKjXqYIBgQx0SKG0Sdze1zBimpXStMyA9b4JKG9KxOnpM7?=
 =?us-ascii?Q?mRnjWoPgUEvm20ecW6roU2iUPJhrHnPqUDV157zphYcpOLwITwyk9EGijGhw?=
 =?us-ascii?Q?Rwx8rhpzUiGGfWZxWIoEgWjL86XOvstgGrjGwejE8ZFztQOlZTXPQIEMqLTs?=
 =?us-ascii?Q?5uSrVaqqlcL/v0UEKMjVUl+7+IpXD+XWA6yxUx9z9rvMSb/ie6jo/3GQu8b1?=
 =?us-ascii?Q?eUF7GOmkB164fToHPT+sHkoD8LctCXPXneazRbdbv3qw4NQBgGljw+ImPyPe?=
 =?us-ascii?Q?9Sp/GEm+1eELXoEonlFOlajN+W3KQ3AUio1CTgOP7gyDYcdI93aSwqaSmzFM?=
 =?us-ascii?Q?zCStBVtJXQCJxzqL5MXQd0nI6/UcOk6Q5TFkORgCygOA01TmnUEYnGxO3DVC?=
 =?us-ascii?Q?RFIs4fZKsx6hurzgK0cB8hAGSSio5IDTNTBq0T+E?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f3fd835f-1b41-4474-f959-08db2c6e80eb
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2023 13:48:52.6529
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: he5SjmLElUsSYpWnnrahnd5fRDu5tt9GSyDjRRkeOO5vs5+/B/cAZ/kQkn5oIYJa
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4382
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--=_MailMate_C127E265-4DDB-40BB-87AD-DB2006154019_=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On 24 Mar 2023, at 1:22, Mike Rapoport wrote:

> From: "Mike Rapoport (IBM)" <rppt@kernel.org>
>
> The prompt and help text of ARCH_FORCE_MAX_ORDER are not even close to
> describe this configuration option.
>
> Update both to actually describe what this option does.
>
> Signed-off-by: Mike Rapoport (IBM) <rppt@kernel.org>
> Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> ---
>  arch/arm64/Kconfig | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 7324032af859..cdaf52ac4018 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -1487,24 +1487,24 @@ config XEN
>  # 16K |       27          |      14      |       13        |         1=
1         |
>  # 64K |       29          |      16      |       13        |         1=
3         |
>  config ARCH_FORCE_MAX_ORDER
> -	int "Maximum zone order" if EXPERT && (ARM64_4K_PAGES || ARM64_16K_PA=
GES)
> +	int "Order of maximal physically contiguous allocations" if ARM64_4K_=
PAGES || ARM64_16K_PAGES

It seems that "if EXPERT" was dropped by accident here.

>  	default "13" if ARM64_64K_PAGES
>  	default "11" if ARM64_16K_PAGES
>  	default "10"
>  	help
> -	  The kernel memory allocator divides physically contiguous memory
> -	  blocks into "zones", where each zone is a power of two number of
> -	  pages.  This option selects the largest power of two that the kerne=
l
> -	  keeps in the memory allocator.  If you need to allocate very large
> -	  blocks of physically contiguous memory, then you may need to
> -	  increase this value.
> +	  The kernel page allocator limits the size of maximal physically
> +	  contiguous allocations. The limit is called MAX_ORDER and it
> +	  defines the maximal power of two of number of pages that can be
> +	  allocated as a single contiguous block. This option allows
> +	  overriding the default setting when ability to allocate very
> +	  large blocks of physically contiguous memory is required.
>
> -	  We make sure that we can allocate up to a HugePage size for each co=
nfiguration.
> -	  Hence we have :
> -		MAX_ORDER =3D PMD_SHIFT - PAGE_SHIFT  =3D> PAGE_SHIFT - 3
> +	  The maximal size of allocation cannot exceed the size of the
> +	  section, so the value of MAX_ORDER should satisfy
>
> -	  However for 4K, we choose a higher default value, 10 as opposed to =
9, giving us
> -	  4M allocations matching the default size used by generic code.
> +	    MAX_ORDER + PAGE_SHIFT <=3D SECTION_SIZE_BITS
> +
> +	  Don't change if unsure.
>
>  config UNMAP_KERNEL_AT_EL0
>  	bool "Unmap kernel when running in userspace (aka \"KAISER\")" if EXP=
ERT
> -- =

> 2.35.1


--
Best Regards,
Yan, Zi

--=_MailMate_C127E265-4DDB-40BB-87AD-DB2006154019_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename=signature.asc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmQdqkEPHHppeUBudmlk
aWEuY29tAAoJEOJ/noEUByhUwaIP/RG0bciGb3wj5HWQeRaRqWKWcktYcPQ7w4Dh
2pGQeKuSL51RphMV2eO9lDSw0fmEyRTvCWVHKaMCD/9leDkY5chAmu7jpb1IUPTp
3jK8kg56Iepg13Gx3EWW1KDE2y/3GarCF6JcVvSuVb0yVsP70XPbMHoS7qgI6WjN
vs14YoCZRPSA5OaCRDmrh7bc4UXkU7Biwsg8DiOsZcnjMFm3HJgafOhLQ57UWtQF
f6g/uls+c+s1BtCGgZ48iygBq1oJeVn30IkXU/+LeEPGj6qLUXJAcXqTHEXmaW8h
tbzaHVog1hMjOYuUoCfH+YAgKQ833P19IST6L2CsGh+LQZC3oPUBA7N2HGVa1RtL
YNkHl4nKsh3yX5TxNadzMdfldoW3oBho0GnxaL93gFknFl+sEudEf7ExRJeXaFjo
rCVelBEyVCfr0k6pngXCCfs/lw4SYqTb+k+ZbxA+WIgaTqOMUe62wThNnfHrENy6
OKX6UltE6o5l5XbF3T12cmWemZzBWwOVGpWSUxoImM1isuYl+6DmAbZdcDBImY80
lLTKlsK7uc9GfQfOmTCicDT9yTR16alIuxP262DfQryqYcwmHqjDwLLyk1JmdRYp
/o94M++puGJfVSMk/3fBkmvVjH/4+J18ZQ/hW4F1pCWz9OSik+y1bOfSovihFeyB
46TBIGnB
=WRnA
-----END PGP SIGNATURE-----

--=_MailMate_C127E265-4DDB-40BB-87AD-DB2006154019_=--