Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230324035909.1727356-1-treapking@chromium.org>
In-Reply-To: <20230324035909.1727356-1-treapking@chromium.org>
From:   Doug Anderson <dianders@chromium.org>
Date:   Fri, 24 Mar 2023 07:00:15 -0700
Message-ID: <CAD=FV=WXeVYj2jRHLjD2wWCimb-wA+5QX-UaDhz9NogLGTTARw@mail.gmail.com>
Subject: Re: [PATCH] drm/bridge: ps8640: Return NULL immediately when EDID
 read fail
To:     Pin-yen Lin <treapking@chromium.org>
Cc:     Andrzej Hajda <andrzej.hajda@intel.com>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Robert Foss <rfoss@kernel.org>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,

On Thu, Mar 23, 2023 at 8:59=E2=80=AFPM Pin-yen Lin <treapking@chromium.org=
> wrote:
>
> drm_edid_read returns NULL on error, so feeding it directly into
> drm_edid_duplicate may lead to NULL pointer dereference. Add a check to
> guard this.
>
> Fixes: 6a17b4d1b52f ("drm/bridge: ps8640: Add a cache for EDID")
> Signed-off-by: Pin-yen Lin <treapking@chromium.org>
> ---
>
>  drivers/gpu/drm/bridge/parade-ps8640.c | 6 ++++++
>  1 file changed, 6 insertions(+)

Given that the other patch just landed and this is a straightforward
fix, I'm not doing the customary "delay" before landing and I've
pushed this to drm-misc-next:

14aed8ea48e2 drm/bridge: ps8640: Return NULL immediately when EDID read fai=
l

If someone else had extra feedback on this it could always be handled
in a followon patch.

-Doug