Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Zi Yan <ziy@nvidia.com>
To:     Mike Rapoport <rppt@kernel.org>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Christophe Leroy <christophe.leroy@csgroup.eu>,
        "David S. Miller" <davem@davemloft.net>,
        Dinh Nguyen <dinguyen@kernel.org>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Guo Ren <guoren@kernel.org>,
        John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Max Filippov <jcmvbkbc@gmail.com>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Rich Felker <dalias@libc.org>,
        Russell King <linux@armlinux.org.uk>,
        Will Deacon <will@kernel.org>,
        Yoshinori Sato <ysato@users.sourceforge.jp>,
        linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org,
        linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-m68k@lists.linux-m68k.org, linux-mm@kvack.org,
        linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org,
        linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org
Subject: Re: [PATCH v2 11/14] sh: reword ARCH_FORCE_MAX_ORDER prompt and help
 text
Date:   Fri, 24 Mar 2023 10:28:36 -0400
Message-ID: <FD865F1A-3878-4829-ADD7-AE4C5E347A9B@nvidia.com>
In-Reply-To: <20230324052233.2654090-12-rppt@kernel.org>
References: <20230324052233.2654090-1-rppt@kernel.org>
 <20230324052233.2654090-12-rppt@kernel.org>
Content-Type: multipart/signed;
 boundary="=_MailMate_EBE470C3-E8AE-4DE1-A309-2E8D4C914274_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qO96Bwx67OxzFlqzJYhSffUOqqs19Ycmz0sm6ZcL5GnTYlQrRYcGc5NxnL9v?=
 =?us-ascii?Q?tQZAPALEQH2FIA+Q596V3tHCxPHAUqJGzYaI7FriFt6zQM8htkN547pp7vXS?=
 =?us-ascii?Q?RWW0KpShvnGAE1Cztq9THYKovRRIfiCkzkL4lSXUeQd2NhkJg8BH01CZtOKa?=
 =?us-ascii?Q?oyNiJu2RK+u1pmsHrgpKEIg8hjSeiu68085/+wBJrYXcckACIdta5h1Oe7h3?=
 =?us-ascii?Q?+0ChM2m2vTLssXAkwoe71kKRWtrlMt/G8HuId2UVh+kerEjKezysqA/3agM7?=
 =?us-ascii?Q?ySGOVOvmTtZL3L6myrZgwuikp9NFcsDl1T2EKXbpI3YEp8lq0oQstsWTRO3x?=
 =?us-ascii?Q?sTaA89mL8eovD6JgG/aov4jDmlqk2r/dVsidfcnCWxT3YeWMbye4rkEOGseT?=
 =?us-ascii?Q?0CfOERDXiF7C95LwJ013+kGmMztJ+e0nqgNWHcO0XutNUlYqc9DtBriLNS6F?=
 =?us-ascii?Q?rhPSH81SWIOZqDxcqgSi8Arox2wSbZEpdPRcSgs2NIhsps1fPUFh18Gatp/3?=
 =?us-ascii?Q?ruXrYrTTJKgARMDXF7Bv+lWM0r8Tjcj3jEVYWc9rBh8j9/MwYjGSKXtKDT6b?=
 =?us-ascii?Q?B2W0RllkJ55Gl+uF6RrKHIMQeaMHQrK89L9s/lOESuWVNzaqSf3tkw65Unlk?=
 =?us-ascii?Q?Xa5KpLL7aLTWKxugIRa5Xbq6RkJUZGZXyk/wLzrWHHFi5LDvr/WapfJjsdcf?=
 =?us-ascii?Q?ZUhvAU8h/FP7w5fqUq/KXoD4TU33YPqk3BIy1xHi8QC7l33oWh8cWxrw03es?=
 =?us-ascii?Q?ue6y9l2mMawOGoqDQ395u5XAFkb+s3ygIyoAPPnHa8Luc8XlqHTzFFUEUhE0?=
 =?us-ascii?Q?nLFGST0raqzdNFhxGLY6zZulysaOhJaPDS3f6tiY2AkwQm/5yOSQEMQn/nUP?=
 =?us-ascii?Q?3z+JgzBCXHrHCM4oNUSzAWWarxIcM+3rvi5ywzOAHQp8uc9LVupeJCo4oyOP?=
 =?us-ascii?Q?1uPc3SlD7rFOFelqHbZ52IUAepbJjk1T09MpTb+18qqMTJBj8oPmnofjK6ov?=
 =?us-ascii?Q?MDpotbKp5UBukHkpmSNh3FmnYn308zIqXY+DY89UKhk5ImXxUfbRn4smBUT5?=
 =?us-ascii?Q?gJiq3wkgbtome16M9cxWnL7FYpOLPuyqlTZtY5yFeoDm/5PwvTS2iqJA980g?=
 =?us-ascii?Q?B2Ra899dHEFgYm0R5qZs9wUwewCTAylnk9+fzlUZI9qFaHlZVkm8DKu+PkJP?=
 =?us-ascii?Q?UD+npX7M6pyhX8ZCuQSbY2S3z6T+JWqlXiAlR+u3kt4xc5w9nwsKSv4psNdl?=
 =?us-ascii?Q?sCQ3BMTySUmvY6KvDjWhprr8risaStVy6KqN2o83EDBNXEwJObg0qfU8V/fY?=
 =?us-ascii?Q?uActpnJ2Tz/zezkVR4mjFZgIlSHc/IsLnwVZxCPwHA8HmH2rQyJnghT/TF2j?=
 =?us-ascii?Q?2x8l7AUuUZd4+ipszmPAJM1kq+2u7CPFF5PcZBmXM1/ZleKtK/KrmAysT7fw?=
 =?us-ascii?Q?Th2sMs0w1OAs5FQ8o5DxnKR0Se54Hsitih2JHhQqM4SX/bWP8o3jMO/A0PnB?=
 =?us-ascii?Q?pHCajneX8vX2REZt+UsDtuweKwaCyFqIs0OyH5nOel/pZmZAZh1F5eVxENqX?=
 =?us-ascii?Q?oU8V4mEQBx2X4/jN6vfFP9Mflq6Ab4OPJUfU+qvb?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9e009667-840b-49a9-985a-08db2c740fd9
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2023 14:28:39.8991
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7TR2a0CMS2iXN8ww/XWYbg4ZQXOVo/gUQj0a0Tw8ox4dBvgSZUQm43uLN7j5eg0K
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4185
X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--=_MailMate_EBE470C3-E8AE-4DE1-A309-2E8D4C914274_=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On 24 Mar 2023, at 1:22, Mike Rapoport wrote:

> From: "Mike Rapoport (IBM)" <rppt@kernel.org>
>
> The prompt and help text of ARCH_FORCE_MAX_ORDER are not even close to
> describe this configuration option.
>
> Update both to actually describe what this option does.
>
> Signed-off-by: Mike Rapoport (IBM) <rppt@kernel.org>
> Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> ---
>  arch/sh/mm/Kconfig | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/arch/sh/mm/Kconfig b/arch/sh/mm/Kconfig
> index 40271090bd7d..fb15ba1052ba 100644
> --- a/arch/sh/mm/Kconfig
> +++ b/arch/sh/mm/Kconfig
> @@ -19,8 +19,7 @@ config PAGE_OFFSET
>  	default "0x00000000"
>
>  config ARCH_FORCE_MAX_ORDER
> -	int "Maximum zone order"
> -	range 8 63 if PAGE_SIZE_16KB

This range is dropped in current patch, but the other ranges are dropped =
in
the next patch. But feel free to ignore this since ultimately the ranges
are all dropped.

> +	int "Order of maximal physically contiguous allocations"
>  	default "8" if PAGE_SIZE_16KB
>  	range 6 63 if PAGE_SIZE_64KB
>  	default "6" if PAGE_SIZE_64KB
> @@ -28,16 +27,18 @@ config ARCH_FORCE_MAX_ORDER
>  	default "13" if !MMU
>  	default "10"
>  	help
> -	  The kernel memory allocator divides physically contiguous memory
> -	  blocks into "zones", where each zone is a power of two number of
> -	  pages.  This option selects the largest power of two that the kerne=
l
> -	  keeps in the memory allocator.  If you need to allocate very large
> -	  blocks of physically contiguous memory, then you may need to
> -	  increase this value.
> +	  The kernel page allocator limits the size of maximal physically
> +	  contiguous allocations. The limit is called MAX_ORDER and it
> +	  defines the maximal power of two of number of pages that can be
> +	  allocated as a single contiguous block. This option allows
> +	  overriding the default setting when ability to allocate very
> +	  large blocks of physically contiguous memory is required.
>
>  	  The page size is not necessarily 4KB. Keep this in mind when
>  	  choosing a value for this option.
>
> +	  Don't change if unsure.
> +
>  config MEMORY_START
>  	hex "Physical memory start address"
>  	default "0x08000000"
> -- =

> 2.35.1


--
Best Regards,
Yan, Zi

--=_MailMate_EBE470C3-E8AE-4DE1-A309-2E8D4C914274_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename=signature.asc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmQds5QPHHppeUBudmlk
aWEuY29tAAoJEOJ/noEUByhU6+sQAJM0BaoLQ3JYR+tN4yC8YqhEBdUlGAiar2eu
amh3KB7M4ygrGx4ivtA/P7dJtCyBDC7LQcpamgwUUGLEeUbxD0O5SPmctZz7Z+ER
awE6TdkjuecDXdm2G5WB4OC/FUFWJ/kHar6eaGSybjQzg31LiU0pOAJus8l0l9v/
PTlEdBnB+XVp6E6TVHafnNai3twlKguqamkAjDpaINar97BtNMuXPDBcBKXeS+RK
9FvK/kWOO8ZpLu1N0RMAYaBEmBtZKedErzKTOzRzM0WwpqTVzWy1gwUmiqKxWr15
OrGrLLzjGcekWkyfRXOC48H/CLWDGZJNE+kElE8vW/cKl2tFhw0aS2RjxvKspYDF
sEdf3jiO9eq4u5nxIgkxc+7Ub+NFruZhPEnfcN5b8yK0I+n6rvdA9+HtQKqDqTAz
VC2HtBqKZKvV5q6hBJFSwBaOKkc7r9/3byaOJsJB50+kNpJkL4O643MUCZlXlf1q
3/X5yMLNC6HtFWfLNUz3TjaJnEuVmqhzulFi1ejm1eN7hJV65xZBgSTpOAA62X2J
hjGWuTQIXclo15ysx94I+oDW9KlIT+Uj4GMY/6sGUNvhPvwXIuKgvvSOsG7YubF2
/IUUoi0yQCXK+NpcdG3nYMosWesxpGrT2Q6Ou0hTbfylUIlnWUput4ARcFqwt5uQ
MLJrryCO
=cDus
-----END PGP SIGNATURE-----

--=_MailMate_EBE470C3-E8AE-4DE1-A309-2E8D4C914274_=--