Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp1267537rwl; Fri, 24 Mar 2023 08:19:01 -0700 (PDT) X-Google-Smtp-Source: AKy350aQ6vT2YEnRE+Z3Oc+5PxFWMzgP5WWWbLa1jsqECEtZFmNDMGqEzWYHFNf5mC64MXTp3tn5 X-Received: by 2002:a17:907:98d0:b0:931:2f96:819c with SMTP id kd16-20020a17090798d000b009312f96819cmr2885286ejc.27.1679671141141; Fri, 24 Mar 2023 08:19:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679671141; cv=none; d=google.com; s=arc-20160816; b=PpOKoqEXfxD0aMzbeF84foVMN/5LSVfMqqJYjbzf5NWMj2NSvOt4JEznSG8OWVUQYV e/cQoRRz0uzNvG7EWc/MCkrABSGrO1uyLy81U/RbVNcJyPwtDV2eB2gaTXkBP+Rf/iUH wjJ1JTMVzkbErYzstnQLnB6rhy55e5awAyFGKxKAWryChYljZQ1hqL5+RcK+7PYqMYsx oMen6L/cL24BXajW3eEKGsZqOwAZ3A9NfToU/fV1Mn7k/XUCAr4CFWmO5BBYUpskKUCt CwmYRF982lFPaG0EWofPbaGECmHaTlTEOuWySjUHNthukg7EymLIZXK4XXXqZk2xJcZ/ TT9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=bwervvL2VqoJp7Lysjwx0FFEhlsKTjSqVYYrPqe2D7Q=; b=JkFfVQ+7EK4t7lAHh67IHOJHC7IXVEtbL6y4h2eb5mFAiI5sDd1HbqoCAO7PHTrAne aj+CiAJjgSkuk6J1BOg3PgwgKE/zQEcEr9w0EA7sxpu9cl4nI0oxweR/OzM1bhp0jR53 w63mbKUCy6Oo4KhpKwvH1XxdoBqD5qOPPFoRh0JZR4O9/Yx41YnOHD8wu6IJ5TLPSbDP 6MRT04oYNuY8LCShaTtMYGz5CpQcObUOBoE1cBXGGJgq9Nh2ZjPudRuNKCSW0KmSCrT9 mYJoT2YzNTifRWqCY62BlnKvS6Ocg5lslNojVPtkXwHL2mimmpKBClLCnoNvLaJcq7Hc BZ4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=TgmwsbLl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b1-20020aa7c901000000b004c2822f85cfsi6398153edt.506.2023.03.24.08.18.36; Fri, 24 Mar 2023 08:19:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=TgmwsbLl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231358AbjCXPRW (ORCPT + 99 others); Fri, 24 Mar 2023 11:17:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229540AbjCXPRV (ORCPT ); Fri, 24 Mar 2023 11:17:21 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2BBE4131; Fri, 24 Mar 2023 08:17:20 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D912D1FEF6; Fri, 24 Mar 2023 15:17:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1679671038; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bwervvL2VqoJp7Lysjwx0FFEhlsKTjSqVYYrPqe2D7Q=; b=TgmwsbLl+DA5Nt70AmZzlhUhFnz2I8NZtHoXA9KZt0n0xrFCGQ/YcA+FBZzx5Gd9YKiOCI bHaGK3KdSJtjWhbFYpt8xp9g3zTgsEdqgjVpEmsD/3IKuaTKEB23gX1Z7Zdt3DkXUwoRe5 7mksq3ezMiaJva+j+TCZ+oYN/uUqCH0= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7BAF4138ED; Fri, 24 Mar 2023 15:17:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id EG8sHf6+HWQUZwAAMHmgww (envelope-from ); Fri, 24 Mar 2023 15:17:18 +0000 Date: Fri, 24 Mar 2023 16:17:17 +0100 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Zi Yan Cc: "Matthew Wilcox (Oracle)" , Yang Shi , Yu Zhao , linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH 2/5] mm: page_owner: add support for splitting to any order in split page_owner. Message-ID: <20230324151717.hawuy5gs6cnxql55@blackpad> References: <20230321004829.2012847-1-zi.yan@sent.com> <20230321004829.2012847-3-zi.yan@sent.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="exvxtogrhnfaw26c" Content-Disposition: inline In-Reply-To: <20230321004829.2012847-3-zi.yan@sent.com> X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --exvxtogrhnfaw26c Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello. On Mon, Mar 20, 2023 at 08:48:26PM -0400, Zi Yan wrote: > @@ -5746,8 +5746,8 @@ static void *make_alloc_exact(unsigned long addr, u= nsigned int order, > struct page *page =3D virt_to_page((void *)addr); > struct page *last =3D page + nr; > =20 > - split_page_owner(page, 1 << order); > - split_page_memcg(page, 1 << order); > + split_page_owner(page, 1 << order, 1); > + split_page_memcg(page, 1 << order, 1); I think here should be > + split_page_owner(page, order, 0); > + split_page_memcg(page, 1 << order, 1); because I was wondering why split_page_memcg() doesn't use orders too? (E.g. it wouldn't work well if nr % new_new !=3D 0). Thanks, Michal --exvxtogrhnfaw26c Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTrXXag4J0QvXXBmkMkDQmsBEOquQUCZB2++wAKCRAkDQmsBEOq uZYWAQCFTMigwoG6hG2bxKjAJtYDo8OWh0BZq1aPs9LM+QVdBwEAvayit0OXGxQ2 MDrtNVNB0nXobbi8EK0m4EAaSr9tCQA= =FNxP -----END PGP SIGNATURE----- --exvxtogrhnfaw26c--