Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 24 Mar 2023 08:28:50 -0700
From:   Alison Schofield <alison.schofield@intel.com>
To:     Sumitra Sharma <sumitraartsy@gmail.com>
Cc:     outreachy@lists.linux.dev, johan@kernel.org, elder@kernel.org,
        gregkh@linuxfoundation.org, greybus-dev@lists.linaro.org,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] Staging: greybus: Use inline functions
Message-ID: <ZB3BshO6Yen25LvB@aschofie-mobl2>
References: <cover.1679642024.git.sumitraartsy@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cover.1679642024.git.sumitraartsy@gmail.com>
Precedence: bulk

On Fri, Mar 24, 2023 at 12:20:30AM -0700, Sumitra Sharma wrote:
> Convert macros to a static inline function, to make the relevant 
> types apparent in the definition and to benefit from the type 
> checking performed by the compiler at call sites.
> 
> CHanges in v2: Change patch subjects, noted by Alison Schofield 


Please review: https://kernelnewbies.org/Outreachyfirstpatch
Section on 'Following the driver commit style'.

To follow the commit style of the greybus driver, update these
commit messages to be under 80 chars, and use "staging", not
"Staging"

Like this:
drivers/staging/greybus$ git log --oneline | head -3
1498054921e2 staging: greybus: Inline pwm_chip_to_gb_pwm_chip()
a7d2a41b7453 staging: greybus: Inline gb_audio_manager_module()
f7d3ece211be staging: greybus: Inline macro gpio_chip_to_gb_gpio_controller()

BTW - I wasn't instantly sure about using 'Inline' as a verb in this
case, so I did this (git log --oneline | grep inline) and found it's
a common use. 

We're building a habit here for when you submit across subsystems
in the future. 

Alison

> 
> Sumitra Sharma (3):
>   Staging: greybus: Use inline function for macro
>     gpio_chip_to_gb_gpio_controller
>   Staging: greybus: Use inline function for gb_audio_manager_module
>   Staging: greybus: Use inline function for pwm_chip_to_gb_pwm_chip
> 
>  drivers/staging/greybus/audio_manager_module.c | 7 +++++--
>  drivers/staging/greybus/gpio.c                 | 7 +++++--
>  drivers/staging/greybus/pwm.c                  | 6 ++++--
>  3 files changed, 14 insertions(+), 6 deletions(-)
> 
> -- 
> 2.25.1
> 
>