Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230310070039.1288927-1-zyytlz.wz@163.com> <ZBx8S0tSz/Ot+xw7@kroah.com>
In-Reply-To: <ZBx8S0tSz/Ot+xw7@kroah.com>
From:   Zheng Hacker <hackerzheng666@gmail.com>
Date:   Fri, 24 Mar 2023 23:34:59 +0800
Message-ID: <CAJedcCznj8Ve7GOJxopG6X9eDXfi8MMKr+BtTZK7D1xDf0PaBQ@mail.gmail.com>
Subject: Re: [PATCH] USB: gadget: udc: Fix use after free bug in
 udc_plat_remove due to race condition
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     Zheng Wang <zyytlz.wz@163.com>, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, 1395428693sheep@gmail.com,
        alex000young@gmail.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Greg KH <gregkh@linuxfoundation.org> =E4=BA=8E2023=E5=B9=B43=E6=9C=8824=E6=
=97=A5=E5=91=A8=E4=BA=94 00:20=E5=86=99=E9=81=93=EF=BC=9A
>
> On Fri, Mar 10, 2023 at 03:00:39PM +0800, Zheng Wang wrote:
> > In udc_plat_probe, &udc->drd_work is bound with
> > udc_drd_work. udc_drd_work may be called by
> > usbd_connect_notify to start the work.
> >
> > Besides, there is a invoking chain:
> > udc_plat_probe
> > ->udc_probe
> > ->usb_add_gadget_udc_release
> > ->usb_add_gadget
> >
> > It will add a new gadget to the udc class driver
> >  list. In usb_add_gadget, it uses usb_udc_release
> >  as its release function, which will kfree(udc)
> >  to when destroying the gadget.
> >
> > If we remove the module which will call udc_plat_remove
> >   to make cleanup, there may be a unfinished work.
> > The possible sequence is as follows:
> >
> > Fix it by finishing the work before cleanup in the udc_plat_remove
> >
> > Fixes: 1b9f35adb0ff ("usb: gadget: udc: Add Synopsys UDC Platform drive=
r")
> > Signed-off-by: Zheng Wang <zyytlz.wz@163.com>
> > ---
> >  drivers/usb/gadget/udc/snps_udc_plat.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/usb/gadget/udc/snps_udc_plat.c b/drivers/usb/gadge=
t/udc/snps_udc_plat.c
> > index 8bbb89c80348..6228e178cc0a 100644
> > --- a/drivers/usb/gadget/udc/snps_udc_plat.c
> > +++ b/drivers/usb/gadget/udc/snps_udc_plat.c
> > @@ -230,6 +230,7 @@ static int udc_plat_remove(struct platform_device *=
pdev)
> >       struct udc *dev;
> >
> >       dev =3D platform_get_drvdata(pdev);
> > +     cancel_delayed_work_sync(&dev->drd_work);
> >
> >       usb_del_gadget_udc(&dev->gadget);
> >       /* gadget driver must not be registered */
> > --
> > 2.25.1
> >
>
> Please test this to verify that it actually works.
>

Hi,

Sorry for my late reply. I will try to simulate a device in qemu to test.

Best regards,
Zheng

> thanks,
>
> greg k-h